Skip to content

Commit 8cc3e70

Browse files
committed
skip tests
1 parent cb11a78 commit 8cc3e70

3 files changed

Lines changed: 19 additions & 8 deletions

File tree

tests/library/browsercontext-storage-state.spec.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,5 +209,8 @@ it('should handle malformed file', async ({ contextFactory }, testInfo) => {
209209
const error = await contextFactory({
210210
storageState: file,
211211
}).catch(e => e);
212-
expect(error.message).toContain(`Error reading storage state from ${file}:\nUnexpected token o in JSON at position 1`);
212+
if (+process.versions.node.split('.')[0] > 18)
213+
expect(error.message).toContain(`Error reading storage state from ${file}:\nUnexpected token 'o', \"not-json\" is not valid JSON`);
214+
else
215+
expect(error.message).toContain(`Error reading storage state from ${file}:\nUnexpected token o in JSON at position 1`);
213216
});

tests/playwright-test/esm.spec.ts

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,8 @@ test('should respect path resolver in experimental mode', async ({ runInlineTest
135135
expect(result.exitCode).toBe(0);
136136
});
137137

138-
test('should use source maps', async ({ runInlineTest }) => {
138+
test('should use source maps', async ({ runInlineTest, nodeVersion }) => {
139+
test.fail(nodeVersion.major >= 20, 'https://github.com/microsoft/playwright/issues/22582');
139140
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/15202' });
140141
const result = await runInlineTest({
141142
'package.json': `{ "type": "module" }`,
@@ -157,7 +158,8 @@ test('should use source maps', async ({ runInlineTest }) => {
157158
expect(output).toContain('[foo] › a.test.ts:4:7 › check project name');
158159
});
159160

160-
test('should show the codeframe in errors', async ({ runInlineTest }) => {
161+
test('should show the codeframe in errors', async ({ runInlineTest, nodeVersion }) => {
162+
test.fail(nodeVersion.major >= 20, 'https://github.com/microsoft/playwright/issues/22582');
161163
const result = await runInlineTest({
162164
'package.json': `{ "type": "module" }`,
163165
'playwright.config.ts': `
@@ -197,7 +199,8 @@ test('should show the codeframe in errors', async ({ runInlineTest }) => {
197199
expect(result.output).toContain(' 11 | error.name = \'FooBarError\';');
198200
});
199201

200-
test('should filter by line', async ({ runInlineTest }) => {
202+
test('should filter by line', async ({ runInlineTest, nodeVersion }) => {
203+
test.fail(nodeVersion.major >= 20, 'https://github.com/microsoft/playwright/issues/22582');
201204
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/15200' });
202205
const result = await runInlineTest({
203206
'package.json': `{ "type": "module" }`,
@@ -346,7 +349,8 @@ test('should resolve no-extension import to .jsx file in ESM mode', async ({ run
346349
expect(result.exitCode).toBe(0);
347350
});
348351

349-
test('should resolve .js import to .tsx file in ESM mode for components', async ({ runInlineTest }) => {
352+
test('should resolve .js import to .tsx file in ESM mode for components', async ({ runInlineTest, nodeVersion }) => {
353+
test.fail(nodeVersion.major >= 20, 'https://github.com/microsoft/playwright/issues/22582');
350354
const result = await runInlineTest({
351355
'package.json': `{ "type": "module" }`,
352356
'playwright.config.ts': `

tests/playwright-test/watch.spec.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ test('should print dependencies in CJS mode', async ({ runInlineTest }) => {
5757
});
5858
});
5959

60-
test('should print dependencies in ESM mode', async ({ runInlineTest }) => {
60+
test('should print dependencies in ESM mode', async ({ runInlineTest, nodeVersion }) => {
61+
test.fail(nodeVersion.major >= 20, 'https://github.com/microsoft/playwright/issues/22582');
6162
const result = await runInlineTest({
6263
'package.json': `{ "type": "module" }`,
6364
'playwright.config.ts': `
@@ -374,7 +375,8 @@ test('should run on changed deps', async ({ runWatchTest, writeFiles }) => {
374375
await testProcess.waitForOutput('Waiting for file changes.');
375376
});
376377

377-
test('should run on changed deps in ESM', async ({ runWatchTest, writeFiles }) => {
378+
test('should run on changed deps in ESM', async ({ runWatchTest, writeFiles, nodeVersion }) => {
379+
test.fail(nodeVersion.major >= 20, 'https://github.com/microsoft/playwright/issues/22582');
378380
const testProcess = await runWatchTest({
379381
'playwright.config.ts': `export default {};`,
380382
'package.json': `{ "type": "module" }`,
@@ -650,7 +652,9 @@ test('should run CT on indirect deps change', async ({ runWatchTest, writeFiles
650652
await testProcess.waitForOutput('Waiting for file changes.');
651653
});
652654

653-
test('should run CT on indirect deps change ESM mode', async ({ runWatchTest, writeFiles }) => {
655+
test('should run CT on indirect deps change ESM mode', async ({ runWatchTest, writeFiles, nodeVersion }) => {
656+
test.fail(nodeVersion.major >= 20, 'https://github.com/microsoft/playwright/issues/22582');
657+
654658
const testProcess = await runWatchTest({
655659
'playwright.config.ts': `
656660
import { defineConfig } from '@playwright/experimental-ct-react';

0 commit comments

Comments
 (0)