Skip to content

Commit e7269a0

Browse files
Saadnajmiclaude
andcommitted
fix(ci): pass CMAKE_BUILD_TYPE when building host hermesc for V1
HermesV1's static_h CMakeLists requires CMAKE_BUILD_TYPE to be set; the upstream `build_host_hermesc` helper in build-apple-framework.sh doesn't pass it, so the from-source fallback in Resolve Hermes failed at the hermesc step with "Please set CMAKE_BUILD_TYPE". Invoke cmake directly from the workflow with -DCMAKE_BUILD_TYPE=Release (the host compiler is always built Release for perf, matching configure_apple_framework's behavior in Debug builds of the apple frameworks). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 46b8d38 commit e7269a0

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/microsoft-resolve-hermes.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,15 +118,17 @@ jobs:
118118
ref: ${{ needs.resolve-hermes.outputs.hermes-commit }}
119119
path: hermes
120120

121+
# HermesV1's CMakeLists requires CMAKE_BUILD_TYPE explicitly. The upstream
122+
# `build_host_hermesc` helper doesn't set it, so we invoke cmake directly here.
121123
- name: Build hermesc
122124
working-directory: hermes
123125
env:
124126
HERMES_PATH: ${{ github.workspace }}/hermes
125127
JSI_PATH: ${{ github.workspace }}/hermes/API/jsi
126128
MAC_DEPLOYMENT_TARGET: '14.0'
127129
run: |
128-
source $GITHUB_WORKSPACE/packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh
129-
build_host_hermesc
130+
cmake -S . -B build_host_hermesc -DJSI_DIR="$JSI_PATH" -DCMAKE_BUILD_TYPE=Release
131+
cmake --build ./build_host_hermesc --target hermesc -j "$(sysctl -n hw.ncpu)"
130132
131133
- name: Upload hermesc artifact
132134
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)