Skip to content

Commit 71efdcb

Browse files
authored
Disable DECKPAM mode behind velocity (#16675)
DECKPAM originally tracked in #16506. Support was added in #16511. But turns out people didn't expect the Terminal to actually be like, compliant: #16654 This closes #16654 while we think over in #16672 how we want to solve this
1 parent ec91be5 commit 71efdcb

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/features.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -177,4 +177,14 @@
177177
</alwaysEnabledBrandingTokens>
178178
</feature>
179179

180+
<feature>
181+
<name>Feature_KeypadModeEnabled</name>
182+
<description>Enables the DECKPAM, DECKPNM sequences to work as intended </description>
183+
<id>16654</id>
184+
<stage>AlwaysDisabled</stage>
185+
<alwaysEnabledBrandingTokens>
186+
<brandingToken>Dev</brandingToken>
187+
</alwaysEnabledBrandingTokens>
188+
</feature>
189+
180190
</featureStaging>

src/terminal/input/terminalInput.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ try
438438
// the ASCII character assigned by the keyboard layout, but when set
439439
// they transmit SS3 escape sequences. When used with a modifier, the
440440
// modifier is embedded as a parameter value (not standard).
441-
if (_inputMode.test(Mode::Keypad))
441+
if (Feature_KeypadModeEnabled::IsEnabled() && _inputMode.test(Mode::Keypad))
442442
{
443443
defineNumericKey(VK_MULTIPLY, L'j');
444444
defineNumericKey(VK_ADD, L'k');
@@ -490,7 +490,7 @@ try
490490

491491
// Keypad keys also depend on Keypad mode, the same as ANSI mappings,
492492
// but the sequences use an ESC ? prefix instead of SS3.
493-
if (_inputMode.test(Mode::Keypad))
493+
if (Feature_KeypadModeEnabled::IsEnabled() && _inputMode.test(Mode::Keypad))
494494
{
495495
defineKeyWithUnusedModifiers(VK_MULTIPLY, L"\033?j"s);
496496
defineKeyWithUnusedModifiers(VK_ADD, L"\033?k"s);

0 commit comments

Comments
 (0)