Skip to content

Commit 7381196

Browse files
committed
Enable DECRQCRA at compile time for all Terminal builds (#19606)
Support for DECRQCRA Request Checksum of Rectangular Area was added in #14989, but left disabled at build time because it could be considered a security risk. In #17895, we unconditionally added a toggle for it to Terminal's settings UI and settings schema (`compatibility.allowDECRQCRA`). For users on Stable and Preview, it didn't actually enable anything. Whoops. Since we have a way to turn it off (and in so doing, mitigate the risk) in Terminal, it's high time for us to remove the feature gating. Conhost doesn't support turning it off for now and so conhost can still have it compiled out, as a treat. (cherry picked from commit 3e29d2a) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgiA9Jg Service-Version: 1.23
1 parent f8efd14 commit 7381196

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/features.xml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,14 @@
128128
<name>Feature_VtChecksumReport</name>
129129
<description>Enables the DECRQCRA checksum report, which can be used to read the screen contents</description>
130130
<id>14974</id>
131-
<stage>AlwaysDisabled</stage>
132-
<alwaysEnabledBrandingTokens>
133-
<brandingToken>Dev</brandingToken>
134-
</alwaysEnabledBrandingTokens>
131+
<stage>AlwaysEnabled</stage>
132+
<alwaysDisabledBrandingTokens>
133+
<!--
134+
Since we have a way to turn this on and off in Terminal, we don't need to hide it behind a feature
135+
flag any longer; however, conhost has no way to turn it off so let's just compile it out for now.
136+
-->
137+
<brandingToken>WindowsInbox</brandingToken>
138+
</alwaysDisabledBrandingTokens>
135139
</feature>
136140

137141
<feature>

0 commit comments

Comments
 (0)