Skip to content

Commit cb28fa7

Browse files
committed
Revert "Reapply "NFCI: use a specific build to run and publish PGO""
This reverts commit ce80e0c.
1 parent 1f93f9b commit cb28fa7

File tree

6 files changed

+11
-40
lines changed

6 files changed

+11
-40
lines changed

build/pgo/Terminal.PGO.DB.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
<files>
1313
<!-- The target directories for pgd files need to remain as is. PGO optimization pass will rely on this exact directory layout. -->
1414
<file src="x64\*.pgd" target="tools\x64"/>
15-
<!--<file src="arm64\*.pgd" target="tools\arm64"/>-->
15+
<file src="arm64\*.pgd" target="tools\arm64"/>
1616
</files>
1717
</package>

build/pgo/Terminal.PGO.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<PropertyGroup>
1111
<!-- Optional, defaults to main. Name of the branch which will be used for calculating branch point. -->
12-
<PGOBranch>dev/duhowett/make-the-pgo-publishing-step-work-again</PGOBranch>
12+
<PGOBranch>main</PGOBranch>
1313

1414
<!-- Mandatory. Name of the NuGet package which will contain PGO databases for consumption by build system. -->
1515
<PGOPackageName>Microsoft.Internal.Windows.Terminal.PGODatabase</PGOPackageName>

build/pipelines/pgo.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,19 +71,19 @@ stages:
7171
condition: succeeded()
7272
jobs:
7373
# This job takes multiple platforms and fans them back in to a single artifact.
74-
#- template: ./templates-v2/job-pgo-merge-pgd.yml
75-
# parameters:
76-
# jobName: MergePGD
77-
# pool:
78-
# vmImage: 'windows-latest'
79-
# buildConfiguration: Release
80-
# buildPlatforms: ${{ parameters.buildPlatforms }}
81-
# artifactStem: -instrumentation
74+
- template: ./templates-v2/job-pgo-merge-pgd.yml
75+
parameters:
76+
jobName: MergePGD
77+
pool:
78+
vmImage: 'windows-latest'
79+
buildConfiguration: Release
80+
buildPlatforms: ${{ parameters.buildPlatforms }}
81+
artifactStem: -instrumentation
8282

8383
- template: ./templates-v2/job-pgo-build-nuget-and-publish.yml
8484
parameters:
8585
pool:
8686
vmImage: 'windows-latest'
87-
#dependsOn: MergePGD
87+
dependsOn: MergePGD
8888
buildConfiguration: Release
8989
artifactStem: -instrumentation

build/pipelines/templates-v2/job-pgo-build-nuget-and-publish.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,6 @@ jobs:
4141
inputs:
4242
artifact: pgd-merged-${{ parameters.buildConfiguration }}${{ parameters.artifactStem }}
4343
downloadPath: $(artifactsPath)
44-
buildType: specific
45-
runVersion: specific
46-
project: Dart
47-
pipeline: 71496
48-
runId: 138507110
49-
allowPartiallySucceededBuilds: true
50-
allowFailedBuilds: true
51-
5244

5345
- template: steps-ensure-nuget-version.yml
5446

build/pipelines/templates-v2/job-pgo-merge-pgd.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -41,25 +41,11 @@ jobs:
4141
artifactName: build-${{ platform }}-${{ parameters.buildConfiguration }}${{ parameters.artifactStem }}
4242
itemPattern: '**/*.pgd'
4343
downloadPath: '$(Build.SourcesDirectory)/pgd/${{ platform }}/${{ parameters.buildConfiguration }}'
44-
buildType: specific
45-
runVersion: specific
46-
project: Dart
47-
pipeline: 71496
48-
runId: 138504234
49-
allowPartiallySucceededBuilds: true
50-
allowFailedBuilds: true
5144
- task: DownloadPipelineArtifact@2
5245
displayName: Download PGO Counts for ${{ platform }}
5346
inputs:
5447
artifactName: pgc-intermediates-${{ platform }}-${{ parameters.buildConfiguration }}${{ parameters.artifactStem }}
5548
downloadPath: '$(Build.SourcesDirectory)/pgc/${{ platform }}/${{ parameters.buildConfiguration }}'
56-
buildType: specific
57-
runVersion: specific
58-
project: Dart
59-
pipeline: 71496
60-
runId: 138504234
61-
allowPartiallySucceededBuilds: true
62-
allowFailedBuilds: true
6349
- pwsh: |-
6450
$Arch = '${{ platform }}'
6551
$Conf = '${{ parameters.buildConfiguration }}'

build/pipelines/templates-v2/job-run-pgo-tests.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,6 @@ jobs:
3636
inputs:
3737
artifactName: build-${{ parameters.buildPlatform }}-$(BuildConfiguration)${{ parameters.artifactStem }}
3838
downloadPath: $(Terminal.BinDir)
39-
buildType: specific
40-
runVersion: specific
41-
project: Dart
42-
pipeline: 71496
43-
runId: 138504234
44-
allowPartiallySucceededBuilds: true
45-
allowFailedBuilds: true
4639

4740
# The tests expect Terminal to be an unpackaged distribution named terminal-0.0.1.0 (after the dev build version scheme)
4841
# Extract to that folder explicitly and strip the embedded folder name from the unpackaged archive.

0 commit comments

Comments
 (0)