Skip to content

Commit d5a8413

Browse files
committed
NFCI: use a specific build to run and publish PGO
1 parent 2a50772 commit d5a8413

File tree

6 files changed

+40
-11
lines changed

6 files changed

+40
-11
lines changed

build/pgo/Terminal.PGO.DB.nuspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
<files>
1313
<!-- The target directories for pgd files need to remain as is. PGO optimization pass will rely on this exact directory layout. -->
1414
<file src="x64\*.pgd" target="tools\x64"/>
15-
<file src="arm64\*.pgd" target="tools\arm64"/>
15+
<!--<file src="arm64\*.pgd" target="tools\arm64"/>-->
1616
</files>
1717
</package>

build/pgo/Terminal.PGO.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<PropertyGroup>
1111
<!-- Optional, defaults to main. Name of the branch which will be used for calculating branch point. -->
12-
<PGOBranch>main</PGOBranch>
12+
<PGOBranch>dev/duhowett/make-the-pgo-publishing-step-work-again</PGOBranch>
1313

1414
<!-- Mandatory. Name of the NuGet package which will contain PGO databases for consumption by build system. -->
1515
<PGOPackageName>Microsoft.Internal.Windows.Terminal.PGODatabase</PGOPackageName>

build/pipelines/pgo.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -70,19 +70,19 @@ stages:
7070
condition: succeeded()
7171
jobs:
7272
# This job takes multiple platforms and fans them back in to a single artifact.
73-
- template: ./templates-v2/job-pgo-merge-pgd.yml
74-
parameters:
75-
jobName: MergePGD
76-
pool:
77-
vmImage: 'windows-latest'
78-
buildConfiguration: Release
79-
buildPlatforms: ${{ parameters.buildPlatforms }}
80-
artifactStem: -instrumentation
73+
#- template: ./templates-v2/job-pgo-merge-pgd.yml
74+
# parameters:
75+
# jobName: MergePGD
76+
# pool:
77+
# vmImage: 'windows-latest'
78+
# buildConfiguration: Release
79+
# buildPlatforms: ${{ parameters.buildPlatforms }}
80+
# artifactStem: -instrumentation
8181

8282
- template: ./templates-v2/job-pgo-build-nuget-and-publish.yml
8383
parameters:
8484
pool:
8585
vmImage: 'windows-latest'
86-
dependsOn: MergePGD
86+
#dependsOn: MergePGD
8787
buildConfiguration: Release
8888
artifactStem: -instrumentation

build/pipelines/templates-v2/job-pgo-build-nuget-and-publish.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,14 @@ jobs:
4040
inputs:
4141
artifact: pgd-merged-${{ parameters.buildConfiguration }}${{ parameters.artifactStem }}
4242
downloadPath: $(artifactsPath)
43+
buildType: specific
44+
runVersion: specific
45+
project: Dart
46+
pipeline: 71496
47+
runId: 138507110
48+
allowPartiallySucceededBuilds: true
49+
allowFailedBuilds: true
50+
4351

4452
- template: steps-ensure-nuget-version.yml
4553

build/pipelines/templates-v2/job-pgo-merge-pgd.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,25 @@ jobs:
4141
artifactName: build-${{ platform }}-${{ parameters.buildConfiguration }}${{ parameters.artifactStem }}
4242
itemPattern: '**/*.pgd'
4343
downloadPath: '$(Build.SourcesDirectory)/pgd/${{ platform }}/${{ parameters.buildConfiguration }}'
44+
buildType: specific
45+
runVersion: specific
46+
project: Dart
47+
pipeline: 71496
48+
runId: 138504234
49+
allowPartiallySucceededBuilds: true
50+
allowFailedBuilds: true
4451
- task: DownloadPipelineArtifact@2
4552
displayName: Download PGO Counts for ${{ platform }}
4653
inputs:
4754
artifactName: pgc-intermediates-${{ platform }}-${{ parameters.buildConfiguration }}${{ parameters.artifactStem }}
4855
downloadPath: '$(Build.SourcesDirectory)/pgc/${{ platform }}/${{ parameters.buildConfiguration }}'
56+
buildType: specific
57+
runVersion: specific
58+
project: Dart
59+
pipeline: 71496
60+
runId: 138504234
61+
allowPartiallySucceededBuilds: true
62+
allowFailedBuilds: true
4963
- pwsh: |-
5064
$Arch = '${{ platform }}'
5165
$Conf = '${{ parameters.buildConfiguration }}'

build/pipelines/templates-v2/job-run-pgo-tests.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,13 @@ jobs:
3636
inputs:
3737
artifactName: build-${{ parameters.buildPlatform }}-$(BuildConfiguration)${{ parameters.artifactStem }}
3838
downloadPath: $(Terminal.BinDir)
39+
buildType: specific
40+
runVersion: specific
41+
project: Dart
42+
pipeline: 71496
43+
runId: 138504234
44+
allowPartiallySucceededBuilds: true
45+
allowFailedBuilds: true
3946

4047
# The tests expect Terminal to be an unpackaged distribution named terminal-0.0.1.0 (after the dev build version scheme)
4148
# Extract to that folder explicitly and strip the embedded folder name from the unpackaged archive.

0 commit comments

Comments
 (0)