Fix stale weak pointer access (#19856)

benediktjohannes · web-flow · commit d9d824a84012 · 2026-02-13T19:15:17.000+01:00
Closes #19855
diff --git a/src/cascadia/TerminalApp/Tab.cpp b/src/cascadia/TerminalApp/Tab.cpp
@@ -1114,7 +1114,7 @@ namespace winrt::TerminalApp::implementation
             [dispatcher, weakThis](auto&&, auto&&) -> safe_void_coroutine {
                 const auto weakThisCopy = weakThis;
                 co_await wil::resume_foreground(dispatcher);
-                if (auto tab{ weakThis.get() })
+                if (auto tab{ weakThisCopy.get() })
                 {
                     tab->_RecalculateAndApplyReadOnly();
                 }

Original file line number	Diff line number	Diff line change
`@@ -1114,7 +1114,7 @@ namespace winrt::TerminalApp::implementation`
`1114`	`1114`	`[dispatcher, weakThis](auto&&, auto&&) -> safe_void_coroutine {`
`1115`	`1115`	`const auto weakThisCopy = weakThis;`
`1116`	`1116`	`co_await wil::resume_foreground(dispatcher);`
`1117`		`- if (auto tab{ weakThis.get() })`
	`1117`	`+ if (auto tab{ weakThisCopy.get() })`
`1118`	`1118`	`{`
`1119`	`1119`	`tab->_RecalculateAndApplyReadOnly();`
`1120`	`1120`	`}`