Skip to content

Commit 41fce4c

Browse files
authored
Do not assert in pointer analysis when visiting unknown ops (#251)
Instead of asserting which will crash the pass, we want to return failure which allow other fallback passes to handle the unsupported pointer sequences.
1 parent eea2876 commit 41fce4c

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

lib/AnalysisStructured/PtrAnalysis.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -711,7 +711,8 @@ LogicalResult PtrAnalysis::visitOperand(Value operand, PtrState &state,
711711
} else if (auto makeTensorOp = dyn_cast<triton::MakeTensorPtrOp>(op)) {
712712
llvm_unreachable("Unexpected operand defining operation tts.make_tptr");
713713
} else {
714-
llvm_unreachable("Unexpected operand defining operation");
714+
op->emitRemark("Unexpected defining op for triton pointer operand");
715+
return failure();
715716
}
716717
} else {
717718
state.source = operand;

0 commit comments

Comments
 (0)