Code review feedback.

Author: tjprescott

packages/versioning/src/validate.ts

@@ -169,17 +169,15 @@ export function $onValidate(program: Program) {
  */
 function validateVersionEnumValuesUnique(program: Program, namespace: Namespace) {
   const [_, versionMap] = getVersions(program, namespace);
-  const size = versionMap?.size;
-  const values = new Set(versionMap?.getVersions().map((v) => v.value));
-  if (size && values) {
-    if (size !== values.size) {
-      const enumName = versionMap.getVersions()[0].enumMember.enum.name;
-      reportDiagnostic(program, {
-        code: "version-duplicate",
-        format: { name: enumName },
-        target: namespace,
-      });
-    }
+  if (versionMap === undefined) return;
+  const values = new Set(versionMap.getVersions().map((v) => v.value));
+  if (versionMap.size !== values.size) {
+    const enumName = versionMap.getVersions()[0].enumMember.enum.name;
+    reportDiagnostic(program, {
+      code: "version-duplicate",
+      format: { name: enumName },
+      target: namespace,
+    });
   }
 }
 

packages/versioning/test/incompatible-versioning.test.ts

@@ -79,7 +79,6 @@ describe("versioning: incompatible use of decorators", () => {
       severity: "error",
     });
   });
-
 });
 
 describe("versioning: validate incompatible references", () => {