Skip to content

Commit 0b07f91

Browse files
committed
deep-eql
1 parent ea677ed commit 0b07f91

File tree

5 files changed

+53
-35
lines changed

5 files changed

+53
-35
lines changed

package-lock.json

Lines changed: 46 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,7 @@
377377
"@microsoft/eslint-config-azuretools": "^0.2.1",
378378
"@microsoft/vscode-azext-dev": "^2.0.1",
379379
"@octokit/types": "^9.1.0",
380+
"@types/deep-eql": "^4.0.0",
380381
"@types/fs-extra": "^8.1.1",
381382
"@types/gulp": "^4.0.6",
382383
"@types/mocha": "^8.2.2",
@@ -414,6 +415,7 @@
414415
"@octokit/rest": "^18.5.2",
415416
"buffer": "^6.0.3",
416417
"dayjs": "^1.11.3",
418+
"deep-eql": "^4.1.3",
417419
"dotenv": "^16.0.0",
418420
"fs-extra": "^8.1.0",
419421
"semver": "^7.5.2",

src/tree/ContainerAppItem.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import { ContainerApp, ContainerAppsAPIClient, KnownActiveRevisionsMode, Revisio
77
import { getResourceGroupFromId, uiUtils } from "@microsoft/vscode-azext-azureutils";
88
import { AzureWizard, DeleteConfirmationStep, IActionContext, callWithTelemetryAndErrorHandling, createContextValue, createSubscriptionContext, nonNullProp, nonNullValue } from "@microsoft/vscode-azext-utils";
99
import { AzureSubscription, ViewPropertiesModel } from "@microsoft/vscode-azureresources-api";
10+
import * as deepEqual from "deep-eql";
1011
import { TreeItem, TreeItemCollapsibleState, Uri } from "vscode";
1112
import { DeleteAllContainerAppsStep } from "../commands/deleteContainerApp/DeleteAllContainerAppsStep";
1213
import { IDeleteContainerAppWizardContext } from "../commands/deleteContainerApp/IDeleteContainerAppWizardContext";
@@ -15,7 +16,6 @@ import { ext } from "../extensionVariables";
1516
import { createActivityContext } from "../utils/activityUtils";
1617
import { createContainerAppsAPIClient, createContainerAppsClient } from "../utils/azureClients";
1718
import { createPortalUrl } from "../utils/createPortalUrl";
18-
import { isDeepEqual } from "../utils/isDeepEqual";
1919
import { localize } from "../utils/localize";
2020
import { treeUtils } from "../utils/treeUtils";
2121
import type { ContainerAppsItem, TreeElementBase } from "./ContainerAppsBranchDataProvider";
@@ -170,7 +170,7 @@ export class ContainerAppItem implements ContainerAppsItem {
170170
return false;
171171
}
172172

173-
return !isDeepEqual(this.containerApp.template, draftTemplate);
173+
return !deepEqual(this.containerApp.template, draftTemplate);
174174
}
175175
}
176176

src/tree/scaling/ScaleItem.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
import { KnownActiveRevisionsMode, Revision, Scale } from "@azure/arm-appcontainers";
77
import { createGenericElement, nonNullValue } from "@microsoft/vscode-azext-utils";
88
import type { AzureSubscription, ViewPropertiesModel } from "@microsoft/vscode-azureresources-api";
9+
import * as deepEqual from 'deep-eql';
910
import { ThemeIcon, TreeItem, TreeItemCollapsibleState } from "vscode";
1011
import { ext } from "../../extensionVariables";
11-
import { isDeepEqual } from "../../utils/isDeepEqual";
1212
import { localize } from "../../utils/localize";
1313
import { treeUtils } from "../../utils/treeUtils";
1414
import type { ContainerAppModel } from "../ContainerAppItem";
@@ -83,10 +83,10 @@ export class ScaleItem implements RevisionsItemModel {
8383
}
8484

8585
if (this.containerApp.revisionsMode === KnownActiveRevisionsMode.Single) {
86-
return !!this.containerApp.template?.scale && !isDeepEqual(this.containerApp.template.scale, scaleDraftTemplate);
86+
return !!this.containerApp.template?.scale && !deepEqual(this.containerApp.template.scale, scaleDraftTemplate);
8787
} else {
8888
// We only care about showing changes to descendants of the revision draft item when in multiple revisions mode
89-
// return !!this.revision.template?.scale && RevisionDraftItem.hasDescendant(this) && !isDeepEqual(this.revision.template.scale, scaleDraftTemplate);
89+
// return !!this.revision.template?.scale && RevisionDraftItem.hasDescendant(this) && !deepEqual(this.revision.template.scale, scaleDraftTemplate);
9090

9191
return false; // Placeholder
9292
}

src/utils/isDeepEqual.ts

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)