Migration work for VS Code.dev (#288)

* Apply changes for vscode.dev

* Changes for vscode.dev

* Remove comment

* Publish web bundle and package.json to a blob container for testing on vscode.dev (#253)

* Fix edit target port (#258)

Originally authored by: Alex Weininger
Cherry-picked for use by:  Matthew Fisher

* Update the acr sdk

* Fix some merge errors

* Fix activityUtils

* Re-add missing type

* Re-add experimental service

* Changes using the new azext-utils package

* Fix some build/lint errors

* Comment, remove eslint disable, suppressCleanWebpack

* Ignore constants file used by fs-extra

* Fix up some dependency stuff

* Remove some unneeded devDependencies

* Fix package-lock.json to fix `npm ci`

---------

Co-authored-by: Matthew Rayermann <marayerm@microsoft.com>
Co-authored-by: Matthew Fisher <40250218+MicroFish91@users.noreply.github.com>

Author: 3 people

.azure-pipelines/common/package.yml

@@ -15,12 +15,72 @@ steps:
   displayName: 'Copy vsix to staging directory'
   inputs:
     Contents: '**/*.vsix'
-    TargetFolder: '$(build.artifactstagingdirectory)'
+    TargetFolder: '$(build.artifactstagingdirectory)/vsix'
+
+- task: CopyFiles@2
+  displayName: 'Copy web bundle to staging directory'
+  inputs:
+    Contents: |
+      dist/web/*.js*
+      package.json
+      package.nls.json
+      resources/**
+    TargetFolder: '$(build.artifactstagingdirectory)/web/'
 
 - task: PublishBuildArtifacts@1
   displayName: 'Publish artifacts: vsix'
   inputs:
-    PathtoPublish: '$(build.artifactstagingdirectory)'
+    PathtoPublish: '$(build.artifactstagingdirectory)/vsix'
     ArtifactName: vsix
   # Only publish vsix from linux build since we use this to release and want to stay consistent
   condition: and(eq(variables['Agent.OS'], 'Linux'), ne(variables['System.PullRequest.IsFork'], 'True'))
+
+- task: AzureFileCopy@4
+  # If AzureFileCopy ever supports not using account keys we should consider making use of it.
+  # If we do, we should also consider moving to user delegatation SAS in the generate SAS step.
+  # See: https://github.com/microsoft/azure-pipelines-tasks/issues/15610
+  displayName: 'Upload web to blob storage'
+  inputs:
+    SourcePath: '$(build.artifactstagingdirectory)/web/*'
+    # This is a service connection for the ADO project. Can be managed under ADO project settings.
+    azureSubscription: ms-azuretools-vscode-dot-dev-connection
+    Destination: AzureBlob
+    storage: $(WEB_BUILDS_STG_ACCT)
+    ContainerName: $(WEB_BUILDS_CONTAINER)
+    BlobPrefix: '$(build.buildnumber)'
+  # Only do steps for publishing web bits on Windows as AzureFileCopy is only supported on Windows
+  # See: https://github.com/microsoft/azure-pipelines-tasks/issues/8920
+  condition: and(eq(variables['Agent.OS'], 'Windows_NT'), ne(variables['System.PullRequest.IsFork'], 'True'))
+
+- task: AzureCLI@2
+  displayName: 'Generate SAS to web'
+  inputs:
+    # This is a service connection for the ADO project. Can be managed under ADO project settings.
+    azureSubscription: ms-azuretools-vscode-dot-dev-connection
+    scriptType: 'ps'
+    scriptLocation: 'inlineScript'
+    inlineScript: |
+      $sasToken = az storage container generate-sas `
+        --account-name $(WEB_BUILDS_STG_ACCT) `
+        --name $(WEB_BUILDS_CONTAINER) `
+        --permissions r `
+        --expiry ((Get-Date).AddDays(30)).ToUniversalTime().ToString("yyyy-MM-ddTHH:mm:ssK") `
+        --auth-mode key `
+        --out tsv
+      # Replace all % with %25 so vscode.dev does not re-encode the URL thus breaking it.
+      $sasToken = $sasToken -replace ("%", "%25")
+      $extensionRootUrl = "https://$(WEB_BUILDS_STG_ACCT).blob.core.windows.net/$(WEB_BUILDS_CONTAINER)/" + "$(build.buildnumber)" + "/?" + $sasToken
+      $extensionRootUrl | Out-File -FilePath '$(build.artifactstagingdirectory)/web-sas.txt'
+      echo $extensionRootUrl
+  # Only do steps for publishing web bits on Windows as AzureFileCopy is only supported on Windows
+  # See: https://github.com/microsoft/azure-pipelines-tasks/issues/8920
+  condition: and(eq(variables['Agent.OS'], 'Windows_NT'), ne(variables['System.PullRequest.IsFork'], 'True'))
+
+- task: PublishBuildArtifacts@1
+  displayName: 'Publish artifacts: web-sas'
+  inputs:
+    PathtoPublish: '$(build.artifactstagingdirectory)/web-sas.txt'
+    ArtifactName: web-sas
+  # Only do steps for publishing web bits on Windows as AzureFileCopy is only supported on Windows
+  # See: https://github.com/microsoft/azure-pipelines-tasks/issues/8920
+  condition: and(eq(variables['Agent.OS'], 'Windows_NT'), ne(variables['System.PullRequest.IsFork'], 'True'))

.azure-pipelines/main.yml

@@ -1,4 +1,6 @@
 variables:
+  WEB_BUILDS_STG_ACCT: vscodedotdev
+  WEB_BUILDS_CONTAINER: web-builds
   ${{ if eq(variables['Build.Reason'], 'Schedule') }}:
     ENABLE_LONG_RUNNING_TESTS: true
     ENABLE_COMPLIANCE: true

.vscode/launch.json

@@ -117,6 +117,26 @@
                 "DEBUG_WEBPACK": "1",
                 "ENABLE_LONG_RUNNING_TESTS": ""
             }
+        },
+        {
+            "name": "Launch Extension Web (webpack)",
+            "type": "extensionHost",
+            "request": "launch",
+            "debugWebWorkerHost": true,
+            "runtimeExecutable": "${execPath}",
+            "args": [
+                "--extensionDevelopmentPath=${workspaceFolder}",
+                "--extensionDevelopmentPath=${workspaceFolder}/../vscode-azureresourcegroups",
+                "--extensionDevelopmentKind=web"
+            ],
+            "outFiles": [
+                "${workspaceFolder}/dist/web/**/*.js"
+            ],
+            "env": {
+                "DEBUGTELEMETRY": "v",
+                "NODE_DEBUG": "",
+                "DEBUG_WEBPACK": "1"
+            }
         }
     ]
 }

extension.bundle.ts

@@ -16,7 +16,7 @@
 // At runtime the tests live in dist/tests and will therefore pick up the main webpack bundle at dist/extension.bundle.js.
 export * from '@microsoft/vscode-azext-utils';
 // Export activate/deactivate for main.js
-export { activateInternal, deactivateInternal } from './src/extension';
+export { activate, deactivate } from './src/extension';
 export * from './src/extensionVariables';
 
 // NOTE: The auto-fix action "source.organizeImports" does weird things with this file, but there doesn't seem to be a way to disable it on a per-file basis so we'll just let it happen

main.js

@@ -19,11 +19,11 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const extension = require('./out/src/extension');
 
 async function activate(ctx) {
-    return await extension.activateInternal(ctx, perfStats, true /* ignoreBundle */);
+    return await extension.activate(ctx, perfStats);
 }
 
 async function deactivate(ctx) {
-    return await extension.deactivateInternal(ctx, perfStats);
+    return await extension.deactivate(ctx, perfStats);
 }
 
 // Export as entrypoints for vscode