Skip to content

Commit b08d299

Browse files
authored
Remove rgapi reference (#264)
1 parent 69dfb4f commit b08d299

File tree

2 files changed

+10
-11
lines changed

2 files changed

+10
-11
lines changed

src/commands/deployImage/deployImageApi.ts

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@
33
* Licensed under the MIT License. See License.txt in the project root for license information.
44
*--------------------------------------------------------------------------------------------*/
55

6-
import { SubscriptionTreeItemBase } from "@microsoft/vscode-azext-azureutils";
7-
import { ISubscriptionContext } from "@microsoft/vscode-azext-dev";
8-
import { callWithMaskHandling, IActionContext, ISubscriptionActionContext } from "@microsoft/vscode-azext-utils";
6+
import { callWithMaskHandling, createSubscriptionContext, ISubscriptionActionContext, ITreeItemPickerContext } from "@microsoft/vscode-azext-utils";
97
import { acrDomain } from "../../constants";
10-
import { ext } from "../../extensionVariables";
118
import { detectRegistryDomain, getRegistryFromAcrName } from "../../utils/imageNameUtils";
9+
import { pickContainerApp } from "../../utils/pickContainerApp";
1210
import { deployImage } from "./deployImage";
1311
import { IDeployImageContext } from "./IDeployImageContext";
1412

@@ -21,9 +19,12 @@ interface DeployImageToAcaOptionsContract {
2119
secret?: string;
2220
}
2321

24-
export async function deployImageApi(context: IActionContext & Partial<IDeployImageContext>, deployImageOptions: DeployImageToAcaOptionsContract): Promise<void> {
25-
const subscription: ISubscriptionContext = (await ext.rgApi.appResourceTree.showTreeItemPicker<SubscriptionTreeItemBase>(SubscriptionTreeItemBase.contextValue, context)).subscription;
26-
Object.assign(context, subscription, deployImageOptions);
22+
export async function deployImageApi(context: ITreeItemPickerContext & Partial<IDeployImageContext>, deployImageOptions: DeployImageToAcaOptionsContract): Promise<void> {
23+
context.suppressCreatePick = true;
24+
const node = await pickContainerApp(context);
25+
const { subscription } = node;
26+
27+
Object.assign(context, {...createSubscriptionContext(subscription) }, deployImageOptions);
2728

2829
context.registryDomain = detectRegistryDomain(deployImageOptions.registryName);
2930
if (context.registryDomain === acrDomain) {
@@ -40,8 +41,8 @@ export async function deployImageApi(context: IActionContext & Partial<IDeployIm
4041
context.valuesToMask.push(deployImageOptions.image);
4142

4243
if (deployImageOptions.secret) {
43-
return callWithMaskHandling<void>(() => deployImage(context, undefined), deployImageOptions.secret);
44+
return callWithMaskHandling<void>(() => deployImage(context, node), deployImageOptions.secret);
4445
} else {
45-
return deployImage(context, undefined);
46+
return deployImage(context, node);
4647
}
4748
}

src/extensionVariables.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import { IAzExtOutputChannel, IExperimentationServiceAdapter } from "@microsoft/vscode-azext-utils";
7-
import { AzureHostExtensionApi } from "@microsoft/vscode-azext-utils/hostapi";
87
import { AzureResourcesExtensionApi } from "@microsoft/vscode-azureresources-api";
98
import { ExtensionContext } from "vscode";
109
import { ContainerAppsBranchDataProvider } from "./tree/ContainerAppsBranchDataProvider";
@@ -19,7 +18,6 @@ export namespace ext {
1918
export let ignoreBundle: boolean | undefined;
2019
export const prefix: string = 'containerApps';
2120
export let experimentationService: IExperimentationServiceAdapter;
22-
export let rgApi: AzureHostExtensionApi;
2321
export let rgApiV2: AzureResourcesExtensionApi;
2422

2523
export let state: TreeItemStateStore;

0 commit comments

Comments
 (0)