More fixes

Author: MicroFish91

src/commands/deployWorkspaceProject/DeployWorkspaceProjectSettings.ts

@@ -19,18 +19,13 @@ const deployWorkspaceProjectPrefix: string = 'deployWorkspaceProject';
 export async function getDeployWorkspaceProjectSettings(rootFolder: WorkspaceFolder): Promise<DeployWorkspaceProjectSettings> {
     const settingsPath: string = settingUtils.getDefaultRootWorkspaceSettingsPath(rootFolder);
 
-    try {
-        const containerAppName: string | undefined = settingUtils.getWorkspaceSetting(`${deployWorkspaceProjectPrefix}.containerAppName`, settingsPath);
-        const containerAppResourceGroupName: string | undefined = settingUtils.getWorkspaceSetting(`${deployWorkspaceProjectPrefix}.containerAppResourceGroupName`, settingsPath);
-        const containerRegistryName: string | undefined = settingUtils.getWorkspaceSetting(`${deployWorkspaceProjectPrefix}.containerRegistryName`, settingsPath);
+    const containerAppName: string | undefined = settingUtils.getWorkspaceSetting(`${deployWorkspaceProjectPrefix}.containerAppName`, settingsPath);
+    const containerAppResourceGroupName: string | undefined = settingUtils.getWorkspaceSetting(`${deployWorkspaceProjectPrefix}.containerAppResourceGroupName`, settingsPath);
+    const containerRegistryName: string | undefined = settingUtils.getWorkspaceSetting(`${deployWorkspaceProjectPrefix}.containerRegistryName`, settingsPath);
 
-        return {
-            containerAppName,
-            containerAppResourceGroupName,
-            containerRegistryName
-        };
-    } catch {
-        // Return no matching resources if we encounter any settings path read errors
-        return {};
-    }
+    return {
+        containerAppName,
+        containerAppResourceGroupName,
+        containerRegistryName
+    };
 }

src/utils/settingUtils.ts

@@ -66,7 +66,7 @@ export namespace settingUtils {
         const projectConfiguration: WorkspaceConfiguration = workspace.getConfiguration(prefix, fsPath ? Uri.file(fsPath) : undefined);
 
         const configurationLevel: ConfigurationTarget | undefined = getLowestConfigurationLevel(projectConfiguration, key);
-        if (targetLimit && configurationLevel && (configurationLevel < targetLimit)) {
+        if (!configurationLevel || (configurationLevel < targetLimit)) {
             return undefined;
         }