Prompt and update for save even when a configuration has an empty label field (#666)

Author: MicroFish91

src/commands/deployWorkspaceProject/deploymentConfiguration/workspace/DeploymentConfigurationListStep.ts

@@ -66,7 +66,7 @@ export class DeploymentConfigurationListStep extends AzureWizardPromptStep<Works
     private getPicks(deploymentConfigurations: DeploymentConfigurationSettings[]): IAzureQuickPickItem<(DeploymentConfigurationSettings & { configurationIdx?: number }) | undefined>[] {
         const picks: IAzureQuickPickItem<DeploymentConfigurationSettings | undefined>[] = deploymentConfigurations.map((deploymentConfiguration, i) => {
             return {
-                label: deploymentConfiguration.label ?? localize('unnamedApp', 'Unnamed app'),
+                label: deploymentConfiguration.label || localize('unnamedApp', 'Unnamed app'),
                 // Show the container app name as the description by default, unless the label has the same name
                 description: deploymentConfiguration.label === deploymentConfiguration.containerApp ? undefined : deploymentConfiguration.containerApp,
                 data: { ...deploymentConfiguration, configurationIdx: i }

src/commands/deployWorkspaceProject/internal/DeployWorkspaceProjectSaveSettingsStep.ts

@@ -27,8 +27,9 @@ export class DeployWorkspaceProjectSaveSettingsStep extends ExecuteActivityOutpu
         const rootFolder: WorkspaceFolder = nonNullProp(context, 'rootFolder');
         const deploymentConfigurations: DeploymentConfigurationSettings[] = await dwpSettingUtilsV2.getWorkspaceDeploymentConfigurations(rootFolder) ?? [];
 
+        const configurationLabel: string | undefined = context.configurationIdx !== undefined ? deploymentConfigurations?.[context.configurationIdx].label : undefined;
         const deploymentConfiguration: DeploymentConfigurationSettings = {
-            label: context.configurationIdx !== undefined && deploymentConfigurations?.[context.configurationIdx].label || removeCaSuffixIfExists(nonNullValueAndProp(context.containerApp, 'name')),
+            label: configurationLabel || removeCaSuffixIfExists(nonNullValueAndProp(context.containerApp, 'name')),
             type: 'AcrDockerBuildRequest',
             dockerfilePath: path.relative(rootFolder.uri.fsPath, nonNullProp(context, 'dockerfilePath')),
             srcPath: path.relative(rootFolder.uri.fsPath, context.srcPath || rootFolder.uri.fsPath) || ".",

src/commands/deployWorkspaceProject/internal/ShouldSaveDeploySettingsPromptStep.ts

@@ -21,6 +21,7 @@ export class ShouldSaveDeploySettingsPromptStep extends AzureWizardPromptStep<De
             const setting: DeploymentConfigurationSettings | undefined = settings?.[context.configurationIdx];
 
             const hasNewSettings: boolean =
+                !setting?.label ||
                 setting?.type !== 'AcrDockerBuildRequest' ||
                 (context.dockerfilePath && convertRelativeToAbsolutePath(rootPath, setting?.dockerfilePath) !== context.dockerfilePath) ||
                 (context.envPath && convertRelativeToAbsolutePath(rootPath, setting?.envPath) !== context.envPath) ||