Merge main into nat/esbuild-test-migration2 and resolve package-lock.json conflict

alexweininger · Copilot · alexweininger · commit 070139b004c9 · 2026-02-26T10:41:13.000-05:00
Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/commands/addBinding/settingSteps/StorageTypePromptStep.ts b/src/commands/addBinding/settingSteps/StorageTypePromptStep.ts
@@ -40,7 +40,7 @@ export class StorageTypePromptStep extends AzureWizardPromptStep<IFunctionWizard
 
         if (!context.useStorageEmulator) {
             promptSteps.push(new StorageAccountListStep(
-                { kind: StorageAccountKind.Storage, performance: StorageAccountPerformance.Standard, replication: StorageAccountReplication.LRS },
+                { kind: StorageAccountKind.StorageV2, performance: StorageAccountPerformance.Standard, replication: StorageAccountReplication.LRS },
                 { kind: [StorageAccountKind.BlobStorage], learnMoreLink: 'https://aka.ms/T5o0nf' }
             ));
         }
diff --git a/src/commands/addMIConnections/SettingsAddBaseStep.ts b/src/commands/addMIConnections/SettingsAddBaseStep.ts
@@ -84,8 +84,11 @@ async function addStorageConnectionsAndRoles(context: AddMIConnectionsContext, c
             addRole(context, scope, CommonRoleDefinitions.storageBlobDataOwner);
             addRole(context, scope, CommonRoleDefinitions.storageQueueDataContributor);
         }
-    } catch (_e) {
-        throw new Error(localize('invalidStorageConnectionString', 'Unexpected storage connection string format: {0}', connection.value));
+    } catch (e) {
+        throw new Error(
+            localize('invalidStorageConnectionString', 'Unexpected storage connection string format: {0}', connection.value),
+            { cause: e },
+        );
     }
 
 }
@@ -106,8 +109,11 @@ async function addDocumentConnectionsAndRoles(context: AddMIConnectionsContext,
             },
             ...getClientIdAndCredentialPropertiesForRemote(context, cosmosDbAccountName)
         );
-    } catch (_e) {
-        throw new Error(localize('invalidDocumentConnectionString', 'Unexpected DocumentDB connection string format: {0}', connection.value));
+    } catch (e) {
+        throw new Error(
+            localize('invalidDocumentConnectionString', 'Unexpected DocumentDB connection string format: {0}', connection.value),
+            { cause: e }
+        );
     }
 }
 
@@ -142,8 +148,11 @@ async function addEventHubServiceBusConnectionsAndRoles(context: AddMIConnection
                 addRole(context, scope, CommonRoleDefinitions.azureServiceBusDataReceiver);
             }
         }
-    } catch (_e) {
-        throw new Error(localize('invalidEventHubConnectionString', 'Unexpected EventHub connection string format: {0}', connection.value));
+    } catch (e) {
+        throw new Error(
+            localize('invalidEventHubConnectionString', 'Unexpected EventHub connection string format: {0}', connection.value),
+            { cause: e }
+        );
     }
 }
 
diff --git a/src/commands/appSettings/connectionSettings/azureWebJobsStorage/StorageConnectionListStep.ts b/src/commands/appSettings/connectionSettings/azureWebJobsStorage/StorageConnectionListStep.ts
@@ -74,7 +74,7 @@ export class StorageConnectionListStep<T extends IStorageConnectionWizardContext
                 if (!(context as IStorageAzureConnectionWizard).storageAccount) {
                     promptSteps.push(new StorageAccountListStep(
                         { // INewStorageAccountDefaults
-                            kind: StorageAccountKind.Storage,
+                            kind: StorageAccountKind.StorageV2,
                             performance: StorageAccountPerformance.Standard,
                             replication: StorageAccountReplication.LRS
                         },
diff --git a/src/commands/appSettings/connectionSettings/sqlDatabase/azure/SqlDatabaseCreateStep.ts b/src/commands/appSettings/connectionSettings/sqlDatabase/azure/SqlDatabaseCreateStep.ts
@@ -49,7 +49,7 @@ export class SqlDatabaseCreateStep<T extends ISqlDatabaseAzureConnectionWizardCo
             );
             ext.outputChannel.appendLog(customErrMessage);
             ext.outputChannel.appendLog(perr.message);
-            throw new Error(customErrMessage);
+            throw new Error(customErrMessage, { cause: e });
         }
     }
 
diff --git a/src/commands/createFunction/openAPISteps/OpenAPICreateStep.ts b/src/commands/createFunction/openAPISteps/OpenAPICreateStep.ts
@@ -94,7 +94,7 @@ export class OpenAPICreateStep extends AzureWizardExecuteStep<IFunctionWizardCon
 async function validateAutorestInstalled(context: IActionContext): Promise<void> {
     try {
         await cpUtils.executeCommand(undefined, undefined, 'autorest', composeArgs(withArg('--version'))());
-    } catch (_error) {
+    } catch (error) {
         const message: string = localize('autorestNotFound', 'Failed to find "autorest" | Extension needs AutoRest to generate a function app from an OpenAPI specification. Click "Learn more" for more details on installation steps.');
         if (!context.errorHandling.suppressDisplay) {
             void window.showErrorMessage(message, DialogResponses.learnMore).then(async result => {
@@ -105,7 +105,7 @@ async function validateAutorestInstalled(context: IActionContext): Promise<void>
             context.errorHandling.suppressDisplay = true;
         }
 
-        throw new Error(message);
+        throw new Error(message, { cause: error });
     }
 }
 
diff --git a/src/commands/createFunctionApp/createCreateFunctionAppComponents.ts b/src/commands/createFunctionApp/createCreateFunctionAppComponents.ts
@@ -48,7 +48,7 @@ export async function createCreateFunctionAppComponents(context: ICreateFunction
     const executeSteps: AzureWizardExecuteStep<IFunctionAppWizardContext>[] = [];
 
     const storageAccountCreateOptions: INewStorageAccountDefaults = {
-        kind: StorageAccountKind.Storage,
+        kind: StorageAccountKind.StorageV2,
         performance: StorageAccountPerformance.Standard,
         replication: StorageAccountReplication.LRS
     };
diff --git a/src/commands/createFunctionApp/stacks/getStackPicks.ts b/src/commands/createFunctionApp/stacks/getStackPicks.ts
@@ -293,8 +293,8 @@ export interface eolWarningOptions {
  * This function checks the end of life date for stack and returns a message if the stack is end of life or will be end of life in 6 months.
  */
 export async function getEolWarningMessages(context: ISubscriptionActionContext, options: eolWarningOptions): Promise<string> {
-    let isEOL = false;
-    let willBeEOL = false;
+    let isEOL: boolean;
+    let willBeEOL: boolean;
     let version: string | undefined;
     let displayInfo: {
         endOfLife: Date | undefined;
diff --git a/src/commands/createNewProject/mcpServerSteps/MCPDownloadSnippetsExecuteStep.ts b/src/commands/createNewProject/mcpServerSteps/MCPDownloadSnippetsExecuteStep.ts
@@ -39,7 +39,8 @@ export class MCPDownloadSnippetsExecuteStep extends AzureWizardExecuteStepWithAc
     }
 
     private async downloadFilesRecursively(context: MCPProjectWizardContext, items: GitHubFileMetadata[], basePath: string): Promise<void> {
-        for (const item of items) {
+        // Download all files and directories at this level in parallel
+        await Promise.all(items.map(async (item) => {
             if (item.type === 'file') {
                 await MCPDownloadSnippetsExecuteStep.downloadSingleFile({
                     context, item,
@@ -59,7 +60,7 @@ export class MCPDownloadSnippetsExecuteStep extends AzureWizardExecuteStepWithAc
                 // Recursively download directory contents
                 await this.downloadFilesRecursively(context, dirContents, dirPath);
             }
-        }
+        }));
     }
 
     public shouldExecute(context: MCPProjectWizardContext): boolean {
diff --git a/src/commands/deploy/deploy.ts b/src/commands/deploy/deploy.ts
@@ -3,7 +3,7 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-import { type Site, type SiteConfigResource, type StringDictionary } from '@azure/arm-appservice';
+import { type Site, type SiteConfigResource } from '@azure/arm-appservice';
 import { getDeployFsPath, getDeployNode, deploy as innerDeploy, showDeployConfirmation, type IDeployContext, type IDeployPaths, type InnerDeployContext, type ParsedSite } from '@microsoft/vscode-azext-azureappservice';
 import { ResourceGroupListStep } from '@microsoft/vscode-azext-azureutils';
 import { AzureWizard, DialogResponses, subscriptionExperience, type ExecuteActivityContext, type IActionContext, type ISubscriptionContext } from '@microsoft/vscode-azext-utils';
@@ -133,8 +133,11 @@ async function deploy(actionContext: IActionContext, arg1: vscode.Uri | string |
     void showCoreToolsWarning(context, version, site.fullName);
 
     const client = await site.createClient(actionContext);
-    const siteConfig: SiteConfigResource = await client.getSiteConfig();
-    const isConsumption: boolean = await client.getIsConsumption(actionContext);
+    // Parallelize independent read-only calls: site config and consumption check
+    const [siteConfig, isConsumption] = await Promise.all([
+        client.getSiteConfig(),
+        client.getIsConsumption(actionContext),
+    ]);
     let isZipDeploy: boolean = siteConfig.scmType !== ScmType.LocalGit && siteConfig.scmType !== ScmType.GitHub;
     if (!isZipDeploy && site.isLinux && isConsumption) {
         ext.outputChannel.appendLog(localize('linuxConsZipOnly', 'WARNING: Using zip deploy because scm type "{0}" is not supported on Linux consumption', siteConfig.scmType), { resourceName: site.fullName });
@@ -167,9 +170,11 @@ async function deploy(actionContext: IActionContext, arg1: vscode.Uri | string |
         context.deployMethod = 'flexconsumption';
     }
 
-    const appSettings: StringDictionary = await client.listApplicationSettings();
-
-    const durableStorageType: DurableBackend | undefined = await durableUtils.getStorageTypeFromWorkspace(language, context.projectPath);
+    // Parallelize remote app settings fetch and local workspace durable storage detection
+    const [appSettings, durableStorageType] = await Promise.all([
+        client.listApplicationSettings(),
+        durableUtils.getStorageTypeFromWorkspace(language, context.projectPath),
+    ]);
     context.telemetry.properties.durableStorageType = durableStorageType;
 
     if (durableStorageType === DurableBackend.SQL && isFlexConsumption) {
diff --git a/src/commands/executeFunction/executeFunction.ts b/src/commands/executeFunction/executeFunction.ts
@@ -121,7 +121,10 @@ export async function executeFunctionWithInput(context: IActionContext, function
             const errorType = parseError(error).errorType;
             if (!client && errorType === 'ECONNREFUSED') {
                 context.errorHandling.suppressReportIssue = true;
-                throw new Error(localize('failedToConnect', 'Failed to connect. Make sure your project is [running locally](https://aka.ms/AA76v2d).'));
+                throw new Error(
+                    localize('failedToConnect', 'Failed to connect. Make sure your project is [running locally](https://aka.ms/AA76v2d).'),
+                    { cause: error }
+                );
             } else if (errorType === '400') {
                 const response = await fetch(triggerRequest.url, {
                     method: 'POST',
diff --git a/src/downloadAzureProject/setupProjectFolder.ts b/src/downloadAzureProject/setupProjectFolder.ts
@@ -57,7 +57,7 @@ export async function setupProjectFolder(uri: vscode.Uri, vsCodeFilePathUri: vsc
             const projectFilePathUri: vscode.Uri = vscode.Uri.joinPath(vsCodeFilePathUri, `${functionAppName}`);
             const projectFilePath: string = projectFilePathUri.fsPath;
             const devContainerFolderPathUri: vscode.Uri = vscode.Uri.joinPath(projectFilePathUri, '.devcontainer');
-             
+
             await extract(downloadFilePath, { dir: projectFilePath });
             await requestUtils.downloadFile(
                 context,
@@ -74,7 +74,10 @@ export async function setupProjectFolder(uri: vscode.Uri, vsCodeFilePathUri: vsc
             await vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.file(projectFilePath), true);
         });
     } catch (err) {
-        throw new Error(localize('failedLocalProjSetupErrorMessage', 'Failed to set up your local project: "{0}".', parseError(err).message));
+        throw new Error(
+            localize('failedLocalProjSetupErrorMessage', 'Failed to set up your local project: "{0}".', parseError(err).message),
+            { cause: err }
+        );
     } finally {
         await AzExtFsExtra.deleteResource(
             toBeDeletedFolderPathUri.fsPath,
diff --git a/src/funcConfig/local.settings.ts b/src/funcConfig/local.settings.ts
@@ -117,7 +117,7 @@ export async function getLocalSettingsJson(context: IActionContext, localSetting
                     await context.ui.showWarningMessage(message, { modal: true, stepName: 'overwriteLocalSettings' }, overwriteButton);
                 } else {
                     const message: string = localize('failedToParse', 'Failed to parse "{0}": {1}.', localSettingsFileName, parseError(error).message);
-                    throw new Error(message);
+                    throw new Error(message, { cause: error });
                 }
             }
         }
diff --git a/src/templates/script/ScriptBundleTemplateProvider.ts b/src/templates/script/ScriptBundleTemplateProvider.ts
@@ -68,7 +68,10 @@ export class ScriptBundleTemplateProvider extends ScriptTemplateProvider {
                 try {
                     data = await AzExtFsExtra.readJSON(hostJsonPath);
                 } catch (error) {
-                    throw new Error(localize('failedToParseHostJson', 'Failed to parse host.json: "{0}"', parseError(error).message));
+                    throw new Error(
+                        localize('failedToParseHostJson', 'Failed to parse host.json: "{0}"', parseError(error).message),
+                        { cause: error }
+                    );
                 }
             }
         }
diff --git a/src/tree/containerizedFunctionApp/ResolvedContainerizedFunctionAppResource.ts b/src/tree/containerizedFunctionApp/ResolvedContainerizedFunctionAppResource.ts
@@ -95,7 +95,7 @@ export class ResolvedContainerizedFunctionAppResource extends ResolvedFunctionAp
     public async getHostJson(context: IActionContext): Promise<IParsedHostJson> {
         let result: IParsedHostJson | undefined = this._cachedHostJson;
         if (!result) {
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            // eslint-disable-next-line @typescript-eslint/no-explicit-any, no-unassigned-vars
             let data: any;
             const version: FuncVersion = await this.getVersion(context);
             result = parseHostJson(data, version);
diff --git a/src/tree/durableTaskScheduler/ContainerClient.ts b/src/tree/durableTaskScheduler/ContainerClient.ts
@@ -36,18 +36,18 @@ export class ShellContainerClient implements ContainerClient {
 
                 return containers.map(
                     container =>
-                        ({
-                            id: container.id,
-                            image: container.image.image as string,
-                            name: container.name,
-                            ports: container.ports.reduce(
-                                (previous, port) => {
-                                    previous[port.containerPort] = port.hostPort;
-
-                                    return previous;
-                                },
-                                {})
-                        }));
+                    ({
+                        id: container.id,
+                        image: container.image.image as string,
+                        name: container.name,
+                        ports: container.ports.reduce(
+                            (previous, port) => {
+                                previous[port.containerPort] = port.hostPort;
+
+                                return previous;
+                            },
+                            {})
+                    }));
             });
     }
 
@@ -96,8 +96,11 @@ export class ShellContainerClient implements ContainerClient {
         try {
             return await command();
         }
-        catch (_error) {
-            throw new Error(localize('containerRuntimeError', 'Unable to perform container command. Is a container runtime installed and running?'));
+        catch (error) {
+            throw new Error(
+                localize('containerRuntimeError', 'Unable to perform container command. Is a container runtime installed and running?'),
+                { cause: error }
+            );
         }
     }
 }
diff --git a/src/utils/gradleUtils.ts b/src/utils/gradleUtils.ts
@@ -15,7 +15,7 @@ export namespace gradleUtils {
     export async function validateGradleInstalled(context: IActionContext): Promise<void> {
         try {
             await cpUtils.executeCommand(undefined, undefined, gradleCommand, composeArgs(withArg('--version'))());
-        } catch (_error) {
+        } catch (error) {
             const message: string = localize('gradleNotFound', 'Failed to find "gradle", please ensure that the gradle bin directory is in your system path.');
 
             if (!context.errorHandling.suppressDisplay) {
@@ -24,7 +24,7 @@ export namespace gradleUtils {
                 context.errorHandling.suppressDisplay = true;
             }
 
-            throw new Error(message);
+            throw new Error(message, { cause: error });
         }
     }
 }
diff --git a/src/utils/mavenUtils.ts b/src/utils/mavenUtils.ts
@@ -16,7 +16,7 @@ export namespace mavenUtils {
     export async function validateMavenInstalled(context: IActionContext): Promise<void> {
         try {
             await cpUtils.executeCommand(undefined, undefined, mvnCommand, composeArgs(withArg('--version'))());
-        } catch (_error) {
+        } catch (error) {
             const message: string = localize('mvnNotFound', 'Failed to find "maven", please ensure that the maven bin directory is in your system path.');
 
             if (!context.errorHandling.suppressDisplay) {
@@ -29,7 +29,7 @@ export namespace mavenUtils {
                 context.errorHandling.suppressDisplay = true;
             }
 
-            throw new Error(message);
+            throw new Error(message, { cause: error });
         }
     }
 
diff --git a/src/utils/requestUtils.ts b/src/utils/requestUtils.ts
@@ -33,7 +33,10 @@ export namespace requestUtils {
             return await sendRequestWithTimeout(context, options, timeout, undefined);
         } catch (error) {
             if (isTimeoutError(error)) {
-                throw new Error(localize('timeoutFeed', 'Request timed out. Modify setting "{0}.{1}" if you want to extend the timeout.', ext.prefix, timeoutKey));
+                throw new Error(
+                    localize('timeoutFeed', 'Request timed out. Modify setting "{0}.{1}" if you want to extend the timeout.', ext.prefix, timeoutKey),
+                    { cause: error }
+                );
             } else {
                 throw error;
             }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ export class StorageTypePromptStep extends AzureWizardPromptStep<IFunctionWizard`
`40`	`40`
`41`	`41`	`if (!context.useStorageEmulator) {`
`42`	`42`	`promptSteps.push(new StorageAccountListStep(`
`43`		`- { kind: StorageAccountKind.Storage, performance: StorageAccountPerformance.Standard, replication: StorageAccountReplication.LRS },`
	`43`	`+ { kind: StorageAccountKind.StorageV2, performance: StorageAccountPerformance.Standard, replication: StorageAccountReplication.LRS },`
`44`	`44`	`{ kind: [StorageAccountKind.BlobStorage], learnMoreLink: 'https://aka.ms/T5o0nf' }`
`45`	`45`	`));`
`46`	`46`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,8 +84,11 @@ async function addStorageConnectionsAndRoles(context: AddMIConnectionsContext, c`
`84`	`84`	`addRole(context, scope, CommonRoleDefinitions.storageBlobDataOwner);`
`85`	`85`	`addRole(context, scope, CommonRoleDefinitions.storageQueueDataContributor);`
`86`	`86`	`}`
`87`		`- } catch (_e) {`
`88`		`- throw new Error(localize('invalidStorageConnectionString', 'Unexpected storage connection string format: {0}', connection.value));`
	`87`	`+ } catch (e) {`
	`88`	`+ throw new Error(`
	`89`	`+ localize('invalidStorageConnectionString', 'Unexpected storage connection string format: {0}', connection.value),`
	`90`	`+ { cause: e },`
	`91`	`+ );`
`89`	`92`	`}`
`90`	`93`
`91`	`94`	`}`
`@@ -106,8 +109,11 @@ async function addDocumentConnectionsAndRoles(context: AddMIConnectionsContext,`
`106`	`109`	`},`
`107`	`110`	`...getClientIdAndCredentialPropertiesForRemote(context, cosmosDbAccountName)`
`108`	`111`	`);`
`109`		`- } catch (_e) {`
`110`		`- throw new Error(localize('invalidDocumentConnectionString', 'Unexpected DocumentDB connection string format: {0}', connection.value));`
	`112`	`+ } catch (e) {`
	`113`	`+ throw new Error(`
	`114`	`+ localize('invalidDocumentConnectionString', 'Unexpected DocumentDB connection string format: {0}', connection.value),`
	`115`	`+ { cause: e }`
	`116`	`+ );`
`111`	`117`	`}`
`112`	`118`	`}`
`113`	`119`
`@@ -142,8 +148,11 @@ async function addEventHubServiceBusConnectionsAndRoles(context: AddMIConnection`
`142`	`148`	`addRole(context, scope, CommonRoleDefinitions.azureServiceBusDataReceiver);`
`143`	`149`	`}`
`144`	`150`	`}`
`145`		`- } catch (_e) {`
`146`		`- throw new Error(localize('invalidEventHubConnectionString', 'Unexpected EventHub connection string format: {0}', connection.value));`
	`151`	`+ } catch (e) {`
	`152`	`+ throw new Error(`
	`153`	`+ localize('invalidEventHubConnectionString', 'Unexpected EventHub connection string format: {0}', connection.value),`
	`154`	`+ { cause: e }`
	`155`	`+ );`
`147`	`156`	`}`
`148`	`157`	`}`
`149`	`158`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ export class SqlDatabaseCreateStep<T extends ISqlDatabaseAzureConnectionWizardCo`
`49`	`49`	`);`
`50`	`50`	`ext.outputChannel.appendLog(customErrMessage);`
`51`	`51`	`ext.outputChannel.appendLog(perr.message);`
`52`		`- throw new Error(customErrMessage);`
	`52`	`+ throw new Error(customErrMessage, { cause: e });`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ export class OpenAPICreateStep extends AzureWizardExecuteStep<IFunctionWizardCon`
`94`	`94`	`async function validateAutorestInstalled(context: IActionContext): Promise<void> {`
`95`	`95`	`try {`
`96`	`96`	`await cpUtils.executeCommand(undefined, undefined, 'autorest', composeArgs(withArg('--version'))());`
`97`		`- } catch (_error) {`
	`97`	`+ } catch (error) {`
`98`	`98`	`const message: string = localize('autorestNotFound', 'Failed to find "autorest" \| Extension needs AutoRest to generate a function app from an OpenAPI specification. Click "Learn more" for more details on installation steps.');`
`99`	`99`	`if (!context.errorHandling.suppressDisplay) {`
`100`	`100`	`void window.showErrorMessage(message, DialogResponses.learnMore).then(async result => {`
`@@ -105,7 +105,7 @@ async function validateAutorestInstalled(context: IActionContext): Promise<void>`
`105`	`105`	`context.errorHandling.suppressDisplay = true;`
`106`	`106`	`}`
`107`	`107`
`108`		`- throw new Error(message);`
	`108`	`+ throw new Error(message, { cause: error });`
`109`	`109`	`}`
`110`	`110`	`}`
`111`	`111`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,8 @@ export class MCPDownloadSnippetsExecuteStep extends AzureWizardExecuteStepWithAc`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`private async downloadFilesRecursively(context: MCPProjectWizardContext, items: GitHubFileMetadata[], basePath: string): Promise<void> {`
`42`		`- for (const item of items) {`
	`42`	`+ // Download all files and directories at this level in parallel`
	`43`	`+ await Promise.all(items.map(async (item) => {`
`43`	`44`	`if (item.type === 'file') {`
`44`	`45`	`await MCPDownloadSnippetsExecuteStep.downloadSingleFile({`
`45`	`46`	`context, item,`
`@@ -59,7 +60,7 @@ export class MCPDownloadSnippetsExecuteStep extends AzureWizardExecuteStepWithAc`
`59`	`60`	`// Recursively download directory contents`
`60`	`61`	`await this.downloadFilesRecursively(context, dirContents, dirPath);`
`61`	`62`	`}`
`62`		`- }`
	`63`	`+ }));`
`63`	`64`	`}`
`64`	`65`
`65`	`66`	`public shouldExecute(context: MCPProjectWizardContext): boolean {`