Overwrite the site object as to not accidentally reset it (#4144)

Author: nturinski

src/FunctionAppResolver.ts

@@ -24,14 +24,16 @@ export class FunctionAppResolver implements AppResourceResolver {
                 const sites20231201 = await getSites20231201(context, subContext);
                 await Promise.all(sites.map(async (site): Promise<void> => {
                     const id = nonNullProp(site, 'id').toLowerCase();
-                    const s = sites20231201.find(s => s.id?.toLowerCase() === site.id?.toLowerCase());
-                    this.siteCache.set(id, Object.assign(site, { isFlex: !!s?.properties?.functionAppConfig }));
-
+                    // check for required properties that sometime don't exist in the LIST operation
                     if (!site.defaultHostName) {
                         // if this required property doesn't exist, try getting the full site payload
-                        const fullSite = await client.webApps.get(nonNullProp(site, 'resourceGroup'), nonNullProp(site, 'name'))
-                        this.siteCache.set(id, fullSite);
+                        site = await client.webApps.get(nonNullProp(site, 'resourceGroup'), nonNullProp(site, 'name'))
+                        this.siteCache.set(id, site);
                     }
+
+                    const s = sites20231201.find(s => s.id?.toLowerCase() === site.id?.toLowerCase());
+                    this.siteCache.set(id, Object.assign(site, { isFlex: !!s?.properties?.functionAppConfig }));
+
                 }));
                 this.siteCacheLastUpdated = Date.now();
             }