Improve container command error handling.

Signed-off-by: Phillip Hoff <phillip@orst.edu>

Author: philliphoff

src/tree/durableTaskScheduler/ContainerClient.ts

@@ -28,42 +28,51 @@ export class ShellContainerClient implements ContainerClient {
     private readonly factory = new CodeContainerClient.ShellStreamCommandRunnerFactory({});
 
     async getContainers(): Promise<DockerContainer[]> {
-        const commandRunner = this.factory.getCommandRunner();
-
-        const containers = await commandRunner(this.dockerClient.listContainers({ running: true }));
-
-        return containers.map(
-            container =>
-            ({
-                id: container.id,
-                image: container.image.image as string,
-                name: container.name,
-                ports: container.ports.reduce(
-                    (previous, port) => {
-                        previous[port.containerPort] = port.hostPort;
-
-                        return previous;
-                    },
-                    {})
-            }));
+        return await this.withErrorHandling(
+            async () => {
+                const commandRunner = this.factory.getCommandRunner();
+
+                const containers = await commandRunner(this.dockerClient.listContainers({ running: true }));
+
+                return containers.map(
+                    container =>
+                        ({
+                            id: container.id,
+                            image: container.image.image as string,
+                            name: container.name,
+                            ports: container.ports.reduce(
+                                (previous, port) => {
+                                    previous[port.containerPort] = port.hostPort;
+
+                                    return previous;
+                                },
+                                {})
+                        }));
+            });
     }
 
     async removeContainer(id: string): Promise<void> {
-        const commandRunner = this.factory.getCommandRunner();
-
-        await commandRunner(this.dockerClient.removeContainers({
-            containers: [id]
-        }));
+        await this.withErrorHandling(
+            async () => {
+                const commandRunner = this.factory.getCommandRunner();
+
+                return await commandRunner(this.dockerClient.removeContainers({
+                    containers: [id]
+                }));
+            });
     }
 
     async runContainer(image: string): Promise<string> {
-        const commandRunner = this.factory.getCommandRunner();
+        const id = await this.withErrorHandling(
+            async () => {
+                const commandRunner = this.factory.getCommandRunner();
 
-        const id = await commandRunner(this.dockerClient.runContainer({
-            detached: true,
-            imageRef: image,
-            publishAllPorts: true
-        }));
+                return await commandRunner(this.dockerClient.runContainer({
+                    detached: true,
+                    imageRef: image,
+                    publishAllPorts: true
+                }));
+            });
 
         if (!id) {
             throw new Error(localize('startContainerFailed', 'Unable to start the container.'));
@@ -73,10 +82,22 @@ export class ShellContainerClient implements ContainerClient {
     }
 
     async stopContainer(id: string): Promise<void> {
-        const commandRunner = this.factory.getCommandRunner();
+        await this.withErrorHandling(
+            async () => {
+                const commandRunner = this.factory.getCommandRunner();
+
+                await commandRunner(this.dockerClient.stopContainers({
+                    container: [id]
+                }));
+            });
+    }
 
-        await commandRunner(this.dockerClient.stopContainers({
-            container: [id]
-        }));
+    private async withErrorHandling<T = void>(command: () => Promise<T>): Promise<T> {
+        try {
+            return await command();
+        }
+        catch (error) {
+            throw new Error(localize('containerRuntimeError', 'Unable to perform container command. Is a container runtime installed and running?'));
+        }
     }
 }

src/tree/durableTaskScheduler/DurableTaskSchedulerEmulatorsWorkspaceResourceModel.ts

@@ -9,19 +9,26 @@ import { localize } from "../../localize";
 import { treeUtils } from "../../utils/treeUtils";
 import {type DurableTaskSchedulerEmulatorClient } from "./DurableTaskSchedulerEmulatorClient";
 import { DurableTaskSchedulerEmulatorWorkspaceResourceModel } from "./DurableTaskSchedulerEmulatorWorkspaceResourceModel";
+import { DurableTaskSchedulerErrorWorkspaceResourceModel } from "./DurableTaskSchedulerErrorWorkspaceResourceModel";
+import { parseError } from "@microsoft/vscode-azext-utils";
 
 export class DurableTaskSchedulerEmulatorsWorkspaceResourceModel implements DurableTaskSchedulerWorkspaceResourceModel {
     constructor(private readonly emulatorClient: DurableTaskSchedulerEmulatorClient) {
     }
 
     async getChildren(): Promise<DurableTaskSchedulerWorkspaceResourceModel[]> {
-        const emulators = await this.emulatorClient.getEmulators();
-
-        return emulators.map(emulator => new DurableTaskSchedulerEmulatorWorkspaceResourceModel(emulator));
+        try {
+            const emulators = await this.emulatorClient.getEmulators();
+
+            return emulators.map(emulator => new DurableTaskSchedulerEmulatorWorkspaceResourceModel(emulator));
+        }
+        catch (error) {
+            return [new DurableTaskSchedulerErrorWorkspaceResourceModel(parseError(error).message)];
+        }
     }
 
     getTreeItem(): TreeItem | Thenable<TreeItem> {
-        const treeItem = new TreeItem(localize('dtsEmulatorsLabel', 'Durable Task Scheduler Emulators'), TreeItemCollapsibleState.Expanded);
+        const treeItem = new TreeItem(localize('dtsEmulatorsLabel', 'Durable Task Scheduler Emulators'), TreeItemCollapsibleState.Collapsed);
 
         treeItem.contextValue = 'azFunc.dts.emulators';
         treeItem.iconPath = treeUtils.getIconPath('durableTaskScheduler/DurableTaskScheduler');

src/tree/durableTaskScheduler/DurableTaskSchedulerErrorWorkspaceResourceModel.ts

@@ -0,0 +1,26 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import { type ProviderResult, ThemeIcon, TreeItem } from "vscode";
+import { type DurableTaskSchedulerWorkspaceResourceModel } from "./DurableTaskSchedulerWorkspaceResourceModel";
+
+export class DurableTaskSchedulerErrorWorkspaceResourceModel implements DurableTaskSchedulerWorkspaceResourceModel {
+    constructor(
+        private readonly error: string) {
+    }
+
+    getChildren(): ProviderResult<DurableTaskSchedulerWorkspaceResourceModel[]> {
+        return [];
+    }
+
+    getTreeItem(): TreeItem | Thenable<TreeItem> {
+        const treeItem = new TreeItem(this.error);
+
+        treeItem.contextValue = 'azFunc.dts.emulatorError';
+        treeItem.iconPath = new ThemeIcon('warning')
+
+        return treeItem;
+    }
+}