Allow flex consumption deployments for DTS but keep a warning for SQL (#4862)

Author: MicroFish91

src/commands/appSettings/connectionSettings/durableTaskScheduler/azure/DurableTaskSchedulerGetConnectionStep.ts

@@ -11,7 +11,7 @@ export class DurableTaskSchedulerGetConnectionStep<T extends IDTSAzureConnection
     public priority: number = 200;
 
     public async execute(context: T): Promise<void> {
-        context.newDTSConnectionSettingValue = getSchedulerConnectionString(context.dts?.properties.endpoint ?? '', SchedulerAuthenticationType.UserAssignedIdentity);
+        context.newDTSConnectionSettingValue ??= getSchedulerConnectionString(context.dts?.properties.endpoint ?? '', SchedulerAuthenticationType.UserAssignedIdentity);
 
         if (context.managedIdentity) {
             context.newDTSConnectionSettingValue = context.newDTSConnectionSettingValue.replace(clientIdKey, context.managedIdentity?.clientId ?? clientIdKey);
@@ -20,7 +20,7 @@ export class DurableTaskSchedulerGetConnectionStep<T extends IDTSAzureConnection
         context.valuesToMask.push(context.newDTSConnectionSettingValue);
     }
 
-    public shouldExecute(context: T): boolean {
-        return !context.newDTSConnectionSettingValue;
+    public shouldExecute(): boolean {
+        return true;
     }
 }

src/commands/deploy/deploy.ts

@@ -172,6 +172,12 @@ async function deploy(actionContext: IActionContext, arg1: vscode.Uri | string |
     const durableStorageType: DurableBackend | undefined = await durableUtils.getStorageTypeFromWorkspace(language, context.projectPath);
     context.telemetry.properties.durableStorageType = durableStorageType;
 
+    if (durableStorageType === DurableBackend.SQL && isFlexConsumption) {
+        const warning: string = localize('durableStorageTypeWarning', 'SQL storage provider support has not yet been verified for apps on a flex consumption plan.');
+        ext.outputChannel.appendLog(warning);
+        await context.ui.showWarningMessage(warning, { modal: true }, { title: localize('continue', 'Continue') });
+    }
+
     if (durableStorageType) {
         switch (durableStorageType) {
             case DurableBackend.DTS:
@@ -187,12 +193,6 @@ async function deploy(actionContext: IActionContext, arg1: vscode.Uri | string |
         }
     }
 
-    if (durableStorageType === DurableBackend.DTS && isFlexConsumption) {
-        const warning: string = localize('durableStorageTypeWarning', 'The Durable Task Scheduler (DTS) storage provider is not yet supported for apps on a flex consumption plan.');
-        ext.outputChannel.appendLog(warning);
-        await context.ui.showWarningMessage(warning, { modal: true }, { title: localize('continue', 'Continue') });
-    }
-
     Object.assign(context, await getStorageConnectionIfNeeded(Object.assign(context, subscriptionContext), appSettings, site, context.projectPath));
 
     const deploymentWarningMessages: string[] = [];