Remove uneeded shims

Author: Nathan Turinski

src/templates/dotnet/DotnetTemplateProvider.ts

@@ -19,7 +19,7 @@ import { type IBindingTemplate } from '../IBindingTemplate';
 import { type IFunctionTemplate } from '../IFunctionTemplate';
 import { type ITemplates } from '../ITemplates';
 import { TemplateProviderBase, TemplateSchemaVersion, TemplateType } from '../TemplateProviderBase';
-import { DotnetTemplateOperation, executeDotnetTemplateCommand, getDotnetItemTemplatePath, getDotnetProjectTemplatePath, getDotnetTemplateDir, validateDotnetInstalled } from './executeDotnetTemplateCommand';
+import { executeDotnetTemplateCommand, getDotnetItemTemplatePath, getDotnetProjectTemplatePath, getDotnetTemplateDir, validateDotnetInstalled } from './executeDotnetTemplateCommand';
 import { parseDotnetTemplates } from './parseDotnetTemplates';
 
 export class DotnetTemplateProvider extends TemplateProviderBase {
@@ -165,7 +165,7 @@ export class DotnetTemplateProvider extends TemplateProviderBase {
     }
 
     private async parseTemplates(context: IActionContext, projKey: string): Promise<ITemplates> {
-        this._rawTemplates = parseJson(await executeDotnetTemplateCommand(context, this.version, projKey, undefined, DotnetTemplateOperation.List));
+        this._rawTemplates = parseJson(await executeDotnetTemplateCommand(context, this.version, projKey));
         return parseDotnetTemplates(this._rawTemplates, this.version);
     }
 

src/templates/dotnet/executeDotnetTemplateCommand.ts

@@ -4,7 +4,7 @@
  *--------------------------------------------------------------------------------------------*/
 
 import { type IActionContext } from '@microsoft/vscode-azext-utils';
-import { composeArgs, withArg, withNamedArg, withQuotedArg, type CommandLineArgs } from '@microsoft/vscode-processutils';
+import { composeArgs, withArg, withNamedArg, withQuotedArg } from '@microsoft/vscode-processutils';
 import * as fs from 'fs';
 import * as os from 'os';
 import * as path from 'path';
@@ -18,30 +18,12 @@ import { findShortNameByIdentity, parseTemplatesFromNupkg } from './parseNupkgTe
 const itemNupkgFileName = 'item.nupkg';
 const projectNupkgFileName = 'project.nupkg';
 
-export enum DotnetTemplateOperation {
-    List = 'list',
-    Create = 'create',
-}
-
 /**
  * Lists templates by parsing nupkg files directly (no longer uses the JsonCli DLL).
  */
-export async function executeDotnetTemplateCommand(context: IActionContext, version: FuncVersion, projTemplateKey: string, workingDirectory: string | undefined, operation: DotnetTemplateOperation.List, additionalArgs?: CommandLineArgs): Promise<string>;
-/**
- * @deprecated For 'create' operations, use {@link executeDotnetTemplateCreate} instead.
- */
-export async function executeDotnetTemplateCommand(context: IActionContext, version: FuncVersion, projTemplateKey: string, workingDirectory: string | undefined, operation: DotnetTemplateOperation, additionalArgs?: CommandLineArgs): Promise<string>;
-export async function executeDotnetTemplateCommand(context: IActionContext, version: FuncVersion, projTemplateKey: string, workingDirectory: string | undefined, operation: DotnetTemplateOperation, additionalArgs?: CommandLineArgs): Promise<string> {
+export async function executeDotnetTemplateCommand(context: IActionContext, version: FuncVersion, projTemplateKey: string): Promise<string> {
     const templateDir = getDotnetTemplateDir(context, version, projTemplateKey);
-
-    if (operation === DotnetTemplateOperation.List) {
-        return await listDotnetTemplates(templateDir);
-    } else {
-        // Fallback for any remaining callers that haven't migrated to executeDotnetTemplateCreate
-        const { identity, templateArgs } = parseJsonCliStyleArgs(additionalArgs ?? []);
-        await executeDotnetTemplateCreate(context, version, projTemplateKey, workingDirectory, identity, templateArgs);
-        return '';
-    }
+    return await listDotnetTemplates(templateDir);
 }
 
 /**
@@ -141,30 +123,6 @@ export async function executeDotnetTemplateCreate(
     }
 }
 
-/**
- * Parses JSON Cli-style arguments (--identity, --arg:name, etc.) into structured data.
- * Used only as a compatibility shim for callers that have not yet migrated to executeDotnetTemplateCreate.
- */
-function parseJsonCliStyleArgs(args: CommandLineArgs): { identity: string; templateArgs: Record<string, string> } {
-    const flatArgs: string[] = (Array.isArray(args) ? args : [args]).map(String);
-    let identity = '';
-    const templateArgs: Record<string, string> = {};
-
-    for (let i = 0; i < flatArgs.length; i++) {
-        const arg = flatArgs[i];
-        if (arg === '--identity' && i + 1 < flatArgs.length) {
-            identity = flatArgs[i + 1].replace(/^"|"$/g, '');
-            i++;
-        } else if (arg.startsWith('--arg:') && i + 1 < flatArgs.length) {
-            const paramName = arg.replace('--arg:', '');
-            templateArgs[paramName] = flatArgs[i + 1].replace(/^"|"$/g, '');
-            i++;
-        }
-    }
-
-    return { identity, templateArgs };
-}
-
 export function getDotnetItemTemplatePath(context: IActionContext, version: FuncVersion, projTemplateKey: string): string {
     return path.join(getDotnetTemplateDir(context, version, projTemplateKey), itemNupkgFileName);
 }