Skip to content

Commit 6729c9a

Browse files
committed
fix(tree): init display settings before filtering
1 parent c703eb6 commit 6729c9a

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/tree/LocalRootTreeItemBase.ts

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,14 @@ export abstract class LocalRootTreeItemBase<TItem extends AnyContainerObject, TP
9797
ext.activityMeasurementService.recordActivity('overallnoedit');
9898

9999
this._currentItems = await this.getCachedItems(context, clearCache);
100+
this.groupBySetting = this.getTreeSetting(groupByKey, this.groupBySettingInfo);
101+
context.telemetry.properties.groupBySetting = this.groupBySetting;
102+
this.sortBySetting = this.getTreeSetting(sortByKey, this.sortBySettingInfo);
103+
context.telemetry.properties.sortBySetting = this.sortBySetting;
104+
this.labelSetting = this.getTreeSetting(labelKey, this.labelSettingInfo);
105+
context.telemetry.properties.labelSetting = this.labelSetting;
106+
this.descriptionSetting = this.getTreeArraySetting(descriptionKey, this.descriptionSettingInfo);
107+
context.telemetry.properties.descriptionSetting = this.descriptionSetting.toString();
100108

101109
const filter = getTreeFilter(this.treePrefix);
102110
if (filter.isActive && this._currentItems) {
@@ -123,15 +131,6 @@ export abstract class LocalRootTreeItemBase<TItem extends AnyContainerObject, TP
123131
context.telemetry.properties.noItems = 'true';
124132
return this.getTreeItemForEmptyList();
125133
} else {
126-
this.groupBySetting = this.getTreeSetting(groupByKey, this.groupBySettingInfo);
127-
context.telemetry.properties.groupBySetting = this.groupBySetting;
128-
this.sortBySetting = this.getTreeSetting(sortByKey, this.sortBySettingInfo);
129-
context.telemetry.properties.sortBySetting = this.sortBySetting;
130-
this.labelSetting = this.getTreeSetting(labelKey, this.labelSettingInfo);
131-
context.telemetry.properties.labelSetting = this.labelSetting;
132-
this.descriptionSetting = this.getTreeArraySetting(descriptionKey, this.descriptionSettingInfo);
133-
context.telemetry.properties.descriptionSetting = this.descriptionSetting.toString();
134-
135134
return this.groupItems(this._currentItems);
136135
}
137136
}

0 commit comments

Comments
 (0)