Skip to content

Commit a360490

Browse files
committed
Catch filter QuickPick accept errors
1 parent 5990ec1 commit a360490

File tree

1 file changed

+26
-19
lines changed

1 file changed

+26
-19
lines changed

src/commands/filterTree.ts

Lines changed: 26 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -157,25 +157,32 @@ async function filterTreeView(
157157
];
158158
}
159159

160-
quickPick.onDidAccept(async () => {
161-
const value = quickPick.value.trim();
162-
const selectedItem = quickPick.selectedItems[0];
163-
164-
// Check if "Clear Filter" was selected
165-
if (selectedItem?.label === clearFilterLabel) {
166-
await clearTreeFilter(treePrefix);
167-
context.telemetry.properties.action = "clearFilter";
168-
} else if (value) {
169-
await setTreeFilter(treePrefix, value);
170-
context.telemetry.properties.action = "applyFilter";
171-
context.telemetry.properties.filterLength = value.length.toString();
172-
} else {
173-
await clearTreeFilter(treePrefix);
174-
context.telemetry.properties.action = "clearFilter";
175-
}
176-
177-
quickPick.hide();
178-
await refreshTreeView(treePrefix);
160+
quickPick.onDidAccept(() => {
161+
void (async () => {
162+
const value = quickPick.value.trim();
163+
const selectedItem = quickPick.selectedItems[0];
164+
165+
// Check if "Clear Filter" was selected
166+
if (selectedItem?.label === clearFilterLabel) {
167+
await clearTreeFilter(treePrefix);
168+
context.telemetry.properties.action = "clearFilter";
169+
} else if (value) {
170+
await setTreeFilter(treePrefix, value);
171+
context.telemetry.properties.action = "applyFilter";
172+
context.telemetry.properties.filterLength =
173+
value.length.toString();
174+
} else {
175+
await clearTreeFilter(treePrefix);
176+
context.telemetry.properties.action = "clearFilter";
177+
}
178+
179+
quickPick.hide();
180+
await refreshTreeView(treePrefix);
181+
})().catch((error) => {
182+
void vscode.window.showErrorMessage(
183+
vscode.l10n.t("Failed to apply filter: {0}", String(error))
184+
);
185+
});
179186
});
180187

181188
quickPick.onDidHide(() => {

0 commit comments

Comments
 (0)