Burn the toast (#73)

Author: bwateratmsft

…mands/showDockerLearnMoreNotification.ts src/commands/openDockerDownloadPage.tssrc/commands/showDockerLearnMoreNotification.ts renamed to src/commands/openDockerDownloadPage.ts src/commands/showDockerLearnMoreNotification.ts renamed to src/commands/openDockerDownloadPage.ts

@@ -6,16 +6,6 @@
 import * as vscode from 'vscode';
 import { isMac, isWindows } from '../utils/osUtils';
 
-export async function showDockerLearnMoreNotification(): Promise<void> {
-    const learnMoreMessage = vscode.l10n.t('Docker is not installed. Would you like to learn more about installing Docker?');
-    const confirmationPrompt = vscode.l10n.t('Learn more');
-
-    const response = await vscode.window.showInformationMessage(learnMoreMessage, ...[confirmationPrompt]);
-    if (response) {
-        await openDockerDownloadPage();
-    }
-}
-
 export async function openDockerDownloadPage(): Promise<void> {
     if (isWindows()) {
         await vscode.env.openExternal(vscode.Uri.parse('https://aka.ms/vscode/docker-windows-download'));

src/commands/registerCommands.ts

@@ -50,6 +50,7 @@ import { createNetwork } from "./networks/createNetwork";
 import { inspectNetwork } from "./networks/inspectNetwork";
 import { pruneNetworks } from "./networks/pruneNetworks";
 import { removeNetwork } from "./networks/removeNetwork";
+import { openDockerDownloadPage } from "./openDockerDownloadPage";
 import { pruneSystem } from "./pruneSystem";
 import { registerWorkspaceCommand } from "./registerWorkspaceCommand";
 import { createAzureRegistry } from "./registries/azure/createAzureRegistry";
@@ -75,7 +76,6 @@ import { logOutOfDockerCli } from "./registries/logOutOfDockerCli";
 import { pullImageFromRepository, pullRepository } from "./registries/pullImages";
 import { reconnectRegistry } from "./registries/reconnectRegistry";
 import { registryHelp } from "./registries/registryHelp";
-import { openDockerDownloadPage } from "./showDockerLearnMoreNotification";
 import { configureVolumesExplorer } from "./volumes/configureVolumesExplorer";
 import { inspectVolume } from "./volumes/inspectVolume";
 import { pruneVolumes } from "./volumes/pruneVolumes";

src/tree/LocalRootTreeItemBase.ts

@@ -6,7 +6,6 @@
 import { AzExtParentTreeItem, AzExtTreeItem, AzureWizard, GenericTreeItem, IActionContext, parseError } from "@microsoft/vscode-azext-utils";
 import { ListContainersItem, ListContextItem, ListImagesItem, ListNetworkItem, ListVolumeItem, isCommandNotSupportedError } from "@microsoft/vscode-container-client";
 import { ConfigurationTarget, ThemeColor, ThemeIcon, WorkspaceConfiguration, l10n, workspace } from "vscode";
-import { showDockerLearnMoreNotification } from "../commands/showDockerLearnMoreNotification";
 import { configPrefix } from "../constants";
 import { ext } from "../extensionVariables";
 import { runtimeInstallStatusProvider } from "../utils/RuntimeInstallStatusProvider";
@@ -37,7 +36,6 @@ const groupByKey: string = 'groupBy';
 const sortByKey: string = 'sortBy';
 export const labelKey: string = 'label';
 export const descriptionKey: string = 'description';
-let dockerInstallNotificationShownToUser: boolean = false;
 
 export abstract class LocalRootTreeItemBase<TItem extends AnyContainerObject, TProperty extends string | CommonProperty> extends AzExtParentTreeItem {
     public abstract labelSettingInfo: ITreeSettingInfo<TProperty>;
@@ -104,7 +102,6 @@ export abstract class LocalRootTreeItemBase<TItem extends AnyContainerObject, TP
                 this._currentDockerStatus = await runtimeInstallStatusProvider.isRuntimeInstalled() ? 'Installed' : 'NotInstalled';
             }
 
-            this.showDockerInstallNotificationIfNeeded();
             return await this.getDockerErrorTreeItems(context, error, this._currentDockerStatus === 'Installed');
         }
 
@@ -320,14 +317,6 @@ export abstract class LocalRootTreeItemBase<TItem extends AnyContainerObject, TP
 
         return this._cachedItems;
     }
-
-    private showDockerInstallNotificationIfNeeded(): void {
-        if (!dockerInstallNotificationShownToUser && this._currentDockerStatus === 'NotInstalled') {
-            dockerInstallNotificationShownToUser = true;
-            // eslint-disable-next-line @typescript-eslint/no-floating-promises
-            showDockerLearnMoreNotification();
-        }
-    }
 }
 
 export function getTreeId(object: AnyContainerObject): string {