Intellisense recommends invalid schema uris for JSON Schema drafts (#201)

Author: aeschli

src/services/configuration.ts

@@ -10,10 +10,6 @@ import * as l10n from '@vscode/l10n';
 export const schemaContributions: ISchemaContributions = {
 	schemaAssociations: [],
 	schemas: {
-		// refer to the latest schema
-		'http://json-schema.org/schema#': {
-			$ref: 'http://json-schema.org/draft-07/schema#'
-		},
 		// bundle the schema-schema to include (localized) descriptions
 		'http://json-schema.org/draft-04/schema#': {
 			'$schema': 'http://json-schema.org/draft-04/schema#',

src/services/jsonCompletion.ts

@@ -733,13 +733,18 @@ export class JSONCompletion {
 
 	private addDollarSchemaCompletions(separatorAfter: string, collector: CompletionsCollector): void {
 		const schemaIds = this.schemaService.getRegisteredSchemaIds(schema => schema === 'http' || schema === 'https');
-		schemaIds.forEach(schemaId => collector.add({
-			kind: CompletionItemKind.Module,
-			label: this.getLabelForValue(schemaId),
-			filterText: this.getFilterTextForValue(schemaId),
-			insertText: this.getInsertTextForValue(schemaId, separatorAfter),
-			insertTextFormat: InsertTextFormat.Snippet, documentation: ''
-		}));
+		schemaIds.forEach(schemaId => {
+			if (schemaId.startsWith('http://json-schema.org/draft-')) {
+				schemaId = schemaId + '#';
+			}
+			collector.add({
+				kind: CompletionItemKind.Module,
+				label: this.getLabelForValue(schemaId),
+				filterText: this.getFilterTextForValue(schemaId),
+				insertText: this.getInsertTextForValue(schemaId, separatorAfter),
+				insertTextFormat: InsertTextFormat.Snippet, documentation: ''
+			});
+		});
 	}
 
 	private getLabelForValue(value: any): string {

src/test/completion.test.ts

@@ -1078,7 +1078,9 @@ suite('JSON Completion', () => {
 		});
 		await testCompletionsFor('{ "$schema": | }', schema, {
 			items: [
-				{ label: '"http://myschemastore/test1"', resultText: '{ "$schema": "http://myschemastore/test1" }' }
+				{ label: '"http://myschemastore/test1"', resultText: '{ "$schema": "http://myschemastore/test1" }' },
+				{ label: '"http://json-schema.org/draft-04/schema#"', resultText: '{ "$schema": "http://json-schema.org/draft-04/schema#" }' },
+				{ label: '"http://json-schema.org/draft-07/schema#"', resultText: '{ "$schema": "http://json-schema.org/draft-07/schema#" }' }
 			]
 		});
 		await testCompletionsFor('{ "$schema": "|', schema, {