feat: Notify Invalid RegExp Patterns (#261)

* report problem if extendedRegExp catches an error

* only report invalid regex if needed

* add test for invalid patterns

* no optional chaining

* ignore invalid regex

Author: aedenmurray

src/parser/jsonParser.ts

@@ -718,7 +718,7 @@ function validate(n: ASTNode | undefined, schema: JSONSchema, validationResult:
 
 		if (isString(schema.pattern)) {
 			const regex = extendedRegExp(schema.pattern);
-			if (!(regex?.test(node.value))) {
+			if (regex && !(regex.test(node.value))) {
 				validationResult.problems.push({
 					location: { offset: node.offset, length: node.length },
 					message: schema.patternErrorMessage || schema.errorMessage || l10n.t('String does not match the pattern of "{0}".', schema.pattern)

src/test/parser.test.ts

@@ -609,6 +609,18 @@ suite('JSON Parser', () => {
 
 		assert.strictEqual(semanticErrors!.length, 0);
 
+		semanticErrors = validate2(jsonDoc, textDoc, {
+			type: 'object',
+			properties: {
+				"one": {
+					type: 'string',
+					pattern: '*+ (invalid pattern)',
+				}
+			}
+		});
+
+		assert.strictEqual(semanticErrors!.length, 0);
+
 		semanticErrors = validate2(jsonDoc, textDoc, {
 			type: 'object',
 			properties: {