Skip to content

Commit 5692bed

Browse files
authored
fix boolean_schema schema tests (#217)
1 parent 58ab086 commit 5692bed

File tree

1 file changed

+2
-37
lines changed

1 file changed

+2
-37
lines changed

src/test/jsonSchemaTestSuite.test.ts

Lines changed: 2 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ async function assertSchemaValidation(input: any, schema: any, valid: boolean, d
3838
const schemaClone = JSON.parse(JSON.stringify(schema));
3939

4040
assert.strictEqual(jsonDoc.syntaxErrors.length, 0);
41-
const semanticErrors = await ls.doValidation(textDoc, jsonDoc, { schemaDraft: schemaIds[draft] }, schemaClone);
41+
const semanticErrors = await ls.doValidation(textDoc, jsonDoc, { schemaDraft: schemaIds[draft] }, Parser.asSchema(schemaClone));
4242
if (valid && semanticErrors.length > 0) {
4343
assert.deepStrictEqual([], semanticErrors, `\n${fileName}\n${description}: No error expected: ${JSON.stringify(input)} against ${JSON.stringify(schema)}`);
4444
} else if (!valid && semanticErrors.length === 0) {
@@ -122,15 +122,6 @@ const skippedTests = new Set([
122122
"draft4/refRemote.json/root ref in remote ref/string is valid",
123123
"draft4/refRemote.json/root ref in remote ref/null is valid",
124124
"draft4/refRemote.json/Location-independent identifier in remote ref/integer is valid",
125-
"draft6/boolean_schema.json/boolean schema 'false'/number is invalid",
126-
"draft6/boolean_schema.json/boolean schema 'false'/string is invalid",
127-
"draft6/boolean_schema.json/boolean schema 'false'/boolean true is invalid",
128-
"draft6/boolean_schema.json/boolean schema 'false'/boolean false is invalid",
129-
"draft6/boolean_schema.json/boolean schema 'false'/null is invalid",
130-
"draft6/boolean_schema.json/boolean schema 'false'/object is invalid",
131-
"draft6/boolean_schema.json/boolean schema 'false'/empty object is invalid",
132-
"draft6/boolean_schema.json/boolean schema 'false'/array is invalid",
133-
"draft6/boolean_schema.json/boolean schema 'false'/empty array is invalid",
134125
"draft6/definitions.json/validate definition against metaschema/valid definition schema",
135126
"draft6/id.json/id inside an enum is not a real identifier/exact match to enum, and type matches",
136127
"draft6/id.json/id inside an enum is not a real identifier/match $ref to id",
@@ -155,15 +146,6 @@ const skippedTests = new Set([
155146
"draft6/refRemote.json/remote ref with ref to definitions/valid",
156147
"draft6/refRemote.json/Location-independent identifier in remote ref/integer is valid",
157148
"draft6/unknownKeyword.json/$id inside an unknown keyword is not a real identifier/type matches second anyOf, which has a real schema in it",
158-
"draft7/boolean_schema.json/boolean schema 'false'/number is invalid",
159-
"draft7/boolean_schema.json/boolean schema 'false'/string is invalid",
160-
"draft7/boolean_schema.json/boolean schema 'false'/boolean true is invalid",
161-
"draft7/boolean_schema.json/boolean schema 'false'/boolean false is invalid",
162-
"draft7/boolean_schema.json/boolean schema 'false'/null is invalid",
163-
"draft7/boolean_schema.json/boolean schema 'false'/object is invalid",
164-
"draft7/boolean_schema.json/boolean schema 'false'/empty object is invalid",
165-
"draft7/boolean_schema.json/boolean schema 'false'/array is invalid",
166-
"draft7/boolean_schema.json/boolean schema 'false'/empty array is invalid",
167149
"draft7/id.json/id inside an enum is not a real identifier/exact match to enum, and type matches",
168150
"draft7/id.json/id inside an enum is not a real identifier/match $ref to id",
169151
"draft7/patternProperties.json/multiple simultaneous patternProperties are validated/an invalid due to the other is invalid",
@@ -190,15 +172,7 @@ const skippedTests = new Set([
190172
"draft2019-09/anchor.json/Location-independent identifier with absolute URI/match",
191173
"draft2019-09/anchor.json/Location-independent identifier with base URI change in subschema/match",
192174
"draft2019-09/anchor.json/same $anchor with different base uri/$ref should resolve to /$defs/A/allOf/1",
193-
"draft2019-09/boolean_schema.json/boolean schema 'false'/number is invalid",
194-
"draft2019-09/boolean_schema.json/boolean schema 'false'/string is invalid",
195-
"draft2019-09/boolean_schema.json/boolean schema 'false'/boolean true is invalid",
196-
"draft2019-09/boolean_schema.json/boolean schema 'false'/boolean false is invalid",
197-
"draft2019-09/boolean_schema.json/boolean schema 'false'/null is invalid",
198-
"draft2019-09/boolean_schema.json/boolean schema 'false'/object is invalid",
199-
"draft2019-09/boolean_schema.json/boolean schema 'false'/empty object is invalid",
200-
"draft2019-09/boolean_schema.json/boolean schema 'false'/array is invalid",
201-
"draft2019-09/boolean_schema.json/boolean schema 'false'/empty array is invalid",
175+
202176
"draft2019-09/defs.json/validate definition against metaschema/valid definition schema",
203177
"draft2019-09/dependentSchemas.json/boolean subschemas/object with property having schema false is invalid",
204178
"draft2019-09/dependentSchemas.json/boolean subschemas/object with both properties is invalid",
@@ -262,15 +236,6 @@ const skippedTests = new Set([
262236
"draft2020-12/anchor.json/Location-independent identifier with absolute URI/match",
263237
"draft2020-12/anchor.json/Location-independent identifier with base URI change in subschema/match",
264238
"draft2020-12/anchor.json/same $anchor with different base uri/$ref should resolve to /$defs/A/allOf/1",
265-
"draft2020-12/boolean_schema.json/boolean schema 'false'/number is invalid",
266-
"draft2020-12/boolean_schema.json/boolean schema 'false'/string is invalid",
267-
"draft2020-12/boolean_schema.json/boolean schema 'false'/boolean true is invalid",
268-
"draft2020-12/boolean_schema.json/boolean schema 'false'/boolean false is invalid",
269-
"draft2020-12/boolean_schema.json/boolean schema 'false'/null is invalid",
270-
"draft2020-12/boolean_schema.json/boolean schema 'false'/object is invalid",
271-
"draft2020-12/boolean_schema.json/boolean schema 'false'/empty object is invalid",
272-
"draft2020-12/boolean_schema.json/boolean schema 'false'/array is invalid",
273-
"draft2020-12/boolean_schema.json/boolean schema 'false'/empty array is invalid",
274239
"draft2020-12/defs.json/validate definition against metaschema/valid definition schema",
275240
"draft2020-12/dependentSchemas.json/boolean subschemas/object with property having schema false is invalid",
276241
"draft2020-12/dependentSchemas.json/boolean subschemas/object with both properties is invalid",

0 commit comments

Comments
 (0)