add support for textDocument/definition#50
Merged
aeschli merged 3 commits intomicrosoft:masterfrom Apr 27, 2020
ananthakumaran:definition
Merged
add support for textDocument/definition#50aeschli merged 3 commits intomicrosoft:masterfrom ananthakumaran:definition
aeschli merged 3 commits intomicrosoft:masterfrom
ananthakumaran:definition
Conversation
JSON Schema, Swagger, etc use $ref to reference reusable json snippets. Add the ability to jump to definition from $ref.
|
|
aeschli
reviewed
Mar 9, 2020
Collaborator
aeschli
left a comment
aeschli
left a comment
There was a problem hiding this comment.
Cool stuff.
Maybe its better forfindDefinition to return a Promise so that we, in the future also can support external links (url#ref)
Contributor
Author
|
updated |
Collaborator
|
Thanks @ananthakumaran ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON Schema, Swagger, etc use $ref to reference reusable json snippets. Add the ability to jump to definition from $ref.