Skip to content

Commit 3bfc9e7

Browse files
authored
Minor cleanup in our manifest / template manifests (#575)
Based on original feedback from #228 fixes #574 `msix/appxmanifest.xml` — Removed `EntryPoint="Windows.FullTrustApplication"` (redundant since MinVersion=10.0.19045.0 ≥ 20H1, and `uap10:TrustLevel`+`RuntimeBehavior` are already specified). `Templates/appxmanifest.packaged.xml` and `Templates/appxmanifest.sparse.xml` — Removed `uap10:TrustLevel="mediumIL"` and `uap10:RuntimeBehavior="packagedClassicApp"`, added `EntryPoint="Windows.FullTrustApplication"` instead. This ensures compatibility with systems back to MinVersion 10.0.18362.0 (pre-20H1) where uap10 attributes aren't available.
1 parent 8ba2b44 commit 3bfc9e7

4 files changed

Lines changed: 3 additions & 7 deletions

File tree

msix/appxmanifest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
<Applications>
3535
<Application Id="winapp"
3636
Executable="winapp.exe"
37-
EntryPoint="Windows.FullTrustApplication"
3837
uap10:RuntimeBehavior="packagedClassicApp"
3938
uap10:TrustLevel="mediumIL" >
4039
<uap:VisualElements

src/winapp-CLI/WinApp.Cli.Tests/ManifestCommandTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public async Task ManifestGenerateCommandWithSparseOptionShouldCreateSparseManif
126126
Assert.IsTrue(File.Exists(manifestPath), "Package.appxmanifest should be created");
127127
var manifestContent = await File.ReadAllTextAsync(manifestPath, TestContext.CancellationToken);
128128
Assert.Contains("uap10:AllowExternalContent", manifestContent, "Sparse manifest should contain AllowExternalContent");
129-
Assert.Contains("packagedClassicApp", manifestContent, "Sparse manifest should contain packagedClassicApp");
129+
Assert.Contains("EntryPoint=\"Windows.FullTrustApplication\"", manifestContent, "Sparse manifest should contain FullTrustApplication entry point");
130130
}
131131

132132
[TestMethod]

src/winapp-CLI/WinApp.Cli/Templates/appxmanifest.packaged.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@
3333
<Applications>
3434
<Application Id="{ApplicationId}"
3535
Executable="$targetnametoken$.exe"
36-
EntryPoint="Windows.FullTrustApplication"
37-
uap10:TrustLevel="mediumIL"
38-
uap10:RuntimeBehavior="packagedClassicApp">
36+
EntryPoint="Windows.FullTrustApplication">
3937
<uap:VisualElements
4038
DisplayName="{PackageName}"
4139
Description="{Description}"

src/winapp-CLI/WinApp.Cli/Templates/appxmanifest.sparse.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@
3535
<Applications>
3636
<Application Id="{ApplicationId}"
3737
Executable="$targetnametoken$.exe"
38-
uap10:TrustLevel="mediumIL"
39-
uap10:RuntimeBehavior="packagedClassicApp">
38+
EntryPoint="Windows.FullTrustApplication">
4039
<uap:VisualElements
4140
AppListEntry="none"
4241
DisplayName="{PackageName}"

0 commit comments

Comments
 (0)