Skip to content

Commit aadeca2

Browse files
authored
Turn federated auth on for Identity tests. (Azure#5785)
* Turn federated auth on for Identity tests. * Update test resources json.
1 parent 69ce3d7 commit aadeca2

4 files changed

Lines changed: 14 additions & 11 deletions

File tree

sdk/identity/azure-identity/test/ut/azure_pipelines_credential_test.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,7 @@ TEST(AzurePipelinesCredential, InvalidServiceConnectionId_LIVEONLY_)
644644
}
645645
}
646646

647-
TEST(AzurePipelinesCredential, InvalidSystemAccessToken_LIVEONLY_)
647+
TEST(AzurePipelinesCredential, DISABLED_InvalidSystemAccessToken_LIVEONLY_)
648648
{
649649
std::string tenantId = Environment::GetVariable("AZURESUBSCRIPTION_TENANT_ID");
650650
std::string clientId = Environment::GetVariable("AZURESUBSCRIPTION_CLIENT_ID");

sdk/identity/azure-identity/test/ut/token_credential_test.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ using namespace Azure::Identity;
5555

5656
TEST_F(TokenCredentialTest, ClientSecret)
5757
{
58+
if (m_testContext.IsLiveMode())
59+
{
60+
GTEST_SKIP_(
61+
"Skipping ClientSecret test since it requires env vars that aren't set in live mode.");
62+
}
63+
5864
std::string const testName(GetTestName());
5965
auto const clientSecretCredential = GetClientSecretCredential(testName);
6066

@@ -71,6 +77,12 @@ TEST_F(TokenCredentialTest, ClientSecret)
7177

7278
TEST_F(TokenCredentialTest, EnvironmentCredential)
7379
{
80+
if (m_testContext.IsLiveMode())
81+
{
82+
GTEST_SKIP_("Skipping EnvironmentCredential test since it requires env vars that aren't set in "
83+
"live mode.");
84+
}
85+
7486
std::string const testName(GetTestName());
7587
auto const clientSecretCredential = GetEnvironmentCredential(testName);
7688

sdk/identity/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ extends:
3030
LiveTestCtestRegex: azure-identity.
3131
LineCoverageTarget: 95
3232
BranchCoverageTarget: 56
33+
UseFederatedAuth: true
3334
Artifacts:
3435
- Name: azure-identity
3536
Path: azure-identity

sdk/identity/test-resources.json

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@
1414
"metadata": {
1515
"description": "The application client ID used to run tests."
1616
}
17-
},
18-
"testApplicationSecret": {
19-
"type": "string",
20-
"metadata": {
21-
"description": "The application client secret used to run tests."
22-
}
2317
}
2418
},
2519
"resources": [],
@@ -31,10 +25,6 @@
3125
"AZURE_CLIENT_ID": {
3226
"type": "string",
3327
"value": "[parameters('testApplicationId')]"
34-
},
35-
"AZURE_CLIENT_SECRET": {
36-
"type": "string",
37-
"value": "[parameters('testApplicationSecret')]"
3828
}
3929
}
4030
}

0 commit comments

Comments
 (0)