Skip to content

Commit 8837277

Browse files
committed
fix: workaround for sideEffects:false not honoured by esbuild
Closes #1548 Signed-off-by: will Farrell <willfarrell@proton.me>
1 parent be71455 commit 8837277

10 files changed

Lines changed: 43 additions & 16 deletions

File tree

packages/core/executionModeDurableContext.test.js_

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
import { deepStrictEqual, strictEqual } from "node:assert/strict";
22
import { test } from "node:test";
33
import { LocalDurableTestRunner } from "@aws/durable-execution-sdk-js-testing";
4-
import middy, { executionModeDurableContext } from "./index.js";
4+
import middy from "./index.js";
5+
import { executionModeDurableContext } from "./executionModeDurableContext.js";
56

67
const _event = {};
78
const _context = {

packages/core/executionModeStreamifyResponse.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import {
66
createWritableStream,
77
pipejoin,
88
} from "@datastream/core";
9-
import middy, { executionModeStreamifyResponse } from "./index.js";
9+
import { executionModeStreamifyResponse } from "./executionModeStreamifyResponse.js";
10+
import middy from "./index.js";
1011

1112
const event = {};
1213
const context = {

packages/core/index.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
import { setTimeout } from "node:timers";
22
import { executionModeStandard } from "./executionModeStandard.js";
33

4-
export { executionModeDurableContext } from "./executionModeDurableContext.js";
5-
export { executionModeStandard } from "./executionModeStandard.js";
6-
export { executionModeStreamifyResponse } from "./executionModeStreamifyResponse.js";
7-
84
const defaultLambdaHandler = () => {};
95
const defaultPluginConfig = {
106
timeoutEarlyInMillis: 5,

packages/core/package.json

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,30 @@
2121
"require": {
2222
"default": "./index.js"
2323
}
24+
},
25+
"./Standard": {
26+
"import": {
27+
"default": "./executionModeStandard.js"
28+
},
29+
"require": {
30+
"default": "./executionModeStandard.js"
31+
}
32+
},
33+
"./DurableContext": {
34+
"import": {
35+
"default": "./executionModeDurableContext.js"
36+
},
37+
"require": {
38+
"default": "./executionModeDurableContext.js"
39+
}
40+
},
41+
"./StreamifyResponse": {
42+
"import": {
43+
"default": "./executionModeStreamifyResponse.js"
44+
},
45+
"require": {
46+
"default": "./executionModeStreamifyResponse.js"
47+
}
2448
}
2549
},
2650
"types": "index.d.ts",

packages/s3-object-response/index.fuzz.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ import middleware from "./index.js";
88

99
mockClient(S3Client)
1010
.on(WriteGetObjectResponseCommand)
11-
.resolves({ statusCode: 200 });
12-
13-
// Causes memory leak
11+
.resolves({ statusCode: 200 }); // Causes memory leak
1412
// const agent = new MockAgent();
1513
// setGlobalDispatcher(agent);
1614
// agent
@@ -23,7 +21,8 @@ mockClient(S3Client)
2321
// headers: {
2422
// "Content-Type": "application/json; charset=UTF-8",
2523
// },
26-
// });
24+
// })
25+
// .persist()
2726
global.fetch = (url, request) => {
2827
return Promise.resolve(
2928
new Response("", {

website/docs/events/function-url.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ Same as API Gateway (HTTP), but with support for response streams.
1212
## Example
1313

1414
```javascript
15-
import middy, { executionModeStreamifyResponse } from '@middy/core'
15+
import middy from '@middy/core'
16+
import { executionModeStreamifyResponse } from '@middy/core/StreamifyResponse'
1617
import errorLoggerMiddleware from '@middy/error-logger'
1718
import inputOutputLoggerMiddleware from '@middy/input-output-logger'
1819
import httpContentNegotiationMiddleware from '@middy/http-content-negotiation'

website/docs/intro/06-durable-functions.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ npm install --save @middy/core @aws/durable-execution-sdk-js
1515
```
1616

1717
```javascript
18-
import middy, { executionModeDurableContext } from '@middy/core'
18+
import middy from '@middy/core'
19+
import { executionModeDurableContext } from '@middy/core/DurableContext'
1920
import { createReadableStream } from '@datastream/core'
2021

2122
const lambdaHandler = (event, context, {signal}) => {

website/docs/intro/06-streamify-response.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ Middy also supports streamed responses.
1717
## Lambda Function URL Example
1818

1919
```javascript
20-
import middy, { executionModeStreamifyResponse } from '@middy/core'
20+
import middy from '@middy/core'
21+
import { executionModeStreamifyResponse } from '@middy/core/StreamifyResponse'
2122
import { createReadableStream } from '@datastream/core'
2223

2324
const lambdaHandler = (event, context) => {
@@ -36,7 +37,8 @@ export const handler = middy({ executionMode: executionModeStreamifyResponse }).
3637
## Lambda InvokeWithResponseStream Example
3738

3839
```javascript
39-
import middy, { executionModeStreamifyResponse } from '@middy/core'
40+
import middy from '@middy/core'
41+
import { executionModeStreamifyResponse } from '@middy/core/StreamifyResponse'
4042
import { createReadableStream } from '@datastream/core'
4143

4244
const lambdaHandler = (event, context) => {

website/docs/middlewares/http-content-encoding.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,8 @@ export const handler = middy()
5353
### Using streams
5454
5555
```javascript
56-
import middy, { executionModeStreamifyResponse } from '@middy/core'
56+
import middy from '@middy/core'
57+
import { executionModeStreamifyResponse } from '@middy/core/StreamifyResponse'
5758
import httpContentNegotiation from '@middy/http-content-negotiation'
5859
import httpContentEncoding from '@middy/http-content-encoding'
5960
import { constants } from 'node:zlib'

website/docs/upgrade/6-7.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ export const handler = middy({ streamifyResponse: true })
3232
changes to
3333

3434
```javascript
35-
import middy, { executionModeStreamifyResponse } from '@middy/core'
35+
import middy from '@middy/core'
36+
import { executionModeStreamifyResponse } from '@middy/core/StreamifyResponse'
3637

3738
const lambdaHandler = (_event, _context) => {
3839
// ...

0 commit comments

Comments
 (0)