update literal from 'orcid' to 'ORCID'

Author: mkovalua

api/users/views.py

@@ -755,7 +755,8 @@ def post(self, request, *args, **kwargs):
             # 1. update user oauth, with pending status
             external_identity[external_id_provider][external_id] = 'LINK'
             if external_id_provider in user.external_identity:
-                if external_id_provider == 'orcid':
+                # v2 looks to be used for auth but add orcid external identity rewrite updates for v1 as well
+                if external_id_provider == settings.EXTERNAL_IDENTITY_PROFILE.get('OrcidProfile'):
                     user.external_identity[external_id_provider] = external_identity[external_id_provider]
                 else:
                     user.external_identity[external_id_provider].update(external_identity[external_id_provider])

api_tests/users/views/test_user_external_login.py

@@ -90,18 +90,18 @@ def test_existing_user(self, app, payload, url, user_one, session_data, csrf_tok
 
     def test_existing_user_orcid_overwrites(self, app, payload, url, user_one, session_data, csrf_token):
         user_one.external_identity = {
-            'orcid': {
+            'ORCID': {
                 '0000-0000-0000-0000': 'LINK',
             }
         }
         user_one.save()
         app.set_cookie(CSRF_COOKIE_NAME, csrf_token)
         app.set_cookie(settings.COOKIE_NAME, str(session_data))
-        assert '0000-0000-0000-0000' in user_one.external_identity['orcid']
+        assert '0000-0000-0000-0000' in user_one.external_identity['ORCID']
         payload['data']['attributes']['email'] = user_one.username
         with capture_notifications():
             res = app.post_json_api(url, payload, headers={'X-CSRFToken': csrf_token})
         assert res.status_code == 200
         user_one.reload()
-        assert '0000-0000-0000-0000' not in user_one.external_identity['orcid']
-        assert user_one.external_identity['orcid'] == {'1234-1234-1234-1234': 'LINK'}
+        assert '0000-0000-0000-0000' not in user_one.external_identity['ORCID']
+        assert user_one.external_identity['ORCID'] == {'1234-1234-1234-1234': 'LINK'}

framework/auth/views.py

@@ -1097,7 +1097,8 @@ def external_login_email_post():
             # 1. update user oauth, with pending status
             external_identity[external_id_provider][external_id] = 'LINK'
             if external_id_provider in user.external_identity:
-                if external_id_provider == 'orcid':
+                # v2 looks to be used for auth but add orcid external identity rewrite updates for v1 as well
+                if external_id_provider == settings.EXTERNAL_IDENTITY_PROFILE.get('OrcidProfile'):
                     user.external_identity[external_id_provider] = external_identity[external_id_provider]
                 else:
                     user.external_identity[external_id_provider].update(external_identity[external_id_provider])