resolve CR comments update unittests

Author: mkovalua

api/base/middleware.py

@@ -141,8 +141,6 @@ def __init__(self, get_response):
         self.get_response = get_response
 
     def __call__(self, request):
-        if request.path.endswith('/v2'):
-            return self.get_response(request)
         if MaintenanceMode.is_under_maintenance():
             return JsonResponse(
                 {

osf_tests/test_middleware.py

@@ -1,28 +1,94 @@
-import json
 import pytest
 from unittest import mock
+from tests.base import ApiTestCase
+from osf.utils import permissions
+from osf_tests.factories import (
+    AuthUserFactory,
+    CollectionProviderFactory,
+    ProjectFactory,
+)
 
-class TestMaintenanceModeMiddlewareIntegration:
 
+@pytest.fixture()
+def provider():
+    provider = CollectionProviderFactory()
+    provider.update_group_permissions()
+    return provider
+
+
+@pytest.fixture()
+def admin(provider):
+    user = AuthUserFactory()
+    provider.get_group(permissions.ADMIN).user_set.add(user)
+    return user
+
+
+@pytest.fixture()
+def node(admin):
+    return ProjectFactory(creator=admin)
+
+
+class TestMaintenanceModeMiddlewareIntegration(ApiTestCase):
     MAINTENANCE_MOCK_PATH = 'api.base.middleware.MaintenanceMode.is_under_maintenance'
 
+    def setUp(self):
+        super().setUp()
+        self.provider = CollectionProviderFactory()
+        self.provider.update_group_permissions()
+        self.admin = AuthUserFactory()
+        self.provider.get_group(permissions.ADMIN).user_set.add(self.admin)
+        self.node = ProjectFactory(creator=self.admin)
+
+    @mock.patch(MAINTENANCE_MOCK_PATH, return_value=True)
+    def test_middleware_blocks_post_when_maintenance_mode_on(self, mock_maintenance):
+        url = f'/v2/nodes/{self.node._id}/'
+        response = self.app.post_json(url, {}, expect_errors=True)
+        assert response.status_code == 503
+        assert response.json['meta']['maintenance_mode'] is True
+        assert response.json['meta']['status_page'] == 'https://status.cos.io'
+
     @mock.patch(MAINTENANCE_MOCK_PATH, return_value=True)
-    def test_bypasses_v2_root_if_maintenance_mode_on(self, mock_maintenance, client):
-        response = client.get('/v2')
-        assert response.status_code != 503
-        mock_maintenance.assert_not_called()
+    def test_middleware_blocks_patch_when_maintenance_mode_on(self, mock_maintenance):
+        url = f'/v2/nodes/{self.node._id}/'
+        response = self.app.patch_json(url, {}, expect_errors=True)
+        assert response.status_code == 503
+        assert response.json['meta']['maintenance_mode'] is True
 
-    @pytest.mark.parametrize('method', ['post', 'patch', 'put', 'delete'])
     @mock.patch(MAINTENANCE_MOCK_PATH, return_value=True)
-    def test_middleware_blocks_different_requests_if_maintenance_mode_on(self, mock_maintenance, client, method):
-        client_method = getattr(client, method)
-        response = client_method('/v2/nodes/', data={}, content_type='application/json')
+    def test_middleware_blocks_delete_when_maintenance_mode_on(self, mock_maintenance):
+        url = f'/v2/nodes/{self.node._id}/'
+        response = self.app.delete(url, expect_errors=True)
+
         assert response.status_code == 503
-        data = json.loads(response.content)
-        assert data['meta']['maintenance_mode'] is True
-        assert data['meta']['status_page'] == 'https://status.cos.io'
+        assert response.json['meta']['maintenance_mode'] is True
+
+    @mock.patch(MAINTENANCE_MOCK_PATH, return_value=False)
+    def test_go_to_post_view_when_maintenance_mode_off(self, mock_maintenance):
+        url = '/v2/nodes/'
+        payload = {
+            'data': {
+                'type': 'nodes',
+                'attributes': {'title': 'New Node', 'category': 'project'}
+            }
+        }
+        response = self.app.post_json(url, payload, auth=self.admin.auth)
+        assert response.status_code == 201
+
+    @mock.patch(MAINTENANCE_MOCK_PATH, return_value=False)
+    def test_go_to_post_view_if_maintenance_mode_off(self, mock_maintenance):
+        url = f'/v2/nodes/{self.node._id}/'
+        payload = {
+            'data': {
+                'id': self.node._id,
+                'type': 'nodes',
+                'attributes': {'title': 'Updated Title'}
+            }
+        }
+        response = self.app.patch_json(url, payload, auth=self.admin.auth)
+        assert response.status_code == 200
 
     @mock.patch(MAINTENANCE_MOCK_PATH, return_value=False)
-    def test_passes_through_when_maintenance_mode_off(self, mock_maintenance, client):
-        response = client.get('/v2/nodes/')
-        assert response.status_code != 503
+    def test_go_to_delete_view_if_maintenance_mode_off(self, mock_maintenance):
+        url = f'/v2/nodes/{self.node._id}/'
+        response = self.app.delete(url, auth=self.admin.auth)
+        assert response.status_code == 204