Commit 05cb0e6
committed
revert: drop docker hub description sync job
The sync-description job added in #1544 fails in CI because the
DOCKERHUB_USERNAME secret is set to the org name (manifestdotbuild),
which works for docker/login-action (registry API) but is rejected by
docker-pushrm's web-API login endpoint — you can't log into
hub.docker.com as an org, only as a user with access to the org.
Fixing this properly would require either rotating DOCKERHUB_USERNAME
to a personal user's login (risks affecting other workflows that might
rely on the org-scoped semantic) or adding a second set of secrets for
the sync job only. Neither is worth it right now — maintainer will
keep updating the Docker Hub description manually.
Revert:
- Remove sync-description job from .github/workflows/docker.yml
- Remove the push: main trigger that existed only to fire sync-description
- Remove the CLAUDE.md 'Docker Hub description' subsection
- Remove the sync-description mentions from the 'Cutting a Docker
release' checklist and the CI triggers summary table
- Add a step 4 to the release checklist reminding the maintainer to
copy docker/DOCKER_README.md to the Docker Hub page by hand
Not reverted (intentionally kept):
- docker/DOCKER_README.md content refresh (drop deprecated npm badge,
update 'personal AI agents' framing, add Image tags section, etc.)
- docker/DOCKER_README.md removal from the pull_request paths filter
(content-only PRs shouldn't trigger a 7-minute multi-arch rebuild)1 parent 478e1b7 commit 05cb0e6
2 files changed
+3
-42
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | 10 | | |
16 | 11 | | |
17 | 12 | | |
| |||
114 | 109 | | |
115 | 110 | | |
116 | 111 | | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
506 | 506 | | |
507 | 507 | | |
508 | 508 | | |
509 | | - | |
| 509 | + | |
| 510 | + | |
510 | 511 | | |
511 | 512 | | |
512 | 513 | | |
513 | | - | |
514 | | - | |
515 | | - | |
516 | | - | |
517 | 514 | | |
518 | 515 | | |
519 | 516 | | |
520 | 517 | | |
521 | 518 | | |
522 | | - | |
523 | 519 | | |
524 | 520 | | |
525 | | - | |
526 | | - | |
| 521 | + | |
527 | 522 | | |
528 | 523 | | |
529 | 524 | | |
| |||
0 commit comments