Commit 8df6e3d
committed
fix(db): always run migrations on boot; drop AUTO_MIGRATE gate
Removes the AUTO_MIGRATE / NODE_ENV gate on TypeORM migrationsRun and
makes migrations run unconditionally on every boot. The gate was a
relic of when the same config served dev / test / prod with different
needs; with synchronize permanently false, committed migrations are the
only path for schema changes and there's no production scenario where
booting with pending migrations is correct.
5.45.1 shipped this gate without honoring AUTO_MIGRATE, so fresh
production installs only got Better Auth's 4 tables — the dashboard
500'd on missing user_providers / notification_rules. The fix landed
in fc7890f and is in 5.46.0+, but pinning behavior to an env var
that compose must set is a footgun: a future env-var typo would
silently re-introduce the bug. Promoting the default removes the
class of mistake.
Compose and the docker run examples drop the AUTO_MIGRATE=true line
since it's now redundant. The autoMigrate config field and its three
spec tests are removed — nothing in production code reads them.
Companion to the Phase 3 hardening pass (#1551 / #1557).1 parent 3b9c719 commit 8df6e3d
File tree
6 files changed
+8
-28
lines changed- docker
- packages/backend
- src
- config
- database
6 files changed
+8
-28
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
134 | 133 | | |
135 | 134 | | |
136 | 135 | | |
| |||
147 | 146 | | |
148 | 147 | | |
149 | 148 | | |
150 | | - | |
151 | 149 | | |
152 | 150 | | |
153 | 151 | | |
| |||
164 | 162 | | |
165 | 163 | | |
166 | 164 | | |
167 | | - | |
168 | 165 | | |
169 | 166 | | |
170 | 167 | | |
171 | 168 | | |
172 | 169 | | |
173 | | - | |
| 170 | + | |
174 | 171 | | |
175 | 172 | | |
176 | 173 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | 35 | | |
37 | 36 | | |
38 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | 89 | | |
108 | 90 | | |
109 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | 15 | | |
17 | 16 | | |
18 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | | - | |
153 | | - | |
154 | | - | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
155 | 159 | | |
156 | 160 | | |
157 | 161 | | |
| |||
0 commit comments