Merge pull request #969 from mnfst/fix/duplicate-ghost-messages

fix: eliminate duplicate ghost messages in dashboard

Author: brunobuddy

.changeset/fix-duplicate-ghost-messages.md

@@ -0,0 +1,10 @@
+---
+"manifest": patch
+---
+
+Fix duplicate/ghost messages in dashboard
+
+- Remove dummy seed data (seed-messages, demo security events, admin user)
+- Record all proxy errors (not just 429/403/500+) so 400 errors show as Failed
+- Fix ghost duplicate messages: unknown OTLP spans no longer create agent_messages
+- Add timestamp-based dedup to prevent OTLP spans from duplicating proxy error records

packages/backend/src/database/seed-messages.spec.ts

@@ -66,9 +66,7 @@ describe('seedAgentMessages', () => {
       await seedAgentMessages(mockRepo as never, 'user-1', logger);
 
       expect(logger.log).toHaveBeenCalledTimes(1);
-      expect(logger.log).toHaveBeenCalledWith(
-        expect.stringMatching(/^Seeded \d+ agent messages$/),
-      );
+      expect(logger.log).toHaveBeenCalledWith(expect.stringMatching(/^Seeded \d+ agent messages$/));
     });
 
     it('should generate approximately 695 messages over 7 days', async () => {
@@ -102,12 +100,7 @@ describe('seedAgentMessages', () => {
         agentName: 'my-agent',
       };
 
-      await seedAgentMessages(
-        mockRepo as never,
-        'user-2',
-        logger,
-        customCtx,
-      );
+      await seedAgentMessages(mockRepo as never, 'user-2', logger, customCtx);
 
       const messages = collectInsertedMessages(mockRepo);
       expect(messages.length).toBeGreaterThan(0);

packages/backend/src/database/seed-messages.ts

@@ -18,12 +18,21 @@ export async function seedAgentMessages(
   messageRepo: Repository<AgentMessage>,
   userId: string,
   logger: Logger,
-  ctx: SeedContext = { tenantId: 'seed-tenant-001', agentId: 'seed-agent-001', agentName: 'demo-agent' },
+  ctx: SeedContext = {
+    tenantId: 'seed-tenant-001',
+    agentId: 'seed-agent-001',
+    agentName: 'demo-agent',
+  },
 ): Promise<void> {
   const count = await messageRepo.count();
   if (count > 0) return;
 
-  const models = ['claude-sonnet-4-5-20250929', 'gpt-4o', 'claude-haiku-4-5-20251001', 'gemini-2.5-flash'];
+  const models = [
+    'claude-sonnet-4-5-20250929',
+    'gpt-4o',
+    'claude-haiku-4-5-20251001',
+    'gemini-2.5-flash',
+  ];
   const now = Date.now();
   const messages: Array<Partial<AgentMessage>> = [];
   let idx = 0;
@@ -33,9 +42,10 @@ export async function seedAgentMessages(
     const hourBase = now - h * 3600000;
     // Fewer messages at night (hours 0-7 UTC), more during work hours
     const utcHour = new Date(hourBase).getUTCHours();
-    const msgCount = utcHour >= 8 && utcHour <= 22
-      ? 4 + Math.floor(seededRandom(h) * 5)
-      : Math.floor(seededRandom(h + 500) * 3);
+    const msgCount =
+      utcHour >= 8 && utcHour <= 22
+        ? 4 + Math.floor(seededRandom(h) * 5)
+        : Math.floor(seededRandom(h + 500) * 3);
 
     for (let m = 0; m < msgCount; m++) {
       idx++;