Commit e4b0e66
committed
fix: address cubic review on PR #1544
- P1: pin chko/docker-pushrm to an immutable sha256 digest instead of
the mutable ':1' tag. Using a major tag means an attacker who
compromised the upstream repo could ship a malicious image and our
workflow would pull it with DOCKERHUB_USERNAME/DOCKERHUB_TOKEN in the
environment. Resolved the current digest via the Docker Hub registry
API and left an inline comment documenting how to bump it.
- P2: fix CLAUDE.md wording that described the Docker Hub PAT in
GitHub-PAT-scope terminology ('repo:write on the org repo'). Docker
Hub PATs have their own scopes; the docs now just say 'write access
to the repo' and mention the digest-pinning behavior.1 parent 3eb2857 commit e4b0e66
2 files changed
+9
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
130 | 137 | | |
131 | 138 | | |
132 | 139 | | |
133 | 140 | | |
134 | | - | |
| 141 | + | |
135 | 142 | | |
136 | 143 | | |
137 | 144 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
512 | 512 | | |
513 | 513 | | |
514 | 514 | | |
515 | | - | |
| 515 | + | |
516 | 516 | | |
517 | 517 | | |
518 | 518 | | |
| |||
0 commit comments