Skip to content

Commit d1838d7

Browse files
dsmmckenmofojed
andauthored
refactor: Clean up golden-layout css (deephaven#1322)
We maintain our golden-layout package, bake our theme customizations directly into the dark theme. Eliminates some css. Used e2e testing to prevent visual regressions, the two changes showing are intentional. Had to exclude the ThemeExport from the karma tests, it didn't like the scss import. --------- Co-authored-by: Mike Bender <mikebender@deephaven.io>
1 parent 99818a8 commit d1838d7

23 files changed

Lines changed: 320 additions & 483 deletions

package-lock.json

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/dashboard/src/PanelPlaceholder.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,13 @@
44
display: flex;
55
flex-direction: column;
66
justify-content: center;
7-
padding: $spacer-3;
87
min-height: 100%;
98
max-height: 100%;
109
text-align: center;
1110
overflow: hidden;
11+
12+
// add padding on an inner wrapper so it is included in max height of parent
13+
div {
14+
padding: $spacer-3;
15+
}
1216
}

packages/dashboard/src/PanelPlaceholder.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const PanelPlaceholder = React.forwardRef(
1111
const component = LayoutUtils.getComponentNameFromPanel({ props });
1212
return (
1313
<div ref={ref} className="panel-placeholder">
14-
Component &quot;{component}&quot; is not registered.
14+
<div>Component &quot;{component}&quot; is not registered.</div>
1515
</div>
1616
);
1717
}

packages/dashboard/src/layout/GoldenLayout.module.scss

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)