forked from redhat-developer/vscode-openshift-tools
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathstorage.test.ts
More file actions
345 lines (284 loc) · 14.9 KB
/
storage.test.ts
File metadata and controls
345 lines (284 loc) · 14.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
/*-----------------------------------------------------------------------------------------------
* Copyright (c) Red Hat, Inc. All rights reserved.
* Licensed under the MIT License. See LICENSE file in the project root for license information.
*-----------------------------------------------------------------------------------------------*/
'use strict';
import * as vscode from 'vscode';
import * as chai from 'chai';
import * as sinonChai from 'sinon-chai';
import * as sinon from 'sinon';
import { TestItem } from './testOSItem';
import { OdoImpl, Command, ContextType } from '../../../src/odo';
import { Storage } from '../../../src/openshift/storage';
import { OpenShiftItem } from '../../../src/openshift/openshiftItem';
const expect = chai.expect;
chai.use(sinonChai);
suite('OpenShift/Storage', () => {
let sandbox: sinon.SinonSandbox;
let execStub: sinon.SinonStub;
let quickPickStub: sinon.SinonStub;
let inputStub: sinon.SinonStub;
let getProjectNamesStub: sinon.SinonStub;
let getStorageNamesStub: sinon.SinonStub;
const projectItem = new TestItem(null, 'project', ContextType.PROJECT);
const appItem = new TestItem(projectItem, 'app', ContextType.APPLICATION);
const componentItem = new TestItem(appItem, 'component', ContextType.COMPONENT);
const storageItem = new TestItem(componentItem, 'storage', ContextType.STORAGE);
const mountPath = '/mnt';
const size = '1Gi';
const errorMessage = 'FATAL ERROR';
setup(() => {
sandbox = sinon.createSandbox();
getStorageNamesStub = sandbox.stub(OdoImpl.prototype, 'getStorageNames').resolves([storageItem]);
execStub = sandbox.stub(OdoImpl.prototype, 'execute').resolves({error: '', stdout: '', stderr: ''});
quickPickStub = sandbox.stub(vscode.window, 'showQuickPick');
});
teardown(() => {
sandbox.restore();
});
suite('create Storage with no context', () => {
setup(() => {
quickPickStub.onFirstCall().resolves(projectItem);
quickPickStub.onSecondCall().resolves(appItem);
quickPickStub.onThirdCall().resolves(componentItem);
getProjectNamesStub = sandbox.stub(OpenShiftItem, 'getProjectNames').resolves([projectItem]);
sandbox.stub(OpenShiftItem, 'getApplicationNames').resolves([appItem]);
sandbox.stub(OpenShiftItem, 'getComponentNames').resolves([componentItem]);
inputStub = sandbox.stub(vscode.window, 'showInputBox');
inputStub.onFirstCall().resolves(storageItem.getName());
inputStub.onSecondCall().resolves(mountPath);
quickPickStub.resolves(size);
});
teardown(() => {
sandbox.restore();
});
test('calls the appropriate error message if no project found', async () => {
quickPickStub.restore();
getProjectNamesStub.restore();
sandbox.stub(OdoImpl.prototype, 'getProjects').resolves([]);
sandbox.stub(vscode.window, 'showErrorMessage');
try {
await Storage.create(null);
} catch (err) {
expect(err.message).equals('You need at least one Project available. Please create new OpenShift Project and try again.');
return;
}
expect.fail();
});
test('calls the appropriate error message if no application found', async () => {
sandbox.stub(OdoImpl.prototype, 'getProjects').resolves([projectItem]);
sandbox.stub(OdoImpl.prototype, 'getApplications').resolves([appItem]);
sandbox.stub(OdoImpl.prototype, 'getComponents').resolves([]);
sandbox.stub(vscode.window, 'showErrorMessage');
try {
await Storage.create(null);
} catch (err) {
expect(err.message).equals('You need at least one Component available to create an Storage. Please create new OpenShift Project and try again.');
return;
}
});
test('exits without creating storage if canceled by user', async () => {
sandbox.stub(Storage, 'getOpenShiftCmdData').resolves(null);
const result = await Storage.create(null);
expect(result).is.null;
});
test('works with valid inputs', async () => {
sandbox.stub(OdoImpl.prototype, 'getProjects').resolves([projectItem]);
sandbox.stub(OdoImpl.prototype, 'getApplications').resolves([appItem]);
sandbox.stub(OdoImpl.prototype, 'getComponents').resolves([componentItem]);
const result = await Storage.create(null);
expect(result).equals(`Storage '${storageItem.getName()}' successfully created for Component '${componentItem.getName()}'`);
});
test('returns null when no storage name selected', async () => {
inputStub.onFirstCall().resolves();
const result = await Storage.create(null);
expect(result).null;
});
test('returns null when no mount path selected', async () => {
inputStub.onSecondCall().resolves();
const result = await Storage.create(null);
expect(result).null;
});
test('returns null when no storage size selected', async () => {
quickPickStub.resolves();
const result = await Storage.create(null);
expect(result).null;
});
test('wraps odo errors with additional info', async () => {
execStub.rejects(errorMessage);
try {
await Storage.create(null);
expect.fail();
} catch (err) {
expect(err).equals(`New Storage command failed with error: '${errorMessage}'!`);
}
});
});
suite('create', () => {
setup(() => {
inputStub = sandbox.stub(vscode.window, 'showInputBox');
inputStub.onFirstCall().resolves(storageItem.getName());
inputStub.onSecondCall().resolves(mountPath);
quickPickStub.resolves(size);
});
teardown(() => {
sandbox.restore();
});
test('works with valid inputs', async () => {
const result = await Storage.create(componentItem);
expect(result).equals(`Storage '${storageItem.getName()}' successfully created for Component '${componentItem.getName()}'`);
expect(execStub).calledOnceWith(Command.createStorage(storageItem.getName(), mountPath, size));
});
test('returns null when no storage name selected', async () => {
inputStub.onFirstCall().resolves();
const result = await Storage.create(componentItem);
expect(result).null;
});
test('returns null when no mount path selected', async () => {
inputStub.onSecondCall().resolves();
const result = await Storage.create(componentItem);
expect(result).null;
});
test('returns null when no storage size selected', async () => {
quickPickStub.resolves();
const result = await Storage.create(componentItem);
expect(result).null;
});
test('wraps odo errors with additional info', async () => {
execStub.rejects(errorMessage);
try {
await Storage.create(componentItem);
expect.fail();
} catch (err) {
expect(err).equals(`New Storage command failed with error: '${errorMessage}'!`);
}
});
});
suite('validation', () => {
setup(() => {
inputStub.restore();
});
test('validator returns undefined for valid storage name', async () => {
let result: string | Thenable<string>;
inputStub = sandbox.stub(vscode.window, 'showInputBox').onFirstCall().callsFake((options?: vscode.InputBoxOptions, token?: vscode.CancellationToken): Thenable<string> => {
result = options.validateInput('goodvalue');
return Promise.resolve('goodvalue');
});
inputStub.onSecondCall().resolves();
await Storage.create(componentItem);
expect(result).is.undefined;
});
test('validator returns error message for empty storage', async () => {
let result: string | Thenable<string>;
inputStub = sandbox.stub(vscode.window, 'showInputBox').onFirstCall().callsFake((options?: vscode.InputBoxOptions, token?: vscode.CancellationToken): Thenable<string> => {
result = options.validateInput('');
return Promise.resolve('');
});
inputStub.onSecondCall().resolves();
await Storage.create(componentItem);
expect(result).equals('Empty Storage name');
});
test('validator returns undefined for valid storage path', async () => {
let result: string | Thenable<string>;
inputStub = sandbox.stub(vscode.window, 'showInputBox').onFirstCall().resolves('name');
inputStub.onSecondCall().callsFake((options?: vscode.InputBoxOptions, token?: vscode.CancellationToken): Thenable<string> => {
result = options.validateInput('goodvalue');
return Promise.resolve('goodvalue');
});
await Storage.create(componentItem);
expect(result).is.undefined;
});
test('validator returns error message for empty storage path', async () => {
let result: string | Thenable<string>;
inputStub = sandbox.stub(vscode.window, 'showInputBox').onFirstCall().resolves('name');
inputStub.onSecondCall().callsFake((options?: vscode.InputBoxOptions, token?: vscode.CancellationToken): Thenable<string> => {
result = options.validateInput('');
return Promise.resolve('');
});
await Storage.create(componentItem);
expect(result).equals('Invalid mount path');
});
test('validator returns error message for none alphanumeric storage name', async () => {
let result: string | Thenable<string>;
inputStub.restore();
inputStub = sandbox.stub(vscode.window, 'showInputBox').onFirstCall().callsFake((options?: vscode.InputBoxOptions, token?: vscode.CancellationToken): Thenable<string> => {
result = options.validateInput('name&name');
return Promise.resolve('name&name');
});
await Storage.create(componentItem);
expect(result).equals('Not a valid Storage name. Please use lower case alphanumeric characters or "-", start with an alphabetic character, and end with an alphanumeric character');
});
test('validator returns error message if same name of storage found', async () => {
let result: string | Thenable<string>;
inputStub.restore();
inputStub = sandbox.stub(vscode.window, 'showInputBox').onFirstCall().callsFake((options?: vscode.InputBoxOptions, token?: vscode.CancellationToken): Thenable<string> => {
result = options.validateInput('storage');
return Promise.resolve('storage');
});
await Storage.create(componentItem);
expect(result).equals('This name is already used, please enter different name.');
});
test('validator returns error message for storage name longer than 63 characters', async () => {
let result: string | Thenable<string>;
inputStub.restore();
inputStub = sandbox.stub(vscode.window, 'showInputBox').onFirstCall().callsFake((options?: vscode.InputBoxOptions, token?: vscode.CancellationToken): Thenable<string> => {
result = options.validateInput('n123456789012345678901234567890123456789012345678901234567890123');
return Promise.resolve('n123456789012345678901234567890123456789012345678901234567890123');
});
await Storage.create(componentItem);
expect(result).equals('Storage name should be between 2-63 characters');
});
teardown(() => {
sandbox.restore();
});
});
suite('del', () => {
let warnStub: sinon.SinonStub;
setup(() => {
getProjectNamesStub = sandbox.stub(OpenShiftItem, 'getProjectNames').resolves([projectItem]);
sandbox.stub(OpenShiftItem, 'getApplicationNames').resolves([appItem]);
sandbox.stub(OpenShiftItem, 'getComponentNames').resolves([componentItem]);
sandbox.stub(OpenShiftItem, 'getStorageNames').resolves([storageItem]);
sandbox.stub(OdoImpl.prototype, 'getProjects').resolves([]);
sandbox.stub(OdoImpl.prototype, 'getApplications').resolves([]);
sandbox.stub(OdoImpl.prototype, 'getComponents').resolves([]);
getStorageNamesStub.resolves([]);
quickPickStub.onFirstCall().resolves(projectItem);
quickPickStub.onSecondCall().resolves(appItem);
quickPickStub.onThirdCall().resolves(componentItem);
quickPickStub.onCall(3).resolves(storageItem);
warnStub = sandbox.stub(vscode.window, 'showWarningMessage').resolves('Yes');
});
test('works with set tree item', async () => {
const result = await Storage.del(storageItem);
expect(result).equals(`Storage '${storageItem.getName()}' from Component '${componentItem.getName()}' successfully deleted`);
expect(execStub.getCall(0).args[0]).equals(Command.deleteStorage(storageItem.getName()));
expect(execStub.getCall(1).args[0]).equals(Command.waitForStorageToBeGone(projectItem.getName(), appItem.getName(), storageItem.getName()));
});
test('works without set tree item', async () => {
const result = await Storage.del(null);
expect(result).equals(`Storage '${storageItem.getName()}' from Component '${componentItem.getName()}' successfully deleted`);
expect(execStub.getCall(0).args[0]).equals(Command.deleteStorage(storageItem.getName()));
expect(execStub.getCall(1).args[0]).equals(Command.waitForStorageToBeGone(projectItem.getName(), appItem.getName(), storageItem.getName()));
});
test('returns null with no storage selected', async () => {
quickPickStub.onCall(3).resolves();
const result = await Storage.del(null);
expect(result).null;
});
test('returns null when cancelled', async () => {
warnStub.resolves('Cancel');
const result = await Storage.del(null);
expect(result).null;
});
test('wraps odo errors in additional info', async () => {
execStub.rejects(errorMessage);
try {
await Storage.del(storageItem);
expect.fail();
} catch (err) {
expect(err).equals(`Failed to delete Storage with error '${errorMessage}'`);
}
});
});
});