Fix the BalanceTRansactions resource

Author: Tom Hendrikx

mollie/api/objects/balance.py

@@ -68,4 +68,4 @@ def get_report(self, **params: Any) -> BalanceReport:
     def get_transactions(self, **params: Any) -> ObjectList:
         from ..resources import BalanceTransactions
 
-        return BalanceTransactions(self.client, self).list(params=params)
+        return BalanceTransactions(self.client, resource_path=f"balances/{self.id}/transactions").list(params=params)

mollie/api/resources/balances.py

@@ -1,13 +1,10 @@
-from typing import TYPE_CHECKING, Any
+from typing import Any
 
 from mollie.api.objects.balance import Balance
 from mollie.api.objects.balance_report import BalanceReport
 from mollie.api.objects.balance_transaction import BalanceTransaction
 from mollie.api.resources.base import ResourceBase, ResourceGetMixin, ResourceListMixin
 
-if TYPE_CHECKING:
-    from ..client import Client
-
 
 class Balances(ResourceGetMixin, ResourceListMixin):
     RESOURCE_ID_PREFIX: str = "bal_"
@@ -54,16 +51,7 @@ def get_report(self, **params: Any) -> BalanceReport:
 
 
 class BalanceTransactions(ResourceListMixin):
-    _balance: "Balance"
-
-    def __init__(self, client: "Client", balance: "Balance") -> None:
-        self._balance = balance
-        super().__init__(client)
-
     def get_resource_object(self, result: dict) -> BalanceTransaction:
         from ..objects.balance_transaction import BalanceTransaction
 
         return BalanceTransaction(result, self.client)
-
-    def get_resource_path(self) -> str:
-        return f"balances/{self._balance.id}/transactions"

tests/responses/balance_transactions_list.json

@@ -32,10 +32,12 @@
       "type": "text/html"
     },
     "self": {
-      "href": "https://api.mollie.com/v2/balances/bal_gVMhHKqSSRYJyPsuoPNFH/transactions?limit=5",
+      "href": "https://api.mollie.com/v2/balances/bal_gVMhHKqSSRYJyPsuoPNFH/transactions?limit=1",
       "type": "application/hal+json"
     },
     "previous": null,
-    "next": null
+    "next": {
+      "href": "https://api.mollie.com/v2/balances/bal_gVMhHKqSSRYJyPsuoPNFH/transactions?limit=1&from=baltr_QM24QwzUWR4ev4Xfgyt29B"
+    }
   }
-}
+}

tests/responses/balance_transactions_list_more.json

@@ -0,0 +1,41 @@
+{
+  "count": 1,
+  "_embedded": {
+    "balance_transactions": [
+       {
+         "resource": "balance_transaction",
+         "id": "baltr_QM24QwzUWR4ev4Xfgyt29B",
+         "type": "refund",
+         "resultAmount": {
+           "value": "-10.33",
+           "currency": "EUR"
+         },
+         "initialAmount": {
+           "value": "-10.00",
+           "currency": "EUR"
+         },
+         "deductions": {
+           "value": "-0.25",
+           "currency": "EUR"
+         },
+         "createdAt": "2021-01-10T12:06:28+00:00",
+         "context": {
+           "paymentId": "tr_7UhSN1zuXT",
+           "refundId": "re_4qqhO89gsX"
+         }
+       }
+    ]
+  },
+  "_links": {
+    "documentation": {
+      "href": "https://docs.mollie.com/reference/v2/balances-api/list-balance-transactions",
+      "type": "text/html"
+    },
+    "self": {
+      "href": "https://api.mollie.com/v2/balances/bal_gVMhHKqSSRYJyPsuoPNFH/transactions?limit=1&from=baltr_QM24QwzUWR4ev4Xfgyt29B",
+      "type": "application/hal+json"
+    },
+    "previous": null,
+    "next": null
+  }
+}

tests/test_balances.py

@@ -95,6 +95,24 @@ def test_get_balance_transactions(client, response):
     assert balance_transaction.context == {"paymentId": "tr_7UhSN1zuXS", "refundId": "re_4qqhO89gsT"}
 
 
+def test_list_balance_transactions(client, response):
+    """Get a list of balance transactions."""
+    response.get(f"https://api.mollie.com/v2/balances/{BALANCE_ID}", "balance_single")
+    response.get(f"https://api.mollie.com/v2/balances/{BALANCE_ID}/transactions", "balance_transactions_list")
+    response.get(
+        f"https://api.mollie.com/v2/balances/{BALANCE_ID}/transactions?limit=1&from=baltr_QM24QwzUWR4ev4Xfgyt29B",
+        "balance_transactions_list_more",
+    )
+
+    balance = client.balances.get(BALANCE_ID)
+    transactions = balance.get_transactions()
+    assert_list_object(transactions, BalanceTransaction, 1)
+
+    assert transactions.has_next() is True
+    more_transactions = transactions.get_next()
+    assert_list_object(more_transactions, BalanceTransaction, 1)
+
+
 def test_get_balance_invalid_id(client):
     """Test that the balance ID is validated upon retrieving a balance.