feat(NODE-4541): implement legacy callback wrapper library#1
Merged
Conversation
nbbeeken
force-pushed
the
NODE-4520/add-legacy-callback-client
branch
from
9b15144 to
5245172
Compare
nbbeeken
changed the title
nbbeeken
force-pushed
the
NODE-4520/add-legacy-callback-client
branch
3 times, most recently
from
e52a673 to
613ed0f
Compare
baileympearson
requested changes
Aug 18, 2022
Contributor
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
First pass review. Tomorrow I'm going to skim the actual driver wrapper but here are some comments on tests for now
nbbeeken
force-pushed
the
NODE-4520/add-legacy-callback-client
branch
4 times, most recently
from
023a4c4 to
93901eb
Compare
nbbeeken
force-pushed
the
NODE-4520/add-legacy-callback-client
branch
from
93901eb to
0d0558b
Compare
nbbeeken
changed the title
baileympearson
requested changes
Aug 23, 2022
Contributor
baileympearson
left a comment
baileympearson
left a comment
There was a problem hiding this comment.
first round of review done. I cross referenced the api.js to make sure that all methods in api.js are covered and left some general comments. Last part of the review is to go the other way and ensure we're not overridding anything extra. That review will follow.
baileympearson
previously approved these changes
Aug 23, 2022
dariakp
requested changes
Aug 24, 2022
dariakp
requested changes
Aug 25, 2022
baileympearson
previously approved these changes
Aug 25, 2022
baileympearson
previously approved these changes
Aug 25, 2022
dariakp
approved these changes
Aug 25, 2022
baileympearson
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Adds the legacy wrappers for our driver's async APIs.
What is the motivation for this change?
Backwards compat.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>