Use builder defaults for response records and clean up annotations

Replace compact constructors in SuccessResponse and ErrorResponse with
partial builder class declarations to provide proper defaults, and
remove now-redundant .success() and .timestamp() calls from all builder
sites. Use @with for DirectorStatisticsResult.averageRating to match the
pattern in MoviesByYearResult. Expand wildcard lombok import in Movie.

Author: ozgliderpilot

mflix/server/java-spring/src/main/java/com/mongodb/samplemflix/controller/MovieControllerImpl.java

@@ -18,7 +18,6 @@
 import io.swagger.v3.oas.annotations.Parameter;
 import io.swagger.v3.oas.annotations.tags.Tag;
 import jakarta.validation.Valid;
-import java.time.Instant;
 import java.util.List;
 import java.util.Map;
 import org.bson.Document;
@@ -103,10 +102,8 @@ public ResponseEntity<SuccessResponse<List<Movie>>> getAllMovies(
         String message = "Found " + movies.size() + " movies";
 
         SuccessResponse<List<Movie>> response = SuccessResponse.<List<Movie>>builder()
-                .success(true)
                 .message(message)
                 .data(movies)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);
@@ -122,10 +119,8 @@ public ResponseEntity<SuccessResponse<List<String>>> getDistinctGenres() {
         List<String> genres = movieService.getDistinctGenres();
 
         SuccessResponse<List<String>> response = SuccessResponse.<List<String>>builder()
-                .success(true)
                 .message("Found " + genres.size() + " distinct genres")
                 .data(genres)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);
@@ -142,10 +137,8 @@ public ResponseEntity<SuccessResponse<Movie>> getMovieById(
         Movie movie = movieService.getMovieById(id);
 
         SuccessResponse<Movie> response = SuccessResponse.<Movie>builder()
-                .success(true)
                 .message("Movie retrieved successfully")
                 .data(movie)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);
@@ -162,10 +155,8 @@ public ResponseEntity<SuccessResponse<Movie>> createMovie(
         Movie movie = movieService.createMovie(request);
 
         SuccessResponse<Movie> response = SuccessResponse.<Movie>builder()
-                .success(true)
                 .message("Movie '" + request.title() + "' created successfully")
                 .data(movie)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.status(HttpStatus.CREATED).body(response);
@@ -182,10 +173,8 @@ public ResponseEntity<SuccessResponse<BatchInsertResponse>> createMoviesBatch(
         BatchInsertResponse result = movieService.createMoviesBatch(requests);
 
         SuccessResponse<BatchInsertResponse> response = SuccessResponse.<BatchInsertResponse>builder()
-                .success(true)
                 .message("Successfully created " + result.insertedCount() + " movies")
                 .data(result)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.status(HttpStatus.CREATED).body(response);
@@ -210,10 +199,8 @@ public ResponseEntity<SuccessResponse<Movie>> updateMovie(
         Movie movie = movieService.updateMovie(id, request);
 
         SuccessResponse<Movie> response = SuccessResponse.<Movie>builder()
-                .success(true)
                 .message("Movie updated successfully")
                 .data(movie)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);
@@ -235,11 +222,9 @@ public ResponseEntity<SuccessResponse<BatchUpdateResponse>> updateMoviesBatch(
         BatchUpdateResponse result = movieService.updateMoviesBatch(filter, update);
 
         SuccessResponse<BatchUpdateResponse> response = SuccessResponse.<BatchUpdateResponse>builder()
-                .success(true)
                 .message("Update operation completed. Matched " + result.matchedCount() +
                         " documents, modified " + result.modifiedCount() + " documents.")
                 .data(result)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);
@@ -257,10 +242,8 @@ public ResponseEntity<SuccessResponse<Movie>> findAndDeleteMovie(
         Movie movie = movieService.findAndDeleteMovie(id);
 
         SuccessResponse<Movie> response = SuccessResponse.<Movie>builder()
-                .success(true)
                 .message("Movie found and deleted successfully")
                 .data(movie)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);
@@ -277,10 +260,8 @@ public ResponseEntity<SuccessResponse<DeleteResponse>> deleteMovie(
         DeleteResponse result = movieService.deleteMovie(id);
 
         SuccessResponse<DeleteResponse> response = SuccessResponse.<DeleteResponse>builder()
-                .success(true)
                 .message("Movie deleted successfully")
                 .data(result)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);
@@ -301,10 +282,8 @@ public ResponseEntity<SuccessResponse<DeleteResponse>> deleteMoviesBatch(
         DeleteResponse result = movieService.deleteMoviesBatch(filter);
 
         SuccessResponse<DeleteResponse> response = SuccessResponse.<DeleteResponse>builder()
-                .success(true)
                 .message("Delete operation completed. Removed " + result.deletedCount() + " documents.")
                 .data(result)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);
@@ -338,10 +317,8 @@ public ResponseEntity<SuccessResponse<List<MovieWithCommentsResult>>> getMoviesW
 
         SuccessResponse<List<MovieWithCommentsResult>> response =
                 SuccessResponse.<List<MovieWithCommentsResult>>builder()
-                        .success(true)
                         .message(message)
                         .data(results)
-                        .timestamp(Instant.now().toString())
                         .build();
 
         return ResponseEntity.ok(response);
@@ -359,10 +336,8 @@ public ResponseEntity<SuccessResponse<List<MoviesByYearResult>>> getMoviesByYear
 
         SuccessResponse<List<MoviesByYearResult>> response =
                 SuccessResponse.<List<MoviesByYearResult>>builder()
-                        .success(true)
                         .message(String.format("Aggregated statistics for %d years", results.size()))
                         .data(results)
-                        .timestamp(Instant.now().toString())
                         .build();
 
         return ResponseEntity.ok(response);
@@ -382,10 +357,8 @@ public ResponseEntity<SuccessResponse<List<DirectorStatisticsResult>>> getDirect
 
         SuccessResponse<List<DirectorStatisticsResult>> response =
                 SuccessResponse.<List<DirectorStatisticsResult>>builder()
-                        .success(true)
                         .message(String.format("Found %d directors with most movies", results.size()))
                         .data(results)
-                        .timestamp(Instant.now().toString())
                         .build();
 
         return ResponseEntity.ok(response);
@@ -440,10 +413,8 @@ public ResponseEntity<SuccessResponse<SearchMoviesResponse>> searchMovies(
                 .build();
 
         SuccessResponse<SearchMoviesResponse> response = SuccessResponse.<SearchMoviesResponse>builder()
-                .success(true)
                 .message(String.format("Found %d movies matching the search criteria", movies.size()))
                 .data(searchResponse)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);
@@ -465,10 +436,8 @@ public ResponseEntity<SuccessResponse<List<VectorSearchResult>>> vectorSearchMov
         List<VectorSearchResult> results = movieService.vectorSearchMovies(q, limit);
 
         SuccessResponse<List<VectorSearchResult>> response = SuccessResponse.<List<VectorSearchResult>>builder()
-                .success(true)
                 .message(String.format("Found %d similar movies for query: '%s'", results.size(), q))
                 .data(results)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);
@@ -489,10 +458,8 @@ public ResponseEntity<SuccessResponse<List<Movie>>> findSimilarMovies(
         List<Movie> movies = movieService.findSimilarMovies(movieId, limit);
 
         SuccessResponse<List<Movie>> response = SuccessResponse.<List<Movie>>builder()
-                .success(true)
                 .message(String.format("Found %d similar movies", movies.size()))
                 .data(movies)
-                .timestamp(Instant.now().toString())
                 .build();
 
         return ResponseEntity.ok(response);

mflix/server/java-spring/src/main/java/com/mongodb/samplemflix/exception/GlobalExceptionHandler.java

@@ -29,7 +29,6 @@ public ResponseEntity<ErrorResponse> handleResourceNotFoundException(
         logger.error("Resource not found: {}", ex.getMessage());
 
         ErrorResponse errorResponse = ErrorResponse.builder()
-                .success(false)
                 .message(ex.getMessage())
                 .error(ErrorResponse.ErrorDetails.builder()
                         .message(ex.getMessage())
@@ -47,7 +46,6 @@ public ResponseEntity<ErrorResponse> handleValidationException(
         logger.error("Validation error: {}", ex.getMessage());
 
         ErrorResponse errorResponse = ErrorResponse.builder()
-                .success(false)
                 .message("Validation failed")
                 .error(ErrorResponse.ErrorDetails.builder()
                         .message(ex.getMessage())
@@ -67,7 +65,6 @@ public ResponseEntity<ErrorResponse> handleMissingServletRequestParameter(
         String message = String.format("Required parameter '%s' is missing", ex.getParameterName());
 
         ErrorResponse errorResponse = ErrorResponse.builder()
-                .success(false)
                 .message(message)
                 .error(ErrorResponse.ErrorDetails.builder()
                         .message(message)
@@ -85,7 +82,6 @@ public ResponseEntity<ErrorResponse> handleServiceUnavailableException(
         logger.error("Service unavailable: {}", ex.getMessage());
 
         ErrorResponse errorResponse = ErrorResponse.builder()
-                .success(false)
                 .message(ex.getMessage())
                 .error(ErrorResponse.ErrorDetails.builder()
                         .message(ex.getMessage())
@@ -103,7 +99,6 @@ public ResponseEntity<ErrorResponse> handleVoyageAuthException(
         logger.error("Voyage AI authentication error: {}", ex.getMessage());
 
         ErrorResponse errorResponse = ErrorResponse.builder()
-                .success(false)
                 .message(ex.getMessage())
                 .error(ErrorResponse.ErrorDetails.builder()
                         .message(ex.getMessage())
@@ -122,7 +117,6 @@ public ResponseEntity<ErrorResponse> handleVoyageAPIException(
         logger.error("Voyage AI API error: {}", ex.getMessage());
 
         ErrorResponse errorResponse = ErrorResponse.builder()
-                .success(false)
                 .message("Vector search service unavailable")
                 .error(ErrorResponse.ErrorDetails.builder()
                         .message(ex.getMessage())
@@ -140,7 +134,6 @@ public ResponseEntity<ErrorResponse> handleDatabaseOperationException(
         logger.error("Database operation error: {}", ex.getMessage());
 
         ErrorResponse errorResponse = ErrorResponse.builder()
-                .success(false)
                 .message("Database operation failed")
                 .error(ErrorResponse.ErrorDetails.builder()
                         .message(ex.getMessage())
@@ -168,7 +161,6 @@ public ResponseEntity<ErrorResponse> handleMongoWriteException(
         }
 
         ErrorResponse errorResponse = ErrorResponse.builder()
-                .success(false)
                 .message(message)
                 .error(ErrorResponse.ErrorDetails.builder()
                         .message(message)
@@ -187,7 +179,6 @@ public ResponseEntity<ErrorResponse> handleGenericException(
         logger.error("Unexpected error occurred", ex);
 
         ErrorResponse errorResponse = ErrorResponse.builder()
-                .success(false)
                 .message(ex.getMessage() != null ? ex.getMessage() : "Internal server error")
                 .error(ErrorResponse.ErrorDetails.builder()
                         .message(ex.getMessage() != null ? ex.getMessage() : "Internal server error")

mflix/server/java-spring/src/main/java/com/mongodb/samplemflix/model/Movie.java

@@ -3,7 +3,10 @@
 import com.fasterxml.jackson.annotation.JsonProperty;
 import java.util.Date;
 import java.util.List;
-import lombok.*;
+import lombok.Builder;
+import lombok.EqualsAndHashCode;
+import lombok.Getter;
+import lombok.Setter;
 import org.bson.types.ObjectId;
 import org.springframework.data.annotation.Id;
 import org.springframework.data.mongodb.core.mapping.Document;

mflix/server/java-spring/src/main/java/com/mongodb/samplemflix/model/dto/DirectorStatisticsResult.java

@@ -2,6 +2,7 @@
 
 import com.fasterxml.jackson.annotation.JsonInclude;
 import lombok.Builder;
+import lombok.With;
 
 /**
  * DTO for director statistics aggregation result.
@@ -25,5 +26,6 @@ public record DirectorStatisticsResult (
     /**
      * Average IMDB rating of this director's movies.
      */
+    @With
     Double averageRating) {}
 

mflix/server/java-spring/src/main/java/com/mongodb/samplemflix/model/response/ErrorResponse.java

@@ -44,9 +44,10 @@ public record ErrorResponse (
      */
     String timestamp) implements ApiResponse {
 
-    public ErrorResponse {
-        success = false;
-        timestamp = Instant.now().toString();
+    // Partial builder declaration to provide defaults for records (like @Builder.Default for classes)
+    public static class ErrorResponseBuilder {
+        private boolean success = false;
+        private String timestamp = Instant.now().toString();
     }
 
     @Override

mflix/server/java-spring/src/main/java/com/mongodb/samplemflix/model/response/SuccessResponse.java

@@ -47,9 +47,10 @@ public record SuccessResponse<T> (
      */
     Pagination pagination) implements ApiResponse {
 
-    public SuccessResponse {
-        success = true;
-        timestamp = Instant.now().toString();
+    // Partial builder declaration to provide defaults for records (like @Builder.Default for classes)
+    public static class SuccessResponseBuilder<T> {
+        private boolean success = true;
+        private String timestamp = Instant.now().toString();
     }
 
     @Override

mflix/server/java-spring/src/main/java/com/mongodb/samplemflix/service/MovieServiceImpl.java

@@ -548,11 +548,7 @@ public List<DirectorStatisticsResult> getDirectorsWithMostMovies(Integer limit)
         return results.getMappedResults().stream()
                 .map(result -> {
                     if (result.averageRating() != null) {
-                        return new DirectorStatisticsResult(
-                                result.director(),
-                                result.movieCount(),
-                                Math.round(result.averageRating() * 100.0) / 100.0
-                        );
+                        return result.withAverageRating(Math.round(result.averageRating() * 100.0) / 100.0);
                     }
                     return result;
                 })