Skip to content

Commit abda9be

Browse files
committed
Update to Express 5 and fix breaking changes
1 parent a5563d3 commit abda9be

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

mflix/server/js-express/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929
},
3030
"devDependencies": {
3131
"@types/cors": "^2.8.19",
32-
"@types/express": "^4.17.25",
32+
"@types/express": "^5.0.6",
3333
"@types/jest": "^30.0.0",
34-
"@types/node": "^25.2.1",
34+
"@types/node": "^25.2.2",
3535
"@types/supertest": "^6.0.3",
3636
"@types/swagger-jsdoc": "^6.0.4",
3737
"@types/swagger-ui-express": "^4.1.8",

mflix/server/js-express/src/controllers/movieController.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -172,8 +172,8 @@ export async function getDistinctGenres(
172172
export async function getMovieById(req: Request, res: Response): Promise<void> {
173173
const { id } = req.params;
174174

175-
// Validate ObjectId format
176-
if (!ObjectId.isValid(id)) {
175+
// Validate id is a string and ObjectId format
176+
if (typeof id !== "string" || !ObjectId.isValid(id)) {
177177
res
178178
.status(400)
179179
.json(
@@ -305,8 +305,8 @@ export async function updateMovie(req: Request, res: Response): Promise<void> {
305305
const { id } = req.params;
306306
const updateData: UpdateMovieRequest = req.body;
307307

308-
// Validate ObjectId format
309-
if (!ObjectId.isValid(id)) {
308+
// Validate id is a string and ObjectId format
309+
if (typeof id !== "string" || !ObjectId.isValid(id)) {
310310
res
311311
.status(400)
312312
.json(
@@ -426,8 +426,8 @@ export async function updateMoviesBatch(
426426
export async function deleteMovie(req: Request, res: Response): Promise<void> {
427427
const { id } = req.params;
428428

429-
// Validate ObjectId format
430-
if (!ObjectId.isValid(id)) {
429+
// Validate id is a string and ObjectId format
430+
if (typeof id !== "string" || !ObjectId.isValid(id)) {
431431
res
432432
.status(400)
433433
.json(
@@ -521,8 +521,8 @@ export async function findAndDeleteMovie(
521521
): Promise<void> {
522522
const { id } = req.params;
523523

524-
// Validate ObjectId format
525-
if (!ObjectId.isValid(id)) {
524+
// Validate id is a string and ObjectId format
525+
if (typeof id !== "string" || !ObjectId.isValid(id)) {
526526
res
527527
.status(400)
528528
.json(

0 commit comments

Comments
 (0)