Add READMEs and cleanup by jordan-smith721 · Pull Request #33 · mongodb/docs-sample-apps

jordan-smith721 · 2025-11-07T17:00:00Z

This PR does the following:

Adds a README for the js-express backend and updates the Java README
Updates the numCandidates parameter for Vector Search to be limit * 20 (as recommended in our docs)
Updates the FastAPI server to adjust for camel case parameters being sent from the client
Removes references to Atlas Search and Atlas Vector Search in favor of rename
Updates .env example files so that they are standardized across backends

dacharyc

Back to you for some minor fixups but overall LGTM!

dacharyc · 2025-11-07T17:26:00Z

-[open an issue](https://github.com/mongodb/docs-sample-apps/issues/new/choose)
-on the source repository `mongodb/docs-sample-apps`.
+[open an issue](https://github.com/mongodb/sample-app-java-mflix/issues/new/choose)
+on the source repository `mongodb/sample-app-java-mflix`.


Nope, this was actually correct. We have disabled Issues on the artifact repos and want people to create issues directly on the source repo so we only have one place to watch instead of three of them.

Suggested change

on the source repository `mongodb/sample-app-java-mflix`.

on the source repository `mongodb/docs-sample-apps`.

Ah good to know, I thought we were keeping the source repo separated. Changed back

dacharyc · 2025-11-07T17:29:07Z

-├── README.md
-├── client/     # Next.js frontend
-└── server/     # Express.js backend
+├── README-JAVASCRIPT-EXPRESS.md


As this is the public-facing project, the README will be renamed by the copy tool to just README.md in the artifact repo.

Suggested change

├── README-JAVASCRIPT-EXPRESS.md

├── README.md

dacharyc · 2025-11-07T17:30:04Z

+```env
+# MongoDB Configuration
+# Replace with your MongoDB Atlas connection string
+MONGODB_URI=mongodb+srv://<username>:<password>@<cluster>.mongodb.net/sample_mflix?retryWrites=true&w=majority


I added the Voyage API key to the Python and Java .env.example files when I moved them - we should probably do this for JS too and update this README to match.

dacharyc · 2025-11-07T17:30:45Z

+
+From the `server/js-express` directory, run:
+
+```bash


I recommend making these separate bash blocks so users can just execute them in their IDE if they want to.

dacharyc · 2025-11-07T17:31:13Z

-[open an issue](https://github.com/mongodb/docs-sample-apps/issues/new/choose)
-on the source repository `mongodb/docs-sample-apps`.
+[open an issue](https://github.com/mongodb/sample-app-nodejs-mflix/issues/new/choose)
+on the source repository `mongodb/sample-app-nodejs-mflix`.


Suggested change

on the source repository `mongodb/sample-app-nodejs-mflix`.

on the source repository `mongodb/docs-sample-apps`.

dacharyc · 2025-11-07T17:31:47Z

 If you have verified the above and still have issues, please
-[open an issue](https://github.com/mongodb/docs-sample-apps/issues/new/choose)
-on the source repository `mongodb/docs-sample-apps`.
+[open an issue](https://github.com/mongodb/sample-app-nodejs-mflix/issues/new/choose)


Suggested change

[open an issue](https://github.com/mongodb/sample-app-nodejs-mflix/issues/new/choose)

[open an issue](https://github.com/mongodb/docs-sample-apps/issues/new/choose)

dacharyc · 2025-11-07T17:32:54Z

 If you have verified the above and still have issues, please
-[open an issue](https://github.com/mongodb/docs-sample-apps/issues/new/choose)
-on the source repository `mongodb/docs-sample-apps`.
+[open an issue](https://github.com/mongodb/sample-app-java-mflix/issues/new/choose)


Suggested change

[open an issue](https://github.com/mongodb/sample-app-java-mflix/issues/new/choose)

[open an issue](https://github.com/mongodb/docs-sample-apps/issues/new/choose)

dacharyc · 2025-11-07T17:36:20Z

 ```bash
 # Run all integration tests
-./mvnw test -Dtest=AtlasSearchIntegrationTest
+./mvnw test -Dtest=MongoDBSearchIntegrationTest


If we're changing this command, we need to change the corresponding test files.

The files were already changed as far as I can see on my branch

dacharyc · 2025-11-07T17:36:30Z


 # Run a specific test
-./mvnw test -Dtest=AtlasSearchIntegrationTest#testSearchMoviesByPlot_Success
+./mvnw test -Dtest=MongoDBSearchIntegrationTest#testSearchMoviesByPlot_Success


dacharyc · 2025-11-07T17:37:05Z

    "dotenv": "^17.2.3",
    "express": "^5.1.0",
-    "mongodb": "^6.20.0",
+    "mongodb": "^7.0.0",


Awesome! 🎉

dacharyc · 2025-11-07T18:06:13Z

-└── server/     # Express.js backend
+├── README-JAVASCRIPT-EXPRESS.md
+├── client/                 # Next.js frontend (TypeScript)
+└── server/js-express/      # Express.js backend


Oops, missed this - the copier tool will rename this to just server in the artifact repo.

Suggested change

└── server/js-express/ # Express.js backend

└── server/ # Express.js backend

dacharyc · 2025-11-07T18:06:42Z

+
+### 2. Install Backend Dependencies
+
+From the `server/js-express` directory, run:


Suggested change

From the `server/js-express` directory, run:

From the `server/` directory, run:

dacharyc · 2025-11-07T18:06:53Z

+
+### 3. Start the Backend Server
+
+From the `server/js-express` directory, run:


Suggested change

From the `server/js-express` directory, run:

From the `server/` directory, run:

dacharyc · 2025-11-07T18:07:07Z

+Navigate to the Express server directory:
+
+```bash
+cd server/js-express


Suggested change

cd server/js-express

cd server/

dacharyc

LGTM! ✅

cleanup and READMEs

5cda8e2

jordan-smith721 temporarily deployed to testing November 7, 2025 17:00 — with GitHub Actions Inactive

sync env examples and add voyage dependency to readmes

b9cecb8

jordan-smith721 temporarily deployed to testing November 7, 2025 17:20 — with GitHub Actions Inactive

dacharyc requested changes Nov 7, 2025

View reviewed changes

dacharyc reviewed Nov 7, 2025

View reviewed changes

Dachary feedback

be79f27

jordan-smith721 had a problem deploying to testing November 7, 2025 18:16 — with GitHub Actions Failure

Dachary feedback

30de09e

jordan-smith721 temporarily deployed to testing November 7, 2025 18:17 — with GitHub Actions Inactive

jordan-smith721 requested a review from dacharyc November 7, 2025 18:18

dacharyc approved these changes Nov 7, 2025

View reviewed changes

Merge branch 'development' into cleanup2

251250b

dacharyc had a problem deploying to testing November 7, 2025 18:33 — with GitHub Actions Failure

dacharyc temporarily deployed to testing November 7, 2025 18:33 — with GitHub Actions Inactive

dacharyc merged commit 2f9ea16 into mongodb:development Nov 7, 2025
1 of 3 checks passed

This was referenced Apr 2, 2026

fix(python-fastapi): bump aiohttp for CVE-2026-34525 (GHSA-c427-h43c-vf67) #93

Merged

fix(python-fastapi): bump aiohttp for CVE-2026-34525 (GHSA-c427-h43c-vf67) #94

Merged

	on the source repository `mongodb/sample-app-java-mflix`.
	on the source repository `mongodb/docs-sample-apps`.

	[open an issue](https://github.com/mongodb/sample-app-nodejs-mflix/issues/new/choose)
	[open an issue](https://github.com/mongodb/docs-sample-apps/issues/new/choose)

	└── server/js-express/ # Express.js backend
	└── server/ # Express.js backend


		### 2. Install Backend Dependencies

		From the `server/js-express` directory, run:

	From the `server/js-express` directory, run:
	From the `server/` directory, run:


		### 3. Start the Backend Server

		From the `server/js-express` directory, run:

Conversation

jordan-smith721 commented Nov 7, 2025

Uh oh!

dacharyc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dacharyc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants