TOOLS-4102 Use mise to execute go as well as other dev tools

This gets rid of the Go code to install dev tools entirely, and updates all the places we call these tools to use `mise exec`.

Author: autarch

build.go

@@ -45,14 +45,12 @@ func init() {
 		Do(buildscript.WriteThirdPartyNotices)
 
 	// Static Analysis
-	taskRegistry.Declare("sa:installdevtools").
-		Description("installs dev tools").
-		Do(buildscript.SAInstallDevTools)
 	taskRegistry.Declare("sa:lint").
 		Description("runs precious linting").
-		DependsOn("sa:installdevtools").
 		Do(buildscript.SAPreciousLint)
-	taskRegistry.Declare("sa:modtidy").Description("runs go mod tidy").Do(buildscript.SAModTidy)
+	taskRegistry.Declare("sa:modtidy").
+		Description("runs go mod tidy").
+		Do(buildscript.SAModTidy)
 	taskRegistry.Declare("sa:evgvalidate").
 		Description("runs evergreen validate").
 		Do(buildscript.SAEvergreenValidate)

buildscript/sa.go

@@ -4,339 +4,21 @@ import (
 	"bytes"
 	"errors"
 	"fmt"
-	"io"
 	"os"
 	"os/exec"
-	"path/filepath"
-	"runtime"
 	"strings"
 
 	"github.com/craiggwilson/goke/pkg/sh"
 	"github.com/craiggwilson/goke/task"
 )
 
-const (
-	goimportsVersion = "v0.29.0"
-	goimportsPkg     = "golang.org/x/tools/cmd/goimports@" + goimportsVersion
-
-	// For JS tools like eslint and prettier, these versions need to match the ones in the
-	// `package.json` file. To update to a new version, run a command like this:
-	//
-	//    npm install --save-dev --save-exact prettier@3.3.1
-	//
-	// Then update the version in this file as well.
-
-	// This is the latest version to support a YAML config file. Updating to
-	// the new config file syntax did not seem trivial.
-	eslintVersion           = "8.57.0"
-	gitHubCodeownersVersion = "0.2.1"
-	golangCILintVersion     = "2.6.2"
-	golinesVersion          = "0.12.2" // 0.13.0 fails w/ libc errors
-	gosecVersion            = "2.22.10"
-	preciousVersion         = "0.10.1"
-	ubiVersion              = "0.8.4"
-	prettierVersion         = "3.6.2"
-)
-
-func SAInstallDevTools(ctx *task.Context) error {
-	if err := installUBI(ctx); err != nil {
-		return err
-	}
-	if err := installGoimports(ctx); err != nil {
-		return err
-	}
-	if err := installGolangCILint(ctx); err != nil {
-		return err
-	}
-	if err := installGolines(ctx); err != nil {
-		return err
-	}
-	if err := installGosec(ctx); err != nil {
-		return err
-	}
-	if err := installPrecious(ctx); err != nil {
-		return err
-	}
-	return installJSTools(ctx)
-}
-
-// Install goimports.
-func installGoimports(ctx *task.Context) error {
-	return goInstall(ctx, goimportsPkg)
-}
-
-// Install UBI.
-func installUBI(ctx *task.Context) error {
-	var err error
-	devBin, err := devBinDir()
-	if err != nil {
-		return err
-	}
-
-	ubi, err := devBinFile("ubi")
-	if err != nil {
-		return err
-	}
-
-	exists, err := executableExistsWithVersion(ctx, ubi, ubiVersion)
-	if err != nil {
-		return err
-	}
-	if exists {
-		return nil
-	}
-
-	var ubiBootstrapURL string
-	switch runtime.GOOS {
-	case "windows":
-		ubiBootstrapURL = "https://raw.githubusercontent.com/houseabsolute/ubi/ci-for-bootstrap/bootstrap/bootstrap-ubi.ps1"
-	default:
-		ubiBootstrapURL = fmt.Sprintf(
-			"https://raw.githubusercontent.com/houseabsolute/ubi/v%s/bootstrap/bootstrap-ubi.sh",
-			ubiVersion,
-		)
-	}
-
-	s := strings.Split(ubiBootstrapURL, "/")
-	bootstrapPath := filepath.Join(os.TempDir(), s[len(s)-1])
-
-	out, err := os.Create(bootstrapPath)
-	if err != nil {
-		return err
-	}
-	defer out.Close()
-
-	resp, err := httpGetWithRetries(ubiBootstrapURL, 5)
-	if err != nil {
-		return err
-	}
-	defer resp.Body.Close()
-
-	_, err = io.Copy(out, resp.Body)
-	if err != nil {
-		return err
-	}
-
-	var cmd []string
-	if strings.HasSuffix(ubiBootstrapURL, ".ps1") {
-		cmd = []string{"powershell", bootstrapPath}
-	} else {
-		cmd = []string{"sh", bootstrapPath}
-	}
-
-	// On Windows the bootstrapper always installs into the current directory,
-	// so chdir there first.
-	return doInDir(devBin, func() error {
-		c := exec.CommandContext(ctx, cmd[0], cmd[1:]...)
-		c.Env = []string{"TARGET=" + devBin, "TAG=v" + ubiVersion}
-		return sh.RunCmd(ctx, c)
-	})
-}
-
-// Install golangci-lint.
-func installGolangCILint(ctx *task.Context) error {
-	return installBinaryTool(
-		ctx,
-		"golangci-lint",
-		golangCILintVersion,
-		"golangci/golangci-lint",
-		fmt.Sprintf(
-			"https://github.com/golangci/golangci-lint/releases/download/v%s/golangci-lint-%s-linux-amd64.tar.gz",
-			golangCILintVersion,
-			golangCILintVersion,
-		),
-	)
-}
-
-// Install golines.
-func installGolines(ctx *task.Context) error {
-	return installBinaryTool(
-		ctx,
-		"golines",
-		golinesVersion,
-		"segmentio/golines",
-		fmt.Sprintf(
-			"https://github.com/segmentio/golines/releases/download/v%s/golines_%s_linux_amd64.tar.gz",
-			golinesVersion,
-			golinesVersion,
-		),
-	)
-}
-
-// Install gosec.
-func installGosec(ctx *task.Context) error {
-	return installBinaryTool(
-		ctx,
-		"gosec",
-		gosecVersion,
-		"securego/gosec",
-		fmt.Sprintf(
-			"https://github.com/securego/gosec/releases/download/v%s/gosec_%s_linux_amd64.tar.gz",
-			gosecVersion,
-			gosecVersion,
-		),
-	)
-}
-
-func installPrecious(ctx *task.Context) error {
-	return installBinaryTool(
-		ctx,
-		"precious",
-		preciousVersion,
-		"houseabsolute/precious",
-		fmt.Sprintf(
-			"https://github.com/houseabsolute/precious/releases/download/v%s/precious-Linux-musl-x86_64.tar.gz",
-			preciousVersion,
-		),
-	)
-}
-
-// Install a Golang package as an executable with "go install".
-func goInstall(ctx *task.Context, link string) error {
-	root, err := repoRoot()
-	if err != nil {
-		return err
-	}
-	if err = os.Setenv("GOBIN", filepath.Join(root, "dev-bin")); err != nil {
-		return err
-	}
-
-	return withRetries(
-		5,
-		fmt.Sprintf("go install %s", link),
-		func() error {
-			return sh.Run(ctx, "go", "install", link)
-		},
-	)
-}
-
-func installBinaryTool(
-	ctx *task.Context,
-	exeName, toolVersion, githubProject, downloadURLForCI string,
-) error {
-	devBin, err := devBinDir()
-	if err != nil {
-		return err
-	}
-
-	devBinExe, err := devBinFile(exeName)
-	if err != nil {
-		return err
-	}
-
-	exists, err := executableExistsWithVersion(ctx, devBinExe, toolVersion)
-	if err != nil {
-		return err
-	}
-	if exists {
-		return nil
-	}
-
-	cmd := []string{
-		filepath.Join(devBin, "ubi"),
-		"--in", devBin,
-	}
-	if inCI() {
-		// Using the `--url` arg avoids hitting the GitHub API, but it skips
-		// all the platform detection ubi provides. We do it this way because
-		// even with authentication, the limits on the GitHub API are
-		// something like 5,000 requests an hour. Without it, the limit is way
-		// lower.
-		//
-		// This seemed simpler than adding a GitHub token to Evergreen. If we
-		// ever switch to GH Actions we can reconsider, since in that case
-		// we'd have a token automatically available in the `GITHUB_TOKEN` env
-		// var.
-		cmd = append(cmd, "--url", downloadURLForCI)
-	} else {
-		cmd = append(
-			cmd,
-			"--project", githubProject,
-			"--tag", "v"+toolVersion,
-		)
-	}
-
-	return withRetries(
-		5,
-		fmt.Sprintf("installing %s", exeName),
-		func() error {
-			return sh.Run(ctx, cmd[0], cmd[1:]...)
-		},
-	)
-}
-
-// We have to install all the JS tools at once. If we run `npm install <tool>` multiple times, each
-// execution wipes the entire `node_modules` directory, so we only end up with one tool (the last
-// one) installed.
-func installJSTools(ctx *task.Context) error {
-	eslint, err := npmPath("eslint")
-	if err != nil {
-		return err
-	}
-
-	prettier, err := npmPath("prettier")
-	if err != nil {
-		return err
-	}
-
-	for _, tool := range [][]string{
-		{eslint, eslintVersion},
-		{prettier, prettierVersion},
-	} {
-		exists, err := executableExistsWithVersion(ctx, tool[0], tool[1])
-		if err != nil {
-			return err
-		}
-		if !exists {
-			return runNPMInstall(ctx)
-		}
-	}
-
-	gitHubCodeowners, err := npmPath("github-codeowners")
-	if err != nil {
-		return err
-	}
-
-	// This program doesn't have any way to print its version. :(
-	exists, err := fileExists(gitHubCodeowners)
-	if err != nil {
-		return err
-	}
-	if !exists {
-		return runNPMInstall(ctx)
-	}
-
-	return nil
-}
-
-func runNPMInstall(ctx *task.Context) error {
-	return sh.Run(
-		ctx,
-		"npm", "install",
-	)
-}
-
-func npmPath(exe string) (string, error) {
-	root, err := repoRoot()
-	if err != nil {
-		return "", err
-	}
-
-	return filepath.Join(root, "node_modules", ".bin", exe), nil
-}
-
 func SAPreciousLint(ctx *task.Context) error {
 	return runPrecious(ctx, "lint", "--all")
 }
 
 func runPrecious(ctx *task.Context, args ...string) error {
-	devBin, err := devBinDir()
-	if err != nil {
-		return err
-	}
-
 	cmd := append(
-		[]string{filepath.Join(devBin, "precious")},
+		[]string{"mise", "exec", "github:houseabsolute/precious", "--", "precious"},
 		args...,
 	)