This repository was archived by the owner on Jan 23, 2019. It is now read-only.
Do not assume query is present in response.#72
Closed
rwjblue wants to merge 1 commit intomonkeecreate:masterfrom
Closed
Do not assume query is present in response.#72rwjblue wants to merge 1 commit intomonkeecreate:masterfrom
query is present in response.#72rwjblue wants to merge 1 commit intomonkeecreate:masterfrom
Conversation
The Yahoo simple weather API returns an error when searching for "Ponoka, AB".
The returned JSON is:
```javascript
{"error":{"lang":"en-US","diagnostics":null,"description":"No definition found for Table weather.search"}}
```
This causes `simpleWeather` to error since it assumes that the results
contain a `query` key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Yahoo simple weather API returns an error when searching for "Ponoka, AB".
The returned JSON is:
This causes
simpleWeatherto error since it assumes that the results containa
querykey.I am unsure how you generally update the minified output as I didn't see a build script in the repo.