Non-invasive solution for #138 covered with mocha:spec#139
Merged
oesmith merged 2 commits intomorrisjs:masterfrom Dec 20, 2012
Merged
Non-invasive solution for #138 covered with mocha:spec#139oesmith merged 2 commits intomorrisjs:masterfrom
oesmith merged 2 commits intomorrisjs:masterfrom
Conversation
|
Awesome, that's exactly what I was after! Hope to see this merged soon :) |
Contributor
|
Merged! 👍 I've removed the prefix and suffix options from the formatter callback -- there's little point in pushing user-supplied data back in the callback arguments when it can be whatever the user wants within the callback itself! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution for #138. What's best (and I hope you're happy to see it) I have included a unit test and will try to make it a habit when sending PRs.
Usage: Provide
options.yLabelFormatcallback acceptingoriginal label,prefix, andsuffixand return a formatted label. By default, the body ofMorris.Grid.yLabelFormatis put there.Cheers!