Allow Donut to handle PHP json_encode output#189
Closed
mpettitt wants to merge 1 commit intomorrisjs:masterfrom
Closed
Allow Donut to handle PHP json_encode output#189mpettitt wants to merge 1 commit intomorrisjs:masterfrom
mpettitt wants to merge 1 commit intomorrisjs:masterfrom
Conversation
Currently, Morris.Donut produces a chart with a load of tiny little bars on the bottom right of donut charts generated from data straight from PHP's json_encode function. The other chart types don't do this, because they parse the values into Int/Float values. This change adds "parseFloat" to the line of the Donut code which reads the x.value, which brings it into line with the other chart methods, and makes json_encode output work as expected It also has a longer commit summary than the amount of code added...
Contributor
|
I can't merge this because you've modified the compiled javascript rather than the original coffeescript. However, I've ported the fix back to the coffeescript and it's on master now. Thanks! |
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Morris.Donut produces a chart with a load of tiny little bars on the bottom right of donut charts generated from data straight from PHP's json_encode function.
The other chart types don't do this, because they parse the values into Int/Float values.
This change adds "parseFloat" to the line of the Donut code which reads the x.value, which brings it into line with the other chart methods, and makes json_encode output work as expected
It also has a longer commit summary than the amount of code added...