Pulled the map function up to resolve issue with nulls in coordinate lists#65
Merged
oesmith merged 2 commits intomorrisjs:masterfrom Jun 26, 2012
dump247:master
Merged
Pulled the map function up to resolve issue with nulls in coordinate lists#65oesmith merged 2 commits intomorrisjs:masterfrom dump247:master
oesmith merged 2 commits intomorrisjs:masterfrom
dump247:master
Conversation
createPath fails if the list contains 0 or 1 coordinate and multiples nulls
Contributor
|
Thanks! I've merged and released this in 0.2.10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to createPath in drawSeries fails if the coordinate list contains 0 or 1 coordinate and multiple nulls. I pulled the map function out of createPath and into drawSeries to filter nulls before the call to createPath so createPath is only called if the coordinate list has at least 2 real coordinates.