fix: make setup() in callBackPersistence async (#106)

* fix: make callback setup() async

* add test to verify that .setup() is async

Author: seriousme

abstract.js

@@ -173,6 +173,12 @@ function abstractPersistence (opts) {
   }
 
   // testing starts here
+  test('verify setup() method is async', async t => {
+    t.plan(1)
+    const prInstance = await persistence(t)
+    t.assert.equal(prInstance.setup.constructor.name, 'AsyncFunction', '.setup() must be an async function')
+  })
+
   test('store and look up retained messages', async t => {
     t.plan(1)
     await matchRetainedWithPattern(t, 'hello/world')

callBackPersistence.js

@@ -17,10 +17,6 @@ class CallBackPersistence extends EventEmitter {
   }
 
   set broker (broker) {
-    this.setup(broker)
-  }
-
-  setup (broker) {
     if (this.ready) {
       return
     }
@@ -35,6 +31,10 @@ class CallBackPersistence extends EventEmitter {
       })
   }
 
+  async setup (broker) {
+    return this.asyncPersistence.setup(broker)
+  }
+
   subscriptionsByTopic (topic, cb) {
     if (cb) {
       if (!this.ready) {