Skip to content

Commit 46d9b79

Browse files
chore(email-first): Remove email-first related experiment code
1 parent 9a6c142 commit 46d9b79

11 files changed

Lines changed: 61 additions & 462 deletions

File tree

packages/fxa-content-server/app/scripts/lib/experiment.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ const STARTUP_EXPERIMENTS = {};
2020
* after the app has started.
2121
*/
2222
const MANUAL_EXPERIMENTS = {
23-
emailFirst: BaseExperiment,
2423
// For now, the send SMS experiment only needs to log "enrolled", so
2524
// no special experiment is created.
2625
signupCode: BaseExperiment,

packages/fxa-content-server/app/scripts/lib/experiments/grouping-rules/email-first.js

Lines changed: 0 additions & 46 deletions
This file was deleted.

packages/fxa-content-server/app/scripts/lib/experiments/grouping-rules/index.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ const _ = require('underscore');
1313
const experimentGroupingRules = [
1414
require('./communication-prefs'),
1515
require('./cwts-on-signup-password'),
16-
require('./email-first'),
1716
require('./is-sampled-user'),
1817
require('./send-sms-install-link'),
1918
require('./sentry'),

packages/fxa-content-server/app/scripts/views/index.js

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import AuthErrors from '../lib/auth-errors';
1212
import CachedCredentialsMixin from './mixins/cached-credentials-mixin';
1313
import Cocktail from 'cocktail';
1414
import CoppaMixin from './mixins/coppa-mixin';
15-
import EmailFirstExperimentMixin from './mixins/email-first-experiment-mixin';
1615
import FirefoxFamilyServicesTemplate from '../templates/partial/firefox-family-services.mustache';
1716
import TokenCodeExperimentMixin from './mixins/token-code-experiment-mixin';
1817
import FlowBeginMixin from './mixins/flow-begin-mixin';
@@ -69,19 +68,14 @@ class IndexView extends FormView {
6968

7069
if (isLegacySigninSignupDisabled && action !== 'force_auth') {
7170
return this.chooseEmailActionPage();
72-
}
73-
74-
if (action && action !== 'email') {
71+
} else if (action === 'force_auth') {
7572
this.replaceCurrentPage(action);
76-
} else if (
77-
this.isInEmailFirstExperimentGroup('treatment') ||
78-
action === 'email'
79-
) {
73+
} else if (action) {
8074
return this.chooseEmailActionPage();
8175
} else if (this.getSignedInAccount().get('sessionToken')) {
8276
this.replaceCurrentPage('settings');
8377
} else {
84-
this.replaceCurrentPage('signup');
78+
return this.chooseEmailActionPage();
8579
}
8680
}
8781

@@ -228,7 +222,6 @@ Cocktail.mixin(
228222
IndexView,
229223
CachedCredentialsMixin,
230224
CoppaMixin({}),
231-
EmailFirstExperimentMixin(),
232225
TokenCodeExperimentMixin,
233226
FlowBeginMixin,
234227
FormPrefillMixin,

packages/fxa-content-server/app/scripts/views/mixins/email-first-experiment-mixin.js

Lines changed: 0 additions & 94 deletions
This file was deleted.

packages/fxa-content-server/app/tests/spec/lib/experiments/grouping-rules/email-first.js

Lines changed: 0 additions & 48 deletions
This file was deleted.

packages/fxa-content-server/app/tests/spec/lib/experiments/grouping-rules/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import sinon from 'sinon';
99

1010
describe('lib/experiments/grouping-rules/index', () => {
1111
it('EXPERIMENT_NAMES is exported', () => {
12-
assert.lengthOf(ExperimentGroupingRules.EXPERIMENT_NAMES, 8);
12+
assert.lengthOf(ExperimentGroupingRules.EXPERIMENT_NAMES, 7);
1313
});
1414

1515
describe('choose', () => {

0 commit comments

Comments
 (0)