refactor(charts): rename to isFullCircle and compute for all rotation axes

Address review feedback: rename the flag to `isFullCircle` and compute it
for every rotation axis (point/band/continuous), not only the point-scale
branch. Wire the flag through to `ChartsRadiusGrid` as a prop so it drops
its local `EPSILON`-based derivation. The point-scale shortening keeps its
existing `2π - 0.1` threshold as a local decision.

Author: Anexus5919

packages/x-charts/src/ChartsRadialGrid/ChartsRadialGrid.tsx

@@ -66,9 +66,8 @@ function ChartsRadialGrid(inProps: ChartsRadialGridProps) {
   const outerRadius = radiusAxisConfig?.scale.range()[1] ?? 0;
 
   const startAngle = rotationAxisConfig?.scale.range()[0] ?? 0;
-  const endAngle = rotationAxisConfig?.isPointScaleFullCircle
-    ? startAngle + 2 * Math.PI
-    : (rotationAxisConfig?.scale.range()[1] ?? 0);
+  const endAngle = rotationAxisConfig?.scale.range()[1] ?? 0;
+  const isFullCircle = rotationAxisConfig?.isFullCircle ?? false;
 
   return (
     <GridRoot {...other} className={clsx(classes.root, className)}>
@@ -86,6 +85,7 @@ function ChartsRadialGrid(inProps: ChartsRadialGridProps) {
           axis={radiusAxisConfig}
           startAngle={startAngle}
           endAngle={endAngle}
+          isFullCircle={isFullCircle}
           classes={classes}
         />
       )}

packages/x-charts/src/ChartsRadialGrid/ChartsRadiusGrid.tsx

@@ -8,12 +8,12 @@ import {
   type UseChartPolarAxisSignature,
 } from '../internals/plugins/featurePlugins/useChartPolarAxis';
 import { type PolarAxisDefaultized } from '../models/axis';
-import { EPSILON } from '../utils/epsilon';
 
 interface ChartsRadiusGridProps {
   axis: PolarAxisDefaultized<any, any, any>;
   startAngle: number;
   endAngle: number;
+  isFullCircle: boolean;
   classes: Partial<ChartsRadialGridClasses>;
 }
 
@@ -22,7 +22,7 @@ interface ChartsRadiusGridProps {
  */
 export function ChartsRadiusGrid(props: ChartsRadiusGridProps) {
   const { store } = useChartsContext<[UseChartPolarAxisSignature]>();
-  const { axis, startAngle, endAngle, classes } = props;
+  const { axis, startAngle, endAngle, isFullCircle, classes } = props;
   const { cx, cy } = store.use(selectorChartPolarCenter);
 
   const { scale, tickNumber, tickInterval, tickSpacing } = axis;
@@ -35,8 +35,6 @@ export function ChartsRadiusGrid(props: ChartsRadiusGridProps) {
     direction: 'radius',
   });
 
-  const isFullCircle = Math.abs(endAngle - startAngle) >= 2 * Math.PI - EPSILON;
-
   if (isFullCircle) {
     return (
       <React.Fragment>

packages/x-charts/src/internals/plugins/featurePlugins/useChartPolarAxis/computeAxisValue.ts

@@ -26,6 +26,7 @@ import { deg2rad } from '../../../angleConversion';
 import { getAxisTriggerTooltip } from './getAxisTriggerTooltip';
 import { scaleBand, scalePoint } from '../../../scales';
 import { type ComputedAxisConfig } from '../useChartCartesianAxis';
+import { EPSILON } from '../../../../utils/epsilon';
 
 export type DefaultizedAxisConfig<
   AxisProps extends ChartsRotationAxisProps | ChartsRadiusAxisProps,
@@ -40,36 +41,27 @@ function getRange(
   drawingArea: ChartDrawingArea,
   axisDirection: 'rotation' | 'radius',
   axis: PolarAxisConfig<ScaleName, any>,
-): { range: number[]; isPointScaleFullCircle: boolean } {
+): { range: number[]; isFullCircle: boolean } {
   if (axisDirection === 'rotation') {
-    if (axis.scaleType === 'point') {
-      const angles = [
-        deg2rad((axis as RotationConfig).startAngle, 0),
-        deg2rad((axis as RotationConfig).endAngle, 2 * Math.PI),
-      ];
-      const diff = angles[1] - angles[0];
-      const isPointScaleFullCircle = diff > Math.PI * 2 - 0.1;
-      if (isPointScaleFullCircle) {
-        // If we cover a full circle, we remove a slice to avoid having data point at the same place.
-        angles[1] -= diff / axis.data!.length;
-      }
-      return { range: angles, isPointScaleFullCircle };
+    const angles = [
+      deg2rad((axis as RotationConfig).startAngle, 0),
+      deg2rad((axis as RotationConfig).endAngle, 2 * Math.PI),
+    ];
+    const diff = angles[1] - angles[0];
+    const isFullCircle = diff >= Math.PI * 2 - EPSILON;
+    if (axis.scaleType === 'point' && diff > Math.PI * 2 - 0.1) {
+      // For point scale, remove a slice to avoid overlapping first and last points.
+      angles[1] -= diff / axis.data!.length;
     }
-    return {
-      range: [
-        deg2rad((axis as RotationConfig).startAngle, 0),
-        deg2rad((axis as RotationConfig).endAngle, 2 * Math.PI),
-      ],
-      isPointScaleFullCircle: false,
-    };
+    return { range: angles, isFullCircle };
   }
   const availableRadius = Math.min(drawingArea.height, drawingArea.width) / 2;
   return {
     range: [
       (axis as RadiusConfig).minRadius ?? 0,
       (axis as RadiusConfig).maxRadius ?? availableRadius,
     ],
-    isPointScaleFullCircle: false,
+    isFullCircle: false,
   };
 }
 
@@ -126,7 +118,7 @@ export function computeAxisValue<SeriesType extends ChartSeriesType>({
   const completeAxis: DefaultizedAxisConfig<ChartsAxisProps> = {};
   allAxis.forEach((eachAxis, axisIndex) => {
     const axis = eachAxis as Readonly<AxisConfig<ScaleName, any, Readonly<ChartsAxisProps>>>;
-    const { range, isPointScaleFullCircle } = getRange(drawingArea, axisDirection, axis);
+    const { range, isFullCircle } = getRange(drawingArea, axisDirection, axis);
 
     const [minData, maxData] = getAxisExtremum(
       axis,
@@ -160,6 +152,7 @@ export function computeAxisValue<SeriesType extends ChartSeriesType>({
           (axis.colorMap.type === 'ordinal'
             ? getOrdinalColorScale({ values: axis.data, ...axis.colorMap })
             : getColorScale(axis.colorMap)),
+        isFullCircle,
       };
 
       if (isDateData(axis.data)) {
@@ -180,7 +173,7 @@ export function computeAxisValue<SeriesType extends ChartSeriesType>({
           (axis.colorMap.type === 'ordinal'
             ? getOrdinalColorScale({ values: axis.data, ...axis.colorMap })
             : getColorScale(axis.colorMap)),
-        isPointScaleFullCircle,
+        isFullCircle,
       };
 
       if (isDateData(axis.data)) {
@@ -231,6 +224,7 @@ export function computeAxisValue<SeriesType extends ChartSeriesType>({
       scale: finalScale.domain(domain) as any,
       tickNumber,
       colorScale: axis.colorMap && getColorScale(axis.colorMap),
+      isFullCircle,
     };
   });
   return {

packages/x-charts/src/models/axis.ts

@@ -609,8 +609,8 @@ export type PolarAxisDefaultized<
      * If true, the contents of the axis will be displayed by a tooltip with `trigger='axis'`.
      */
     triggerTooltip?: boolean;
-    /** @ignore - internal. True when a point-scale rotation axis covers a full circle. */
-    isPointScaleFullCircle?: boolean;
+    /** @ignore - internal. True when a rotation axis covers a full circle. */
+    isFullCircle?: boolean;
   };
 
 export type ComputedAxis<
@@ -628,8 +628,8 @@ export type ComputedAxis<
      * Indicate if the axis should be consider by a tooltip with `trigger='axis'`.
      */
     triggerTooltip?: boolean;
-    /** @ignore - internal. True when a point-scale rotation axis covers a full circle. */
-    isPointScaleFullCircle?: boolean;
+    /** @ignore - internal. True when a rotation axis covers a full circle. */
+    isFullCircle?: boolean;
   } & (AxisProps extends ChartsXAxisProps
     ? AxisSideConfig<AxisProps> & { height: number }
     : AxisProps extends ChartsYAxisProps